Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  implemented
  group-17   |  Actual Points:  .5
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Answered there; merging this; thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  .5
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 A minor question there, but that's it - other than that it looks good!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  .5
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I've updated the branch to address your comments.  How is it now?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  .5
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Minor question on GL - other than that it looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  .5
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-

Comment (by nickm):

 https://gitlab.com/nickm_tor/tor/merge_requests/13

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:  .5
Parent ID: | Points:  3
 Reviewer: |Sponsor:  Sponsor4
---+
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => .5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  task   | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID: | Points:  3
 Reviewer: |Sponsor:  Sponsor4
---+

Comment (by nickm):

 Okay, my branch `storagedir` has a simple abstraction here.  We should
 think about whether this will serve our interests.  One problem here is
 that we can't have names that describe what's in the files, so we need to
 make sure we survive without persistent metadata outside the files here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  task   | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID: | Points:  3
 Reviewer: |Sponsor:  Sponsor4
---+

Comment (by nickm):

 And here's an issue: our seccomp2 sandbox means that we need to know all
 the possible filenames in advance.  So interesting filenames are out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  task   | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID: | Points:  3
 Reviewer: |Sponsor:  Sponsor4
---+
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted


Comment:

 This should also handle lack of disk space.  It would be good if we could
 also use this for a better "bogus document" storage system.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21645 [Core Tor/Tor]: prop140 / compression: Unified directory cache backend

[Tor Bug Tracker & Wiki]

#21645: prop140 / compression: Unified directory cache backend
--+
 Reporter:  nickm |  Owner:
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  TorCoreTeam201703
Actual Points:|  Parent ID:
   Points:  3 |   Reviewer:
  Sponsor:  Sponsor4  |
--+
 With prop140 and/or ahf's compression proposal, we'll need to cache more
 documents than previously, to include multiple consensuses, diffs,
 compressed consensuses, etc.  We could do this in an ad-hoc way, but we'll
 probably be better off with a real abstraction here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs