Re: [tor-bugs] #21651 [Core Tor/Tor]: prop140/compression: Refactor directory cache spooling code

[Tor Bug Tracker & Wiki]

#21651: prop140/compression: Refactor directory cache spooling code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  implemented
  group-17   |  Actual Points:  2
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by nickm_mobile):

 * status:  merge_ready => closed
 * resolution:   => implemented
 * actualpoints:  1 => 2


Comment:

 Squashed, merged, pushed.  Thanks for reviewing, ahf and asn!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21651 [Core Tor/Tor]: prop140/compression: Refactor directory cache spooling code

[Tor Bug Tracker & Wiki]

#21651: prop140/compression: Refactor directory cache spooling code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  1
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 All fixes look good to me!

 I'll turn this to `merge_ready`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21651 [Core Tor/Tor]: prop140/compression: Refactor directory cache spooling code

[Tor Bug Tracker & Wiki]

#21651: prop140/compression: Refactor directory cache spooling code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  1
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Thanks, asn.  I'll try to split things up better in the future.  Please
 remind me if I don't, or just ask me to revise.

 I've tried to fix the issues you found on the gitlab review, and added a
 couple of questions there about whether you think particular changes are
 needed.  Putting this back in needs_review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21651 [Core Tor/Tor]: prop140/compression: Refactor directory cache spooling code

[Tor Bug Tracker & Wiki]

#21651: prop140/compression: Refactor directory cache spooling code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  1
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Hello, I did a review for this ticket on gitlab. Please check it out! :)

 Also, I must say that the commit structure was not very helpful to review,
 especially since I'm not familiar with that part of the codebase
 (dirserv/connection logic):

 `8587f66` was pretty small and nice, but `6316f23` did everything and the
 kitchen sink. It moved code, it removed code and it added new code without
 splitting it into separate commits. So I had to continuously check between
 the code and the diff to see whether what I'm reviewing is new or old and
 how it used to be. I think if the branch was split into 3-4 commits it
 would be easier to review (e.g. one commit introduces the spooling
 structures and basic API, another commit moves old code to new functions,
 another commit edits such code, another commit introduces new code).

 Hope the review is useful!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21651 [Core Tor/Tor]: prop140/compression: Refactor directory cache spooling code

[Tor Bug Tracker & Wiki]

#21651: prop140/compression: Refactor directory cache spooling code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  1
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I've responded to the questions, added a typo fix, and moved this back
 into needs_review for the additional set of eyes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21651 [Core Tor/Tor]: prop140/compression: Refactor directory cache spooling code

[Tor Bug Tracker & Wiki]

#21651: prop140/compression: Refactor directory cache spooling code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  1
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Minor questions on GL. Could use one additional set of eyes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21651 [Core Tor/Tor]: prop140/compression: Refactor directory cache spooling code

[Tor Bug Tracker & Wiki]

#21651: prop140/compression: Refactor directory cache spooling code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorCoreTeam201703, prop140, review-  |  Actual Points:  1
  group-17   |
Parent ID:   | Points:  3
 Reviewer:  ahf  |Sponsor:
 |  Sponsor4
-+-

Comment (by nickm):

 https://gitlab.com/nickm_tor/tor/merge_requests/14

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21651 [Core Tor/Tor]: prop140/compression: Refactor directory cache spooling code

[Tor Bug Tracker & Wiki]

#21651: prop140/compression: Refactor directory cache spooling code
+--
 Reporter:  nickm   |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.1.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorCoreTeam201703, prop140  |  Actual Points:  1
Parent ID:  | Points:  3
 Reviewer:  |Sponsor:  Sponsor4
+--
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => 1


Comment:

 See branch `spooling` in my public repository.  The code here is already
 covered by the unit tests combined with the chutney integration tests, but
 please let me know if you think it could use more testing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21651 [Core Tor/Tor]: prop140/compression: Refactor directory cache spooling code

[Tor Bug Tracker & Wiki]

#21651: prop140/compression: Refactor directory cache spooling code
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorCoreTeam201703  |  Actual Points:
Parent ID: | Points:  3
 Reviewer: |Sponsor:  Sponsor4
---+
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #21651 [Core Tor/Tor]: prop140/compression: Refactor directory cache spooling code

[Tor Bug Tracker & Wiki]

#21651: prop140/compression: Refactor directory cache spooling code
--+
 Reporter:  nickm |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  TorCoreTeam201703
Actual Points:|  Parent ID:
   Points:  3 |   Reviewer:
  Sponsor:  Sponsor4  |
--+
 Our current logic for spooling things from a directory server is a bit
 loopy.  Instead we should refactor it so that "things to be spooled" is a
 first-class object, with implementations depending on what we're spooling.
 This will make lots of our directory improvement stuff easier to
 implement.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs