Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
-+-
 Reporter:  chelseakomlo |  Owner:
 |  dasyatid1
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, tor-pt, tor-bridge,  |  Actual Points:
  design, pt2, review-group-23, review-  |
  group-24, 034-triage-20180328, |
  034-removed-20180328   |
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
 |  SponsorM-can
-+-
Changes (by Samdney):

 * cc: Samdney (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
-+-
 Reporter:  chelseakomlo |  Owner:
 |  dasyatid1
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, tor-pt, tor-bridge,  |  Actual Points:
  design, pt2, review-group-23, review-  |
  group-24, 034-triage-20180328, |
  034-removed-20180328   |
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
 |  SponsorM-can
-+-
Changes (by ahf):

 * cc: ahf (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
-+-
 Reporter:  chelseakomlo |  Owner:
 |  dasyatid1
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, tor-pt, tor-bridge,  |  Actual Points:
  design, pt2, review-group-23, review-group-24  |
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
 |  SponsorM-can
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


Comment:

 ping -- is anyone still working for this?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
-+-
 Reporter:  chelseakomlo |  Owner:
 |  dasyatid1
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, tor-pt, tor-bridge,  |  Actual Points:
  design, pt2, review-group-23, review-group-24  |
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
 |  SponsorM-can
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Okay, I've left comments on the ticket.  It looks like a good start!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
-+-
 Reporter:  chelseakomlo |  Owner:
 |  dasyatid1
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, tor-pt, tor-bridge,  |  Actual Points:
  design, pt2, review-group-23, review-group-24  |
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
 |  SponsorM-can
-+-

Comment (by nickm):

 Starting review.   I've opened a code review ticket at
 https://oniongit.eu/nickm/tor/merge_requests/8 so I can comment on the
 commits. Please let me know if you have any problems reading them :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
-+-
 Reporter:  chelseakomlo |  Owner:
 |  dasyatid1
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, tor-pt, tor-bridge,  |  Actual Points:
  design, pt2, review-group-23, review-group-24  |
Parent ID:   | Points:
 Reviewer:  nickm|Sponsor:
 |  SponsorM-can
-+-
Changes (by nickm):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
-+-
 Reporter:  chelseakomlo |  Owner:
 |  dasyatid1
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, tor-pt, tor-bridge,  |  Actual Points:
  design, pt2, review-group-23, review-group-24  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  SponsorM-can
-+-
Changes (by nickm):

 * sponsor:   => SponsorM-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
-+-
 Reporter:  chelseakomlo |  Owner:
 |  dasyatid1
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, tor-pt, tor-bridge,  |  Actual Points:
  design, pt2, review-group-23   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by dcf):

 Here's a link to view the diff resulting from dasyatid's patch:
   https://bitbucket.org/DasyatidPrime/tor-
 rtt2017-21816/branches/compare/rtt2017%0Dmaster#diff

 One of the changes in the
 [https://operatorfoundation.org/PluggableTransportSpecification-v2-Draft3.pdf
 PT 2.0 spec draft 3] is that error responses such as ENV-ERROR, VERSION-
 ERROR, etc. are now written to stderr, not stdout. But I don't see
 anything the patch series that accounts for that?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
-+-
 Reporter:  chelseakomlo |  Owner:
 |  dasyatid1
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, tor-pt, tor-bridge,  |  Actual Points:
  design, pt2, review-group-23   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * cc: mcs (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
-+-
 Reporter:  chelseakomlo |  Owner:
 |  dasyatid1
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, tor-pt, tor-bridge,  |  Actual Points:
  design, pt2, review-group-23   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
-+-
 Reporter:  chelseakomlo |  Owner:
 |  dasyatid1
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-client tor-pt tor-bridge design  |  Actual Points:
  pt2|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by dasyatid1):

 * status:  new => assigned
 * owner:  (none) => dasyatid1
 * cc: dasyatid1 (added)


Comment:

 As I posted on tor-dev a little while ago, I've been working on a patchset
 for this as part of work I've been doing with blanu / Operator. This is
 available at Bitbucket ([https://bitbucket.org/DasyatidPrime/tor-
 rtt2017-21816.git Git], [https://bitbucket.org/DasyatidPrime/tor-
 rtt2017-21816/src Web]).

 With commit 887352263569, I've completed successful circuits through the
 "rtt2017" [https://github.com/OperatorFoundation/shapeshifter-
 dispatcher/tree/rtt2017 branch of shapeshifter-dispatcher] and
 [https://github.com/OperatorFoundation/shapeshifter-ipc/tree/rtt2017
 associated shapeshifter-ipc] using PT2 configuration protocol (there are
 changes there I still want to upstream), and through obfs4proxy using PT1,
 each acting as an obfs4 client for connecting via a bridge.

 I'd like to hear what would be necessary to merge a version of this.
 Currently on my radar: unit tests for JSON/RFC1929 encoding functions,
 'changes' documentation, possibly commit-level cleanup, possibly pushing
 on PT spec and/or Shapeshifter upstream to lock them down. I'm probably
 missing something, though. There are some other details in my
 [https://lists.torproject.org/pipermail/tor-dev/2017-August/012411.html
 original post to tor-dev].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
-+-
 Reporter:  chelseakomlo |  Owner:
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-client tor-pt tor-bridge design  |  Actual Points:
  pt2|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:   => tor-client tor-pt tor-bridge design pt2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
--+--
 Reporter:  chelseakomlo  |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by dcf):

 * cc: dcf (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
--+--
 Reporter:  chelseakomlo  |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by nickm_mobile):

 And in parallel: We all review the thing on tor-dev and make sure that
 it's what we want to implement :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
--+--
 Reporter:  chelseakomlo  |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by iang):

 Sitting here in the session with darkk.  We think this is what needs
 changing:

 - transports.c already negotiates the PT protocol version number, and
 sticks it in a
   managed_proxy_t (field conf_protocol)

 - In connection.c, around line 2225, tor calls
 get_socks_args_by_bridge_addrport to get the socks
   args, but that doesn't give us a handle to the managed_proxy_t

 - So we should call find_transport_name_by_bridge_addrport to get the
 transport name

 - Then we'll need a new function in transports.c that's very much like
   get_managed_proxy_by_argv_and_type, except it's
 get_managed_proxy_by_transport_name
   (it searches the managed_proxy_list, and for each entry, searches the
 transports list looking
   for a match).  It also needs to be non-static.

 Then we'd be able to access the conf_protocol field in connection.c, and
 do the small changes to use the alternate SOCKS 5 authentication method
 specified in the PT 2.0 spec.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
--+--
 Reporter:  chelseakomlo  |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by chelseakomlo):

 * cc: darkk, blanu (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21816 [Core Tor/Tor]: Add support for Pluggable Transports 2.0 (was: Add support for Pluggable Transport 2.0)

[Tor Bug Tracker & Wiki]

#21816: Add support for Pluggable Transports 2.0
--+--
 Reporter:  chelseakomlo  |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs