Re: [tor-bugs] #22779 [Core Tor/Tor]: choose_good_entry_server() is no longer used to choose entry guards

[Tor Bug Tracker & Wiki]

#22779: choose_good_entry_server() is no longer used to choose entry guards
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  maybe-030-backport, review-group-22  |  Actual Points:
Parent ID:   | Points:  0.5
 Reviewer:  asn  |Sponsor:
 |  SponsorV
-+-

Comment (by asn):

 ACKing this as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22779 [Core Tor/Tor]: choose_good_entry_server() is no longer used to choose entry guards

[Tor Bug Tracker & Wiki]

#22779: choose_good_entry_server() is no longer used to choose entry guards
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  maybe-030-backport, review-group-22  |  Actual Points:
Parent ID:   | Points:  0.5
 Reviewer:  asn  |Sponsor:
 |  SponsorV
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged to 0.3.2; I think we don't need to backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22779 [Core Tor/Tor]: choose_good_entry_server() is no longer used to choose entry guards

[Tor Bug Tracker & Wiki]

#22779: choose_good_entry_server() is no longer used to choose entry guards
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  maybe-030-backport, review-group-22  |  Actual Points:
Parent ID:   | Points:  0.5
 Reviewer:  asn  |Sponsor:
 |  SponsorV
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 ack.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22779 [Core Tor/Tor]: choose_good_entry_server() is no longer used to choose entry guards

[Tor Bug Tracker & Wiki]

#22779: choose_good_entry_server() is no longer used to choose entry guards
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  maybe-030-backport, review-group-22  |  Actual Points:
Parent ID:   | Points:  0.5
 Reviewer:  asn  |Sponsor:
 |  SponsorV
-+-
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22779 [Core Tor/Tor]: choose_good_entry_server() is no longer used to choose entry guards

[Tor Bug Tracker & Wiki]

#22779: choose_good_entry_server() is no longer used to choose entry guards
+
 Reporter:  teor|  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.0.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  maybe-030-backport  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:  SponsorV
+
Changes (by nickm):

 * status:  accepted => needs_review
 * sponsor:   => SponsorV


Comment:

 Replying to [ticket:22779 teor]:

 I have a patch here as `bug22779_031`.

 > * fix the comment,

 done

 > * check for NULL state (and do what?)

 In this case, we treat it as a nonfatal assertion. I've audited the code
 that calls this to make sure it can't happen.

 > * make sure that guard selection and entry selection doesn't get out of
 sync. (I think we're ok here, but I don't understand the new guard code
 very well.)

 I think we're okay here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22779 [Core Tor/Tor]: choose_good_entry_server() is no longer used to choose entry guards

[Tor Bug Tracker & Wiki]

#22779: choose_good_entry_server() is no longer used to choose entry guards
---+---
 Reporter:  teor   |  Owner:  nickm
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.1.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.0.1-alpha
 Severity:  Normal | Resolution:
 Keywords:  maybe-030-backport guards  |  Actual Points:  .1
Parent ID: | Points:  0.5
 Reviewer: |Sponsor:  SponsorV
---+---
Changes (by nickm):

 * keywords:  maybe-030-backport => maybe-030-backport guards
 * sponsor:   => SponsorV
 * actualpoints:   => .1


Comment:

 Replying to [ticket:22779 teor]:
 > choose_good_entry_server() says:
 > {{{
 >  * If state is NULL, we're choosing a router to serve as an entry
 >  * guard, not for any particular circuit.
 > }}}
 >
 > But in 0.3.0 and later, we use guardsets to choose entry guards.
 > (And we use this function to choose individual entries.)
 >
 > We should:
 > * fix the comment,
 > * check for NULL state (and do what?), and
 > * make sure that guard selection and entry selection doesn't get out of
 sync. (I think we're ok here, but I don't understand the new guard code
 very well.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22779 [Core Tor/Tor]: choose_good_entry_server() is no longer used to choose entry guards

[Tor Bug Tracker & Wiki]

#22779: choose_good_entry_server() is no longer used to choose entry guards
+
 Reporter:  teor|  Owner:  nickm
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.0.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  maybe-030-backport  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22779 [Core Tor/Tor]: choose_good_entry_server() is no longer used to choose entry guards

[Tor Bug Tracker & Wiki]

#22779: choose_good_entry_server() is no longer used to choose entry guards
--+
 Reporter:  teor  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.0.1-alpha
 Severity:  Normal|   Keywords:  maybe-030-backport
Actual Points:|  Parent ID:
   Points:  0.5   |   Reviewer:
  Sponsor:|
--+
 choose_good_entry_server() says:
 {{{
  * If state is NULL, we're choosing a router to serve as an entry
  * guard, not for any particular circuit.
 }}}

 But in 0.3.0 and later, we use guardsets to choose entry guards.
 (And we use this function to choose individual entries.)

 We should:
 * fix the comment,
 * check for NULL state (and do what?), and
 * make sure that guard selection and entry selection doesn't get out of
 sync. (I think we're ok here, but I don't understand the new guard code
 very well.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs