Re: [tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode

[Tor Bug Tracker & Wiki]

#22909: Our Rust code is always built in debug mode
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  invalid
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:  SponsorZ
-+-
Changes (by isis):

 * status:  reopened => closed
 * resolution:   => invalid


Comment:

 Replying to [comment:8 infinity0]:
 > I should have been explicit earlier but this ticket really should be
 closed, it is invalid.
 >
 > debug mode is `[profile.debug]`, i.e. what happens when you leave out
 `--release` when invoking `cargo`.
 >
 > `debug = true` is ''not'' "debug mode", it is to tell rustc to add
 DWARF2 debuginfo to the ELF binaries and is equivalent to `-g` flags to C
 compilers.

 Ah, I'm sorry, I understand what you meant now. `-g` just means it's
 passing `-C debuginfo=2`. Closing as invalid.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode

[Tor Bug Tracker & Wiki]

#22909: Our Rust code is always built in debug mode
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  defect   | Status:  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:  SponsorZ
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode

[Tor Bug Tracker & Wiki]

#22909: Our Rust code is always built in debug mode
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  defect   | Status:  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:  SponsorZ
-+-

Comment (by infinity0):

 Whoops, that should have been `[profile.dev]` not `[profile.debug]`, see
 the first link I posted. The rest of the comment is correct.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode

[Tor Bug Tracker & Wiki]

#22909: Our Rust code is always built in debug mode
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  defect   | Status:  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:  SponsorZ
-+-

Comment (by infinity0):

 I should have been explicit earlier but this ticket really should be
 closed, it is invalid.

 debug mode is `[profile.debug]`, i.e. what happens when you leave out
 `--release` when invoking `cargo`.

 `debug = true` is ''not'' "debug mode", it is to tell rustc to add DWARF2
 debuginfo to the ELF binaries and is equivalent to `-g` flags to C
 compilers.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode

[Tor Bug Tracker & Wiki]

#22909: Our Rust code is always built in debug mode
-+-
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:  SponsorZ
-+-
Changes (by chelseakomlo):

 * cc: chelseakomlo (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode

[Tor Bug Tracker & Wiki]

#22909: Our Rust code is always built in debug mode
-+-
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:  SponsorZ
-+-

Comment (by chelseakomlo):

 On http://doc.crates.io/guide.html:

 "Compiling in debug mode is the default for development-- compilation time
 is shorter since the compiler doesn't do optimizations, but the code will
 run slower. Release mode takes longer to compile, but the code will run
 faster."

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode

[Tor Bug Tracker & Wiki]

#22909: Our Rust code is always built in debug mode
-+-
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:  SponsorZ
-+-
Changes (by isis):

 * status:  closed => reopened
 * resolution:  invalid =>


Comment:

 Replying to [comment:3 Sebastian]:
 > Reason this is invalid: We're matching Tor's C code behaviour here,
 which always includes debug symbols, even in releases.

 That makes sense to try to match the C behaviour. Although, I think
 building Rust code in debug mode isn't really comparable to a C binary
 with debugging symbols… there's extra stuff going on there (like the over
 /under-flow checks), and it's not like we can just run strip on it to make
 it what it would've been without debugging enabled. It's more like
 building a C binary with UBSan and whatever other sanitisers enabled,
 which IIRC we don't do (`--enable-expensive-hardening` is off by default).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode

[Tor Bug Tracker & Wiki]

#22909: Our Rust code is always built in debug mode
-+-
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  invalid
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:  SponsorZ
-+-

Comment (by Sebastian):

 Reason this is invalid: We're matching Tor's C code behaviour here, which
 always includes debug symbols, even in releases.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode

[Tor Bug Tracker & Wiki]

#22909: Our Rust code is always built in debug mode
-+-
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  invalid
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:  SponsorZ
-+-
Changes (by Sebastian):

 * status:  new => closed
 * resolution:   => invalid


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode

[Tor Bug Tracker & Wiki]

#22909: Our Rust code is always built in debug mode
-+-
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:  SponsorZ
-+-

Comment (by infinity0):

 https://doc.crates.io/manifest.html#the-profile-sections

 `debug = true` is for generating debuginfo. asserts are something else,
 `debug-assertions`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode

[Tor Bug Tracker & Wiki]

#22909: Our Rust code is always built in debug mode
--+-
 Reporter:  isis  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  rust, rust-pilot, tor-build
Actual Points:|  Parent ID:
   Points:  .1|   Reviewer:
  Sponsor:  SponsorZ  |
--+-
 In `src/rust/Cargo.toml`:

 {{{
 [profile.release]
 debug = true
 }}}

 This enables certain things, e.g. `debug_assert!(false = true)` will
 panic.  It also does stuff like bounds checks for every access and integer
 overflow/underflow checks every time any number is used.  These are great
 things to do, but they are usually done in debug builds which are used in
 ''testing'', not in release.  This will make our code literally hundreds
 of times slower, so we should probably remove this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs