Re: [tor-bugs] #23094 [Core Tor/Tor]: prop224: Optimize hsdir_index calculation

[Tor Bug Tracker & Wiki]

#23094: prop224: Optimize hsdir_index calculation
-+-
 Reporter:  asn  |  Owner:  neel
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra,  |  implemented
  032-unreached  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged this to master; thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23094 [Core Tor/Tor]: prop224: Optimize hsdir_index calculation

[Tor Bug Tracker & Wiki]

#23094: prop224: Optimize hsdir_index calculation
-+-
 Reporter:  asn  |  Owner:  neel
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra,  |  Actual Points:
  032-unreached  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Ok, I opened #24964 for the remaining work.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23094 [Core Tor/Tor]: prop224: Optimize hsdir_index calculation

[Tor Bug Tracker & Wiki]

#23094: prop224: Optimize hsdir_index calculation
-+-
 Reporter:  asn  |  Owner:  neel
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra,  |  Actual Points:
  032-unreached  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by neel):

 Replying to [comment:9 teor]:
 > We can do this in a separate ticket if you'd like to merge just the
 first patch. They are independent. And integers are cheap.

 I think think we should just merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23094 [Core Tor/Tor]: prop224: Optimize hsdir_index calculation

[Tor Bug Tracker & Wiki]

#23094: prop224: Optimize hsdir_index calculation
-+-
 Reporter:  asn  |  Owner:  neel
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra,  |  Actual Points:
  032-unreached  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Replying to [ticket:23094 asn]:
 > Let's include `hsdir_index_t` in the node_t instead of a pointer that we
 allocate, since that structure is always present anyway.
 >
 > See here for more details:
 > https://oniongit.eu/dgoulet/tor/merge_requests/6#note_412

 This is implemented in https://github.com/neelchauhan/tor/tree/b23094 and
 is ready to merge.

 Replying to [comment:3 asn]:
 > After our #23387 refactoring of hsdir index logic Nick suggested that we
 don't need to keep all 3 around in memory, since two of them are always
 identical:
 > https://oniongit.eu/asn/tor/merge_requests/6#note_1201

 Removing hsdir_index_t.fetch is not implemented.
 We need to:
 * analyse the state machine of fetch, store_first, and store_second to
 make sure that fetch is always equal to store_first or store_second
 * work out the condition that we can use to select betweeen store_first or
 store_second when we want fetch
 * write a function that produces fetch from a hsdir_index_t, and use it
 instead of fetch

 We can do this in a separate ticket if you'd like to merge just the first
 patch. They are independent. And integers are cheap.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23094 [Core Tor/Tor]: prop224: Optimize hsdir_index calculation

[Tor Bug Tracker & Wiki]

#23094: prop224: Optimize hsdir_index calculation
-+-
 Reporter:  asn  |  Owner:  neel
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra,  |  Actual Points:
  032-unreached  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by neel):

 Travis CI for this patch is: https://travis-
 ci.org/neelchauhan/tor/builds/372561294

 It seems to have all passed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23094 [Core Tor/Tor]: prop224: Optimize hsdir_index calculation

[Tor Bug Tracker & Wiki]

#23094: prop224: Optimize hsdir_index calculation
-+-
 Reporter:  asn  |  Owner:  neel
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra,  |  Actual Points:
  032-unreached  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review
 * type:  defect => enhancement
 * milestone:  Tor: unspecified => Tor: 0.3.4.x-final


Comment:

 Seems ok to me, but someone should turn it into a GitHub branch and run it
 through Travis CI before it is merged.

 Neel, if you would like to run your branches through Travis CI, here is
 how to set it up:
 https://trac.torproject.org/projects/tor/ticket/23883#comment:3

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23094 [Core Tor/Tor]: prop224: Optimize hsdir_index calculation

[Tor Bug Tracker & Wiki]

#23094: prop224: Optimize hsdir_index calculation
-+-
 Reporter:  asn  |  Owner:  neel
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra,  |  Actual Points:
  032-unreached  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * Attachment "b23094-r001.patch" added.

 Patch (Revision 1)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23094 [Core Tor/Tor]: prop224: Optimize hsdir_index calculation

[Tor Bug Tracker & Wiki]

#23094: prop224: Optimize hsdir_index calculation
-+-
 Reporter:  asn  |  Owner:  neel
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra,  |  Actual Points:
  032-unreached  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by neel):

 I have a patch for this. The filename is `b23094-r001.patch`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23094 [Core Tor/Tor]: prop224: Optimize hsdir_index calculation

[Tor Bug Tracker & Wiki]

#23094: prop224: Optimize hsdir_index calculation
-+-
 Reporter:  asn  |  Owner:  neel
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra,  |  Actual Points:
  032-unreached  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * cc: neel@… (added)
 * owner:  (none) => neel
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23094 [Core Tor/Tor]: prop224: Optimize hsdir_index calculation

[Tor Bug Tracker & Wiki]

#23094: prop224: Optimize hsdir_index calculation
+--
 Reporter:  asn |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--

Comment (by asn):

 After our #23387 refactoring of hsdir index logic Nick suggested that we
 don't need to keep all 3 around in memory, since two of them are always
 identical:
 https://oniongit.eu/asn/tor/merge_requests/6#note_1201

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23094 [Core Tor/Tor]: prop224: Optimize hsdir_index calculation (was: prop224: Include hsdir_index in node_t instead of pointer)

[Tor Bug Tracker & Wiki]

#23094: prop224: Optimize hsdir_index calculation
+--
 Reporter:  asn |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs