Re: [tor-bugs] #23645 [Core Tor/Tor]: hs: Continue to improve logging in both HS and circuit subsystems

[Tor Bug Tracker & Wiki]

#23645: hs: Continue to improve logging in both HS and circuit subsystems
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-hs, tor-circuit, logging  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 thanks for the fix; I'm adding a changes file and merging.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23645 [Core Tor/Tor]: hs: Continue to improve logging in both HS and circuit subsystems

[Tor Bug Tracker & Wiki]

#23645: hs: Continue to improve logging in both HS and circuit subsystems
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, tor-circuit, logging  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 This needs a changes file; also, the tests don't pass for me:
 {{{
 hs_service/build_update_descriptors: [forking]
   FAIL src/test/test_hs_service.c:1154: expected log to contain "just
 picked 1 intro points and wanted 3. It " "currently has 0 intro points.
 Launching " "ESTABLISH_INTRO circuit shortly."  Captured logs:
 }}}

 asn, is it possible that you didn't commit some of your changes on your
 branch? I don't see any unit test fixes in this branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23645 [Core Tor/Tor]: hs: Continue to improve logging in both HS and circuit subsystems

[Tor Bug Tracker & Wiki]

#23645: hs: Continue to improve logging in both HS and circuit subsystems
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, tor-circuit, logging  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Please see branch `ticket23645_032_01` in my repo. It contains David's
 branch, plus it fixes a unittest that was expecting the wrong logs, plus
 it silences another annoying warning.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23645 [Core Tor/Tor]: hs: Continue to improve logging in both HS and circuit subsystems

[Tor Bug Tracker & Wiki]

#23645: hs: Continue to improve logging in both HS and circuit subsystems
--+
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, tor-circuit, logging  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * status:  assigned => needs_review


Comment:

 See branch: `ticket23645_032_01`.

 That `n_circ_id` and `globale_identifier` needs to be a pair in the logs
 so we can match from allocation to freeing it correctly else it's a
 guessing game.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23645 [Core Tor/Tor]: hs: Continue to improve logging in both HS and circuit subsystems

[Tor Bug Tracker & Wiki]

#23645: hs: Continue to improve logging in both HS and circuit subsystems
--+--
 Reporter:  dgoulet   |  Owner:  dgoulet
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-hs, tor-circuit, logging
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Having #23604 merged has already paid off big time.

 This ticket is about going for a second iteration on improving logging
 overall with circuits and hidden service.

 There are actually two bugs with #23604 (nothing serious) so this ticket
 will also address it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs