Re: [tor-bugs] #23975 [Core Tor/Tor]: Make node_get_*_orport() check addresses in the right order

[Tor Bug Tracker & Wiki]

#23975: Make node_get_*_orport() check addresses in the right order
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  ipv6  |  Actual Points:  1
Parent ID:  #20916| Points:  1
 Reviewer:|Sponsor:
--+

Comment (by teor):

 This branch rapidly got out of control.
 I want to split it into:
 * a branch that avoids using microdesc IPv6 addresses when the consensus
 method is high enough
 * a branch that gets rid of IPv6 DirPorts
 * a branch that deals with the bridge stuff
 * a branch that does any other stuff

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23975 [Core Tor/Tor]: Make node_get_*_orport() check addresses in the right order

[Tor Bug Tracker & Wiki]

#23975: Make node_get_*_orport() check addresses in the right order
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  ipv6  |  Actual Points:  1
Parent ID:  #20916| Points:  1
 Reviewer:|Sponsor:
--+

Comment (by teor):

 We should probably fix the onion key functions as well when we do this,
 and any other functions that implement a similar pattern of directory
 document checks. This depends on #23966.

 Maybe there's even a way to make these generic?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23975 [Core Tor/Tor]: Make node_get_*_orport() check addresses in the right order

[Tor Bug Tracker & Wiki]

#23975: Make node_get_*_orport() check addresses in the right order
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  ipv6  |  Actual Points:  1
Parent ID:  #20916| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * keywords:  ipv6, regression => ipv6
 * actualpoints:   => 1


Comment:

 This branch also obsoletes ReachableDirAddresses and removes all IPv6
 DirPort code.
 Removing it was easier than trying to fix it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23975 [Core Tor/Tor]: Make node_get_*_orport() check addresses in the right order

[Tor Bug Tracker & Wiki]

#23975: Make node_get_*_orport() check addresses in the right order
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  ipv6, regression  |  Actual Points:
Parent ID:  #20916| Points:  1
 Reviewer:|Sponsor:
--+

Comment (by teor):

 I wrote a draft branch bug23975_tree, which uses the new consensus methods
 from bug23826-23828.

 It still needs revision to fix some unit test failures.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23975 [Core Tor/Tor]: Make node_get_*_orport() check addresses in the right order

[Tor Bug Tracker & Wiki]

#23975: Make node_get_*_orport() check addresses in the right order
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  ipv6, regression  |  Actual Points:
Parent ID:  #20916| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * owner:  (none) => teor
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #23975 [Core Tor/Tor]: Make node_get_*_orport() check addresses in the right order

[Tor Bug Tracker & Wiki]

#23975: Make node_get_*_orport() check addresses in the right order
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal|   Keywords:  ipv6, regression
Actual Points:|  Parent ID:  #20916
   Points:  1 |   Reviewer:
  Sponsor:|
--+
 node_get_pref_ipv6_orport() and node_get_prim_orport() check addresses in
 the following order:
 * routerinfo / descriptor (modified by rewrite_bridge_address_for_node())
 * routerstatus / consensus
 * microdesc

 Clients, bridge clients, and relays usually get the correct address from
 node_get_pref_ipv6_orport() and node_get_prim_orport(), whether they are
 using microdescriptors or not.

 But there are a few cases when this breaks:
 * bridge clients should only check routerinfo for configured bridges
 * all clients and relays that use microdescs should never check full
 descriptors (and vice versa, except for the bridge case)
 * all clients and relays that use full descriptors should ignore the IPv6
 address in the descriptor
 * all clients and relays that use microdescriptors should ignore the IPv6
 address in the microdescriptor, when using a consensus method that puts
 IPv6 addresses in the microdesc consensus, otherwise they should use the
 microdescriptor

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs