Re: [tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
-+-
 Reporter:  cypherpunks  |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  tor-log, easy, intro, review-|  implemented
  group-32, 034-triage-20180328, |  Actual Points:
  034-removed-20180328   |
Parent ID:   | Points:  0.1
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 looks fine; merged it!  Agree about not needing a backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
-+-
 Reporter:  cypherpunks  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  tor-log, easy, intro, review-|  Actual Points:
  group-32, 034-triage-20180328, |
  034-removed-20180328   |
Parent ID:   | Points:  0.1
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 Oh, CI is here:
 https://travis-ci.org/teor2345/tor/builds/419560198
 https://ci.appveyor.com/project/teor2345/tor/build/1.0.82

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
-+-
 Reporter:  cypherpunks  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  tor-log, easy, intro, review-|  Actual Points:
  group-32, 034-triage-20180328, |
  034-removed-20180328   |
Parent ID:   | Points:  0.1
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => needs_review
 * milestone:  Tor: unspecified => Tor: 0.3.5.x-final


Comment:

 Please see my branch bug24312-master on
 https://github.com/teor2345/tor.git

 We can backport this fix if we'd like, but since it just removes "in the
 future" from a log message, I'm not sure it's worth it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
-+-
 Reporter:  cypherpunks  |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  tor-log, easy, intro, review-|  Actual Points:
  group-32   |
Parent ID:   | Points:  0.1
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision
 * reviewer:   => teor


Comment:

 There is an extra space at the end of the log message.
 Please also consider revising the wording.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  tor-log, easy, intro  |  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  reopened => needs_review


Comment:

 I've marked this as "needs review", someone will review the ticket in the
 next week or two.
 It's up to you if you want to revise the message before then.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  tor-log, easy, intro  |  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+

Comment (by cypherpunks):

 you use:
 "Many client versions will not choose us as a guard. "

 I'd say that operator mostly do not care about how many different versions
 of client
 will not choose us as a guard but how many of the overall clients (client
 fraction),
 so maybe lets use:

 "Most tor clients will not us as a guard."
 What do you think?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  tor-log, easy, intro  |  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+

Comment (by minik):

 I think I created the patch correctly. Please let me know if this looks
 right. I pulled down my own repo and just added a patch like before... so
 hopefully the version of tor I did the patch on was the most recent.

 https://github.com/ingoglia/tor_tickets/tree/bug24312

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  tor-log, easy, intro  |  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+

Comment (by teor):

 Whoever writes the patch can choose the exact wording.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  tor-log, easy, intro  |  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+

Comment (by cypherpunks):

 I'd say
 "Most client versions will not choose us as a guard."
 since most use Tor Browser as the client (which runs a current version of
 tor)?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  tor-log, easy, intro  |  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+

Comment (by teor):

 This warning only applies to Tor client versions 0.3.1, 0.3.2, and 0.3.3.
 0.2.5 and 0.2.9 will still choose non-DirCache relays as guards.
 And I authorities will still flag non-DirCache relays as guards.

 So I suggest we say "Some client versions will not choose us as a guard."

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  tor-log, easy, intro  |  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * keywords:   => tor-log, easy, intro
 * points:   => 0.1
 * severity:  Normal => Minor
 * milestone:   => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
--+--
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by cypherpunks):

 * status:  closed => reopened
 * resolution:  not a bug =>


Comment:

 Hi David,

 I think there is a misunderstanding. This ticket is not about showing a
 warning to Tor Browser users.

 This ticket is about the fact that tor (relay) says:
 {{{
 This may disqualify us from becoming a guard in the future.
 }}}
 , but it should say:

 {{{
 This disqualifies us from becoming a guard.
 }}}

 or am I wrong about this?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
--+---
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  not a bug
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by dgoulet):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 "tor" in Tor Browser aren't relays so this warning can't be showed with
 Tor Browser.

 Only relays can get this warning if the available memory is `>= 300MB` and
 `DirCache 0`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #24312 [Core Tor/Tor]: Update DirCache Warning

[Tor Bug Tracker & Wiki]

#24312: Update DirCache Warning
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 When DirCache is disabled tor 0.3.1.x says:

 {{{
 [warn] DirCache is disabled and we are configured as a relay. This may
 disqualify us from becoming a guard in the future.
 }}}

 Since TorBrowser ships tor 0.3.1.x we can consider this as granted (not in
 the future), right?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs