Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
-+-
 Reporter:  tom  |  Owner:  neel
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-dirauth, easy, intro,|  Actual Points:
  034-triage-20180328, 034-removed-20180328, |
  asn-merge  |
Parent ID:  #24403   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  SponsorV-can
-+-
Changes (by teor):

 * version:   => Tor: 0.2.4.1-alpha


Comment:

 The changes file for this release said "bugfix on 0.4.0.1-alpha". I fixed
 it in the ChangeLog and ReleaseNotes in #31461.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
-+-
 Reporter:  tom  |  Owner:  neel
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-dirauth, easy, intro,|  Actual Points:
  034-triage-20180328, 034-removed-20180328, |
  asn-merge  |
Parent ID:  #24403   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  SponsorV-can
-+-
Changes (by asn):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
-+-
 Reporter:  tom  |  Owner:  neel
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, easy, intro,|  Actual Points:
  034-triage-20180328, 034-removed-20180328, |
  asn-merge  |
Parent ID:  #24403   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  SponsorV-can
-+-
Changes (by nickm):

 * keywords:  tor-dirauth, easy, intro, 034-triage-20180328,
 034-removed-20180328 =>
 tor-dirauth, easy, intro, 034-triage-20180328, 034-removed-20180328,
 asn-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
-+-
 Reporter:  tom  |  Owner:  neel
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, easy, intro,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #24403   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  SponsorV-can
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 Yes; this looks great.  Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
-+-
 Reporter:  tom  |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, easy, intro,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #24403   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  SponsorV-can
-+-
Changes (by neel):

 * status:  needs_revision => needs_review


Comment:

 I made the changes and pushed them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
-+-
 Reporter:  tom  |  Owner:  neel
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, easy, intro,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #24403   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  SponsorV-can
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Hi!  I'd suggest that instead of overriding the last_reachable6 flag in
 node, we should override the place where we assign the ipv6_addr in the
 routerstatus:
 {{{
   if (options->AuthDirHasIPv6Connectivity == 1 &&
   !tor_addr_is_null(>ipv6_addr) &&
   node->last_reachable6 >= now - REACHABLE_TIMEOUT) {
 /* We're configured as having IPv6 connectivity. There's an IPv6
OR port and it's reachable so copy it to the routerstatus.  */
 tor_addr_copy(>ipv6_addr, >ipv6_addr);
 rs->ipv6_orport = ri->ipv6_orport;
 }}}

 (in set_routerstatus_from_routerinfo())

 Instead of checking whether last_reachable6 is recent, we could check
 whether it is recent OR the router is ourself.

 Note that I think this change will make the test expression above way too
 complicated, and we should extract it into its own function, maybe called
 something like should_publish_node_ipv6().

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
-+-
 Reporter:  tom  |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, easy, intro,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #24403   | Points:  1
 Reviewer:  nickm|Sponsor:
 |  SponsorV-can
-+-
Changes (by dgoulet):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
-+-
 Reporter:  tom  |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, easy, intro,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #24403   | Points:  1
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-
Changes (by nickm):

 * status:  assigned => needs_review
 * milestone:  Tor: unspecified => Tor: 0.4.1.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
-+-
 Reporter:  tom  |  Owner:  neel
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, easy, intro,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #24403   | Points:  1
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-

Comment (by neel):

 I have a PR here: https://github.com/torproject/tor/pull/698

 I am not sure whether or not it is correct, but here it is.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
-+-
 Reporter:  tom  |  Owner:  neel
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, easy, intro,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #24403   | Points:  1
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-

Comment (by neel):

 Is the function `dirserv_set_router_is_running()` the function where a
 dirauth would set itself as running (e.g. the "Reachable" flag)?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
-+-
 Reporter:  tom  |  Owner:  neel
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, easy, intro,|  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #24403   | Points:  1
 Reviewer:   |Sponsor:
 |  SponsorV-can
-+-
Changes (by neel):

 * cc: neel (added)
 * owner:  (none) => neel
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
--+
 Reporter:  tom   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-dirauth, easy, intro  |  Actual Points:
Parent ID:  #24403| Points:  1
 Reviewer:|Sponsor:  SponsorV-can
--+
Changes (by teor):

 * sponsor:   => SponsorV-can


Comment:

 Here's what we need to do to fix this bug:

 If an authority has an IPv6 ORPort, it should assume its own IPv6 ORPort
 is reachable, and vote for it.
 This is what authorities do for their own Reachable flag, so we should be
 able to use the same code for this fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
--+
 Reporter:  tom   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-dirauth, easy, intro  |  Actual Points:
Parent ID:  #24403| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * keywords:  needs-mandatory-IPv6, tor-dirauth, easy, intro => tor-dirauth,
 easy, intro
 * parent:   => #24403


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
-+-
 Reporter:  tom  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  needs-mandatory-IPv6, tor-dirauth,   |  Actual Points:
  easy, intro|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * parent:  #20916 =>
 * milestone:  Tor: very long term => Tor: 0.3.3.x-final


Comment:

 Hang on, we will need authorities to unconditionally advertise their own
 IPv6 address.

 When we implement relay IPv6 reachability checks, relays in a new network
 will need IPv6 addresses to bootstrap off.

 > If an authority votes for its own IPv6 address, and it's the only one to
 do this, then its IPv6 address will always be in the consensus, even if
 it's actually unreachable. (A single IPv6-voting authority can determine
 an IPv6 address by voting for it.)

 This is ok, because if we have a majority of authorities on IPv6 (that
 doesn't include that authority), that authority won't be marked Running,
 and its operator will notice.

 Also, we should do reachability checks on authority IPv6 addresses, but
 just warn if they fail. This is what we do for authority IPv4 addresses.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
-+-
 Reporter:  tom  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  very long term
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  needs-mandatory-IPv6, tor-dirauth,   |  Actual Points:
  easy, intro|
Parent ID:  #20916   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  IPv6, tor-dirauth, easy, intro => needs-mandatory-IPv6, tor-
 dirauth, easy, intro
 * sponsor:  SponsorV-can =>
 * milestone:  Tor: 0.3.3.x-final => Tor: very long term


Comment:

 I think this is a feature, not a bug.

 If an authority votes for its own IPv6 address, and it's the only one to
 do this, then its IPv6 address will always be in the consensus, even if
 it's actually unreachable. (A single IPv6-voting authority can determine
 an IPv6 address by voting for it.)

 When we make IPv6 mandatory on authorities, and change the consensus
 method so IPv6 votes are a simple majority, then we can fix this issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
+--
 Reporter:  tom |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  IPv6, tor-dirauth, easy, intro  |  Actual Points:
Parent ID:  #20916  | Points:  1
 Reviewer:  |Sponsor:  SponsorV-can
+--
Changes (by teor):

 * keywords:  IPv6, tor-dirauth => IPv6, tor-dirauth, easy, intro


Comment:

 dannenberg does not have an IPv6 ORPort in its descriptor, so this is the
 expected behaviour:

 http://193.23.244.244/tor/server/authority

 But we still need to fix the underlying bug:
 * if an authority has AuthDirHasIPv6Connectivity set, and
 * it has an IPv6 ORPort,
 * it should assume it's own IPv6 ORPort is reachable and vote for it

 This is what all authorities do with their own Running flag (which
 represents IPv4 and IPv6 ORPort reachability).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
---+
 Reporter:  tom|  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  IPv6, tor-dirauth  |  Actual Points:
Parent ID:  #20916 | Points:  1
 Reviewer: |Sponsor:  SponsorV-can
---+
Changes (by teor):

 * keywords:   => IPv6, tor-dirauth
 * points:   => 1
 * sponsor:   => SponsorV-can
 * parent:   => #20916
 * milestone:   => Tor: 0.3.3.x-final


Comment:

 Authorities should assume their configured IPv6 address is reachable, just
 like they do for IPv4.

 > Also strange: dannenberg votes on ReachableIPv6 but is not itself
 granted ReachableIPv6

 That's not surprising: voting on ReachableIPv6 requires outbound IPv6
 connectivity (like IPv6Exit).
 But receiving ReachableIPv6 requires inbound connectivity to an IPv6
 ORPort. Does it declare one in its descriptor?

 If it does, I'll email the dirauth list to let them know there's a
 misconfiguration, because it could end up with dannenberg not being marked
 Running,

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #24338 [Core Tor/Tor]: DirAuths that have IPv6 addresses don't include them in their vote on themself

[Tor Bug Tracker & Wiki]

#24338: DirAuths that have IPv6 addresses don't include them in their vote on
themself
--+
 Reporter:  tom   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Check out https://consensus-health.torproject.org/consensus-health.html
 and Control+f for:

 BD6A829255CB08E66FBE7D3748363586E46B3810
 847B1F850344D7876491A54892F904934E4EB85D
 24E2F139121D4394C54B5BCC368B3B411857C413
 F2044413DAC2E02E3D6BCF4735A19BCA1DE97281


 Also strange: dannenberg votes on ReachableIPv6 but is not itself granted
 ReachableIPv6

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs