Re: [tor-bugs] #24361 [Applications/rbm]: rbm gives an error if a build script contains a wide character

[Tor Bug Tracker & Wiki]

#24361: rbm gives an error if a build script contains a wide character
+
 Reporter:  boklm   |  Owner:  boklm
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/rbm|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201711R  |  Actual Points:
Parent ID:  #21998  | Points:
 Reviewer:  |Sponsor:
+

Comment (by gk):

 Replying to [comment:7 boklm]:
 > Replying to [comment:6 gk]:
 > >
 > > > After merging this commit, we will also need to update the README
 file in `tor-browser-build` to add `Path::Tiny` / `libpath-tiny-perl` to
 the list of dependencies, and removing `File::Slurp` / `libfile-slurp-
 perl`.
 > >
 > > Done in commit a6d54303ad89af777a4994dc27d0ae90945f090c on `master`. I
 adapted `main.yml` as well.
 >
 > I fixed the package name (File::Tiny => Path::Tiny) in commit
 39b88a7e8b03877bf478cafd1b72e9abc5694ca6.

 Ugh, sorry. I applied a fixup to clean up the remaining `read_file()` in
 commit 5c89374df7957238a9565c0b938ee3f30f880438 the `rbm` repo and bumped
 the `rbm` revision in `tor-browser-build` in commit
 57b65bcc24372b0d7eaff35bd8cf5089fd33b035. I hope we are finally done here
 now. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24361 [Applications/rbm]: rbm gives an error if a build script contains a wide character

[Tor Bug Tracker & Wiki]

#24361: rbm gives an error if a build script contains a wide character
+
 Reporter:  boklm   |  Owner:  boklm
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/rbm|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201711R  |  Actual Points:
Parent ID:  #21998  | Points:
 Reviewer:  |Sponsor:
+

Comment (by boklm):

 Replying to [comment:6 gk]:
 >
 > > After merging this commit, we will also need to update the README file
 in `tor-browser-build` to add `Path::Tiny` / `libpath-tiny-perl` to the
 list of dependencies, and removing `File::Slurp` / `libfile-slurp-perl`.
 >
 > Done in commit a6d54303ad89af777a4994dc27d0ae90945f090c on `master`. I
 adapted `main.yml` as well.

 I fixed the package name (File::Tiny => Path::Tiny) in commit
 39b88a7e8b03877bf478cafd1b72e9abc5694ca6.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24361 [Applications/rbm]: rbm gives an error if a build script contains a wide character

[Tor Bug Tracker & Wiki]

#24361: rbm gives an error if a build script contains a wide character
+
 Reporter:  boklm   |  Owner:  boklm
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/rbm|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201711R  |  Actual Points:
Parent ID:  #21998  | Points:
 Reviewer:  |Sponsor:
+
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:3 boklm]:
 > Replying to [comment:2 boklm]:
 > > This fix is not enough as we get an other error after that:
 > > {{{
 > > Wide character in syswrite at /usr/share/perl5/File/Slurp.pm line 506.
 > > }}}
 >
 > I added a second commit to branch `bug_24361` fixing this error:
 >
 
https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_24361=8b6831b36becc697fc53e61cac058d18096ea4b9

 Looks good. I merged your branch to `master` (commits
 8b6831b36becc697fc53e61cac058d18096ea4b9 and
 6406e0684a379d1316f747ed57060925efaf).

 > After merging this commit, we will also need to update the README file
 in `tor-browser-build` to add `Path::Tiny` / `libpath-tiny-perl` to the
 list of dependencies, and removing `File::Slurp` / `libfile-slurp-perl`.

 Done in commit a6d54303ad89af777a4994dc27d0ae90945f090c on `master`. I
 adapted `main.yml` as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24361 [Applications/rbm]: rbm gives an error if a build script contains a wide character

[Tor Bug Tracker & Wiki]

#24361: rbm gives an error if a build script contains a wide character
+--
 Reporter:  boklm   |  Owner:  boklm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/rbm|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201711R  |  Actual Points:
Parent ID:  #21998  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201712R => tbb-rbm,
   TorBrowserTeam201711R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24361 [Applications/rbm]: rbm gives an error if a build script contains a wide character

[Tor Bug Tracker & Wiki]

#24361: rbm gives an error if a build script contains a wide character
+--
 Reporter:  boklm   |  Owner:  boklm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/rbm|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201712R  |  Actual Points:
Parent ID:  #21998  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * parent:   => #21998


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24361 [Applications/rbm]: rbm gives an error if a build script contains a wide character

[Tor Bug Tracker & Wiki]

#24361: rbm gives an error if a build script contains a wide character
+--
 Reporter:  boklm   |  Owner:  boklm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/rbm|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201712R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:2 boklm]:
 > This fix is not enough as we get an other error after that:
 > {{{
 > Wide character in syswrite at /usr/share/perl5/File/Slurp.pm line 506.
 > }}}

 I added a second commit to branch `bug_24361` fixing this error:
 
https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_24361=8b6831b36becc697fc53e61cac058d18096ea4b9

 After merging this commit, we will also need to update the README file in
 `tor-browser-build` to add `Path::Tiny` / `libpath-tiny-perl` to the list
 of dependencies, and removing `File::Slurp` / `libfile-slurp-perl`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24361 [Applications/rbm]: rbm gives an error if a build script contains a wide character

[Tor Bug Tracker & Wiki]

#24361: rbm gives an error if a build script contains a wide character
+--
 Reporter:  boklm   |  Owner:  boklm
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/rbm|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201712R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * status:  needs_review => needs_revision


Comment:

 This fix is not enough as we get an other error after that:
 {{{
 Wide character in syswrite at /usr/share/perl5/File/Slurp.pm line 506.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24361 [Applications/rbm]: rbm gives an error if a build script contains a wide character

[Tor Bug Tracker & Wiki]

#24361: rbm gives an error if a build script contains a wide character
+--
 Reporter:  boklm   |  Owner:  boklm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/rbm|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201712R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * status:  new => needs_review
 * keywords:  tbb-rbm, TorBrowserTeam201712 => tbb-rbm,
   TorBrowserTeam201712R


Comment:

 The branch `bug_24361` in my git repo has a patch to fix this:
 
https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_24361=134cad4e79471d7baa82f00b4a6e2d7f7d11868a

 This change should not modify the sha256sum of build scripts which do not
 contain any wide character. I checked that the `var/build_id` value (which
 is doing a `sha256` on the build script and all dependencies) reported by
 the following commands is identical with and without the patch:
 {{{
 ./rbm/rbm showconf --target alpha --target torbrowser-linux-x86_64 tor-
 browser var/build_id
 ./rbm/rbm showconf --target alpha --target torbrowser-windows-x86_64 tor-
 browser var/build_id
 ./rbm/rbm showconf --target alpha --target torbrowser-osx-x86_64 tor-
 browser var/build_id
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #24361 [Applications/rbm]: rbm gives an error if a build script contains a wide character

[Tor Bug Tracker & Wiki]

#24361: rbm gives an error if a build script contains a wide character
---+---
 Reporter:  boklm  |  Owner:  boklm
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component: |Version:
  Applications/rbm |
 Severity:  Normal |   Keywords:  tbb-rbm, TorBrowserTeam201712
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+---
 When a build script contains a wide character, rbm fails with the
 following error:
 {{{
 Error: Template Error:
 undef error - Wide character in null operation at input text line 1.
 }}}

 The reason is that in `var/build_id`, we call `sha256` on the content of
 the build script, which is using the `sha256_hex` function, which doesn't
 support wide characters:
 http://perldoc.perl.org/Digest/SHA.html#UNICODE-AND-SIDE-EFFECTS

 We currently don't use any build script with wide character in `tor-
 browser-build`. However the file `projects/tor-browser/RelativeLink/start-
 tor-browser` does contain a wide character (curly quotes: ”), which is a
 problem if we want to use it as a template (for #21998).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs