Re: [tor-bugs] #24953 [Core Tor/Fallback Scripts]: In check_existing mode, log "fallback list", not "whitelist"

[Tor Bug Tracker & Wiki]

#24953: In check_existing mode, log "fallback list", not "whitelist"
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Fallback Scripts|Version:  Tor:
 |  0.3.0.3-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  fast-fix, fallback,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328, |
  035-triaged-in-20180711|
Parent ID:   | Points:  0.2
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 squashed and merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24953 [Core Tor/Fallback Scripts]: In check_existing mode, log "fallback list", not "whitelist"

[Tor Bug Tracker & Wiki]

#24953: In check_existing mode, log "fallback list", not "whitelist"
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Fallback Scripts|Version:  Tor:
 |  0.3.0.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, fallback,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328, |
  035-triaged-in-20180711|
Parent ID:   | Points:  0.2
 Reviewer:  teor |Sponsor:
-+-
Changes (by mikeperry):

 * status:  needs_review => merge_ready


Comment:

 These final fixups addressed Teor's comments.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24953 [Core Tor/Fallback Scripts]: In check_existing mode, log "fallback list", not "whitelist"

[Tor Bug Tracker & Wiki]

#24953: In check_existing mode, log "fallback list", not "whitelist"
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Fallback Scripts|Version:  Tor:
 |  0.3.0.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, fallback,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328, |
  035-triaged-in-20180711|
Parent ID:   | Points:  0.2
 Reviewer:  teor |Sponsor:
-+-
Changes (by rl1987):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24953 [Core Tor/Fallback Scripts]: In check_existing mode, log "fallback list", not "whitelist"

[Tor Bug Tracker & Wiki]

#24953: In check_existing mode, log "fallback list", not "whitelist"
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Fallback Scripts|Version:  Tor:
 |  0.3.0.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, fallback,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328, |
  035-triaged-in-20180711|
Parent ID:   | Points:  0.2
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision
 * reviewer:   => teor
 * version:   => Tor: 0.3.0.3-alpha


Comment:

 We're almost there, I left a few comments on the pull request.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24953 [Core Tor/Fallback Scripts]: In check_existing mode, log "fallback list", not "whitelist"

[Tor Bug Tracker & Wiki]

#24953: In check_existing mode, log "fallback list", not "whitelist"
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Fallback Scripts|Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, fallback,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328, |
  035-triaged-in-20180711|
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by rl1987):

 * status:  needs_revision => needs_review
 * cc: rl1987 (added)


Comment:

 Tried addressing these in 08921df6a2daa18729d9f3012d724d7ecb65883d.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24953 [Core Tor/Fallback Scripts]: In check_existing mode, log "fallback list", not "whitelist"

[Tor Bug Tracker & Wiki]

#24953: In check_existing mode, log "fallback list", not "whitelist"
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Fallback Scripts|Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, fallback,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328, |
  035-triaged-in-20180711|
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Thanks for this patch.

 These changes are good, but we want to use "whitelist" in the default
 mode, and "fallback list" in check_existing mode.
 (The script can run in two modes:
 
https://github.com/torproject/tor/blob/master/scripts/maint/updateFallbackDirs.py#L5
 )

 This is how the modes are implemented:
 
https://github.com/torproject/tor/blob/master/scripts/maint/updateFallbackDirs.py#L2210
 You could add a "type" key to the "whitelist" dictionary, and then use it
 in the strings.

 We also need to change "whitelist" in summarise_fallbacks:
 
https://github.com/torproject/tor/blob/master/scripts/maint/updateFallbackDirs.py#L2206

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24953 [Core Tor/Fallback Scripts]: In check_existing mode, log "fallback list", not "whitelist"

[Tor Bug Tracker & Wiki]

#24953: In check_existing mode, log "fallback list", not "whitelist"
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Fallback Scripts|Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, fallback,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328, |
  035-triaged-in-20180711|
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by rl1987):

 * status:  new => needs_review


Comment:

 https://github.com/torproject/tor/pull/634

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24953 [Core Tor/Fallback Scripts]: In check_existing mode, log "fallback list", not "whitelist"

[Tor Bug Tracker & Wiki]

#24953: In check_existing mode, log "fallback list", not "whitelist"
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Fallback Scripts|Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, fallback,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * parent:  #24786 =>


Comment:

 We don't need to do this ticket as part of the rebuild.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24953 [Core Tor/Fallback Scripts]: In check_existing mode, log "fallback list", not "whitelist"

[Tor Bug Tracker & Wiki]

#24953: In check_existing mode, log "fallback list", not "whitelist"
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Fallback Scripts|Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, fallback,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328  |
Parent ID:  #24786   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  fallback, 034-triage-20180328, 034-removed-20180328 => fast-
 fix, fallback, 034-triage-20180328, 034-removed-20180328
 * milestone:  Tor: unspecified => Tor: 0.3.4.x-final


Comment:

 This is a really fast fix, so let's do it in 0.3.4.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #24953 [Core Tor/Fallback Scripts]: In check_existing mode, log "fallback list", not "whitelist"

[Tor Bug Tracker & Wiki]

#24953: In check_existing mode, log "fallback list", not "whitelist"
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.4.x-final
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal |   Keywords:  fallback
Actual Points: |  Parent ID:  #24786
   Points:  0.2|   Reviewer:
  Sponsor: |
---+---
 This confused at least one relay operator.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs