Re: [tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
+--
 Reporter:  isis|  Owner:  (none)
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  rust, tor-doc, review-group-35  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:  SponsorM
+--
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Woo.  I think I have these merged.

 I had to rebase the first one onto maint-0.3.3 first, to merge it to that
 branch.  And I had to update the tor_log module to also use the second
 one.  So it's possible that I've messed something up here.  Please let me
 know if anything goes wrong. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
+--
 Reporter:  isis|  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, tor-doc, review-group-35  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:  SponsorM
+--

Comment (by isis):

 Replying to [comment:11 nickm]:
 > I can't find `bug25310_r1`, and the `update/libc-0.2.39_r1` branch
 appears to have no new commits.  Did you forget to push it these?  Am I
 looking in the wrong place?

 I uh… yes. Totally did not push them! Heh. Sorry sorry, they are there
 now:

 https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug25310_r1
 https://github.com/isislovecruft/tor-rust-
 dependencies/tree/update/libc-0.2.39_r1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
+--
 Reporter:  isis|  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, tor-doc, review-group-35  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:  SponsorM
+--

Comment (by nickm):

 I can't find `bug25310_r1`, and the `update/libc-0.2.39_r1` branch appears
 to have no new commits.  Did you forget to push it these?  Am I looking in
 the wrong place?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
+--
 Reporter:  isis|  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, tor-doc, review-group-35  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:  SponsorM
+--

Comment (by isis):

 Replying to [comment:9 isis]:
 > Updated versions which do not delete older dependencies are in my
 `bug25310_r1` and `update/libc-0.2.39_r1` branches respectively.

 Err, to be more specific, `bug25310_r1` should be merged into
 `maint-0.3.3` and `master` in tor.git, and `update/libc-0.2.39_r1` should
 get merged into `master` in tor-rust-dependencies.git.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
+--
 Reporter:  isis|  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, tor-doc, review-group-35  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:  SponsorM
+--

Comment (by isis):

 Updated versions which do not delete older dependencies are in my
 `bug25310_r1` and `update/libc-0.2.39_r1` branches respectively.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
+--
 Reporter:  isis|  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, tor-doc, review-group-35  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:  SponsorM
+--

Comment (by nickm):

 I'm okay with doing just the script update (to not remove dependencies,
 and to allow duplicate copies) for now. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
+--
 Reporter:  isis|  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, tor-doc, review-group-35  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:  SponsorM
+--

Comment (by isis):

 Replying to [comment:6 nickm]:
 > Hm.  I'm hoping that it's okay to take this in 0.3.3 and 0.3.4: it
 rebases cleanly to 0.3.3, but getting it into 0.3.2 would take more
 conflict-resolution than I have.
 >
 > Assuming that's the case, I made a branch called `bug25310_033` ... and
 then I ran into trouble.  If I don't update the libc dependency in tor-
 rust-dependencies, then the build will fail.  But if I do update the
 dependency, then 0.3.1 and 0.3.2 will fail (assuming they use libc), since
 the updateRustDependencies script will delete libc-0.2.2.22.
 >
 > Two options here:
 >
 >   1. Maybe we should update the updateRustDependencies.sh script so that
 it adds new crates, but does not remove the old ones, since they may still
 be needed for older Tors?
 >   2. Maybe we should update all the old tor branches to libc-0.2.39 for
 now, but also search for a better solution?

 (Oh no… why do I feel like this is going to result in us eventually
 implementing a custom dependency resolution algorithm… oh no… oh no…)

 I feel like !#1 would be the best option for now? And probably I should
 add a table in the README of tor-rust-dependencies, for each version we're
 currently maintaining, like:

 0.3.2

 || dependency || version  ||
 || libc   || 0.2.2.22 ||

 0.3.3

 || dependency || version  ||
 || libc   || 0.2.2.39 ||

 0.3.4

 || dependency || version  ||
 || libc   || 0.2.2.39 ||
 || rand   || 0.4.2||

 etc.? Then when a tor version drops out of support, we can remove
 whichever dependencies are no longer in a maintained version? Does that
 sound like a good idea? (Also document that we do this, of course.)

 I guess the other thing to do would be to just keep them all forever…
 doing so would at least allow someone to build older, unsupported tors
 later if they wanted to.

 I'll update the script to no longer remove dependencies and allow
 duplicate copies of dependencies.

 Re !#2: we might want to update 0.3.1 and 0.3.2 for now, if we care about
 *BSD and Solaris (I think there's also a few *nix patches between 0.2.22
 and 0.2.39 as well, but I didn't really look to see how vital any of them
 were)? But then again, it means the next versions in those series will
 build, while older/current ones will not (not sure how much we care).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
+--
 Reporter:  isis|  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, tor-doc, review-group-35  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:  SponsorM
+--

Comment (by nickm):

 Hm.  I'm hoping that it's okay to take this in 0.3.3 and 0.3.4: it rebases
 cleanly to 0.3.3, but getting it into 0.3.2 would take more conflict-
 resolution than I have.

 Assuming that's the case, I made a branch called `bug25310_033` ... and
 then I ran into trouble.  If I don't update the libc dependency in tor-
 rust-dependencies, then the build will fail.  But if I do update the
 dependency, then 0.3.1 and 0.3.2 will fail (assuming they use libc), since
 the updateRustDependencies script will delete libc-0.2.2.22.

 Two options here:

   1. Maybe we should update the updateRustDependencies.sh script so that
 it adds new crates, but does not remove the old ones, since they may still
 be needed for older Tors?
   2. Maybe we should update all the old tor branches to libc-0.2.39 for
 now, but also search for a better solution?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
+--
 Reporter:  isis|  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, tor-doc, review-group-35  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:  SponsorM
+--

Comment (by isis):

 Replying to [comment:4 nickm]:
 > This LGTM.  Should I take it 0.3.3 or earlier, or is 0.3.4-only fine?

 Whichever backports you're okay with? We started supported Rust in 0.3.1,
 right? And I started documenting our standards in 0.3.2… so if you decide
 to backport, maybe take it back to 0.3.2?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
+--
 Reporter:  isis|  Owner:  (none)
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, tor-doc, review-group-35  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:  SponsorM
+--
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 This LGTM.  Should I take it 0.3.3 or earlier, or is 0.3.4-only fine?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
+--
 Reporter:  isis|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, tor-doc, review-group-35  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:  SponsorM
+--
Changes (by isis):

 * status:  new => needs_review
 * keywords:  rust, tor-doc => rust, tor-doc, review-group-35


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
---+
 Reporter:  isis   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  rust, tor-doc  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:  SponsorM
---+

Comment (by isis):

 The documentation on our policy is in my `bug25310`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug25310 branch].
 Additionally, I've added another commit for a script for
 updating/adding/removing Rust dependencies, at
 `scripts/maint/updateRustDependencies.sh`. There's documentation in the
 script, as well as in the dependencies section of
 `doc/HACKING/CodingStandardsRust.md`. Finally, I ran the script to test it
 how easy it was to use, and how intuitive its error messages were, by
 updating our current dependency on libc from 0.2.22 to 0.2.39 (there's a
 [https://github.com/rust-
 lang/libc/commits/master?after=9c561768f9435428d847f18fd777dbd4e369317d+1
 bunch of fixes], mostly for *BSD and Solaris systems).  The changes for
 that are also included, and require merging my `update/libc-0.2.39`
 [https://github.com/isislovecruft/tor-rust-
 dependencies/tree/update/libc-0.2.39 branch] (from
 https://github.com/isislovecruft/tor-rust-dependencies) into the tor-rust-
 dependencies repo.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
---+
 Reporter:  isis   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  rust, tor-doc  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:  SponsorM
---+

Comment (by nickm):

 Also we should probably figure out what our plans are for keeping our
 dependencies up-to-date.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25310 [Core Tor/Tor]: Document our policy for Rust dependencies

[Tor Bug Tracker & Wiki]

#25310: Document our policy for Rust dependencies
--+
 Reporter:  isis  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  rust, tor-doc
Actual Points:|  Parent ID:
   Points:  1 |   Reviewer:
  Sponsor:  SponsorM  |
--+
 We should document what our (experimental, subject to change) policies are
 w.r.t. new Rust dependencies in tor, somewhere in the `doc/HACKING/`
 directory.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs