Re: [tor-bugs] #25374 [Core Tor/Tor]: Create a better-designed system for handling computation outside the event loop

[Tor Bug Tracker & Wiki]

#25374: Create a better-designed system for handling computation outside the 
event
loop
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  implemented
  034-triage-20180328, 034-included-20180328 |  Actual Points:
Parent ID:  #25500   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Resolved issue; merging now!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25374 [Core Tor/Tor]: Create a better-designed system for handling computation outside the event loop

[Tor Bug Tracker & Wiki]

#25374: Create a better-designed system for handling computation outside the 
event
loop
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25500   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 Let a comment on the PR:
 https://github.com/torproject/tor/pull/41#issuecomment-381180728

 This is merge_ready after that imo.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25374 [Core Tor/Tor]: Create a better-designed system for handling computation outside the event loop

[Tor Bug Tracker & Wiki]

#25374: Create a better-designed system for handling computation outside the 
event
loop
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25500   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-

Comment (by nickm):

 per dgoulet's request, I've rebased the branch onto master, and force-
 pushed it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25374 [Core Tor/Tor]: Create a better-designed system for handling computation outside the event loop

[Tor Bug Tracker & Wiki]

#25374: Create a better-designed system for handling computation outside the 
event
loop
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25500   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-
Changes (by dgoulet):

 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25374 [Core Tor/Tor]: Create a better-designed system for handling computation outside the event loop

[Tor Bug Tracker & Wiki]

#25374: Create a better-designed system for handling computation outside the 
event
loop
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25500   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by nickm):

 Github pr is https://github.com/torproject/tor/pull/41

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25374 [Core Tor/Tor]: Create a better-designed system for handling computation outside the event loop

[Tor Bug Tracker & Wiki]

#25374: Create a better-designed system for handling computation outside the 
event
loop
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25500   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 Now that `isolate_libevent_2` is merged, this branch can get reviewed.
 Please see `postloop_callbacks_2` on github and tor-git.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25374 [Core Tor/Tor]: Create a better-designed system for handling computation outside the event loop

[Tor Bug Tracker & Wiki]

#25374: Create a better-designed system for handling computation outside the 
event
loop
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25500   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by nickm):

 I've started work here in a branch called `postloop_callbacks` based on
 `isolate_libevent_2`.  It still needs tests and a changes file, and we'll
 need to rebase it once `isolate_libevent_2` is squashed and merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25374 [Core Tor/Tor]: Create a better-designed system for handling computation outside the event loop

[Tor Bug Tracker & Wiki]

#25374: Create a better-designed system for handling computation outside the 
event
loop
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Low   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #25500| Points:
 Reviewer:|Sponsor:  Sponsor8
--+
Changes (by nickm):

 * owner:  (none) => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25374 [Core Tor/Tor]: Create a better-designed system for handling computation outside the event loop

[Tor Bug Tracker & Wiki]

#25374: Create a better-designed system for handling computation outside the 
event
loop
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:  Sponsor8  |
--+
 Right now, we do a couple of things in `run_main_loop_once` that happen
 outside the event loop (because we want to re-scan for events event loop
 before they happen):
   * Making events on active_linked_connection_lst active.
   * Running connection_ap_attach_pending.

 But we can do this much better.  With Libevent 2.1, instead of making the
 loop exit for this, we can should do all of these things in a separate
 event callback, and call `event_base_loopcontinue()` at the end of that
 event's callback so that the event_base will get rescanned before we
 return. With earlier versions of Libevent, we can do something similar
 with event_base_loopbreak().

 Doing this won't lower the number of wakeups we do, but it should simplify
 our overall event loop logic, and make other event loop simplifications
 easier.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs