Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  karsten  |Sponsor:
-+--
Changes (by irl):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I think other things can be new tickets if we come across them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  karsten  |Sponsor:
-+--
Changes (by karsten):

 * status:  needs_review => new


Comment:

 Changes look good! Merged and deployed. Not closing yet, because I'm not
 sure if you want to do more. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  karsten  |Sponsor:
-+--
Changes (by irl):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:13 karsten]:
 > Okay, this went faster than it looked on first sight. I found two minor
 things:
 >  - Those `.class` files in `bin/` should probably not be in the
 repository. Can you remove them in a fixup commit that I can squash into
 714ae2d?

 Looks like these were added by Eclipse while I wasn't looking. Fixed.

 >  - There are now unused files in `src/main/resources/web/images/`, like
 `atlas.png` and `atlas.xcf`. Would you want to look out for other unused
 images and remove those, too, possibly in a separate (non-fixup) commit?

 Fixed this too. There are probably other things to tidy up, but would be
 smaller patches. Once this is merged, it would be easier to make more
 localised patches to address individual things and queue those up.

 > I can merge and deploy later today.

 Awesome. (:

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  karsten  |Sponsor:
-+
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Okay, this went faster than it looked on first sight. I found two minor
 things:
  - Those `.class` files in `bin/` should probably not be in the
 repository. Can you remove them in a fixup commit that I can squash into
 714ae2d?
  - There are now unused files in `src/main/resources/web/images/`, like
 `atlas.png` and `atlas.xcf`. Would you want to look out for other unused
 images and remove those, too, possibly in a separate (non-fixup) commit?

 I can merge and deploy later today.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  karsten  |Sponsor:
-+--
Changes (by karsten):

 * reviewer:   => karsten


Comment:

 I'll take a look today.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * status:  needs_information => needs_review


Comment:

 Please review my [[https://gitweb.torproject.org/user/irl/metrics-
 web.git/log/?h=task/25392|task/25392]] branch.

 {{{
 commit  714ae2df3d54608eadab5420035c3210e685c2f0

 Integrate RelaySearch (Fixes: #25392)

 This is using commit b6e6c3235806c9d1521dbc2c08cecee626466928 of
 atlas.git.

  * Removes submodule for RS.
  * Move two license files to basedirectory; these should be merged.
  * Move atlas.css into css folder
  * Fonts in both were identical
  * Changes all findable paths to the new setting
  * js libs were simply copied; these should be sorted out more
  * Merged rs/img and rs/images folder into images

 Thanks to iwakeh for the bulk of the work in this commit.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+---
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Description changed by iwakeh:

Old description:

> RelaySearch integration needs some tuning and streamlining:
> First steps
>
> 1. Move from `src/main/resources/web/rs` into `src/submods/relaysearch`
> 2. Only include fonts once into the war file (currently these are
> duplicated)
> 3. Avoid including readme files and scripts that are not needed for the
> running web application into the war file.
> 4. Separate preparation steps inside RelaySearch from building the war.
> 5. Create an Ant task that prepares RelaySearch for war file inclusion
> and adds the needed files to the war file.
>
> More tasks should be added as comments.

New description:

 Depending on the decision Metrics Team reaches:

 == In case Relay Search is merged into metrics-web

 This would require to add RS code to the appropriate places in metrics-
 web.
 (see comment:5 for a first draft branch)

 == In case Relay Search stays separate

 RelaySearch integration needs some tuning and streamlining:
 First steps

 1. Move from `src/main/resources/web/rs` into `src/submods/relaysearch`
 2. Only include fonts once into the war file (currently these are
 duplicated)
 3. Avoid including readme files and scripts that are not needed for the
 running web application into the war file.
 4. Separate preparation steps inside RelaySearch from building the war.
 5. Create an Ant task that prepares RelaySearch for war file inclusion and
 adds the needed files to the war file.

 More tasks should be added as comments.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+---
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  needs_information
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+---
Changes (by iwakeh):

 * status:  needs_review => needs_information


Comment:

 This ticket's description doesn't reflect the decision to finally merge RS
 into metrics-web, it rather describes the adaption of RS as separate sub-
 module.  The above steps are not necessary for the tight integration, they
 only make sense, if RS stays separate.

 It seems the discussion should be re-opened here?

 Setting to needs_information.

 This is a topic for the Aberdeen meeting.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by irl):

 Probably not this week, but I will review the changes in comment:4 as soon
 as I can. The plan in the description looks great though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * owner:  iwakeh => metrics-team
 * status:  accepted => assigned


Comment:

 If possible treat these ticket's children with highest priority and when
 implementing further RS functionality also make sure it ends up in the
 merge branch.

 The completeness of the merge branch regarding RS needs to checked.

 Re-assigning this to metrics-team now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 Please use [https://gitweb.torproject.org/user/iwakeh/metrics-
 web.git/commit/?h=task-25392=d53c790aa8e85adfeb6f042816eb41209d76ed50
 this branch] for all further work on RS into Metrics-web integration.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 For integrating rs into mw I started with rs commit
 b6e6c3235806c9d1521dbc2c08cecee626466928.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 A while ago we decided at the team meeting that RS will be integrated,
 i.e., merged into metrics-web, so the submodule will be obsolete then.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 See also #25393.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * owner:  metrics-team => iwakeh
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25392 [Metrics/Website]: Adapt Relay Search integration to Metrics' project standards

[Tor Bug Tracker & Wiki]

#25392: Adapt Relay Search integration to Metrics' project standards
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 RelaySearch integration needs some tuning and streamlining:
 First steps

 1. Move from `src/main/resources/web/rs` into `src/submods/relaysearch`
 2. Only include fonts once into the war file (currently these are
 duplicated)
 3. Avoid including readme files and scripts that are not needed for the
 running web application into the war file.
 4. Separate preparation steps inside RelaySearch from building the war.
 5. Create an Ant task that prepares RelaySearch for war file inclusion and
 adds the needed files to the war file.

 More tasks should be added as comments.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs