Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 |  implemented
 Keywords:  technical-debt, 034-triage-20180328  |  Actual Points:
Parent ID:   | Points:  0.5
 Reviewer:  isis |Sponsor:
-+-

Comment (by nickm):

 There was a dangling log_from_handle() causing warnings on Windows.  I
 removed it in d3b9b5a3dd6a6068557fc53176c41bc917100be2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 |  implemented
 Keywords:  technical-debt, 034-triage-20180328  |  Actual Points:
Parent ID:   | Points:  0.5
 Reviewer:  isis |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Rockin'!  Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  technical-debt, 034-triage-20180328  |  Actual Points:
Parent ID:   | Points:  0.5
 Reviewer:  isis |Sponsor:
-+-
Changes (by isis):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:11 nickm]:
 > Small changes needed: Instead of removing these lines in config.c,
 replace them to use OBSOLETE instead:
 > {{{
 > -  V(PortForwarding,  BOOL, "0"),
 > -  V(PortForwardingHelper,FILENAME, "tor-fw-helper"),
 > }}}
 > (That's how we remove options.)

 Okay, fixed! I've also added a changes file describing why the feature was
 removed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  technical-debt, 034-triage-20180328  |  Actual Points:
Parent ID:   | Points:  0.5
 Reviewer:  isis |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 Small changes needed: Instead of removing these lines in config.c, replace
 them to use OBSOLETE instead:
 {{{
 -  V(PortForwarding,  BOOL, "0"),
 -  V(PortForwardingHelper,FILENAME, "tor-fw-helper"),
 }}}
 (That's how we remove options.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  technical-debt, 034-triage-20180328  |  Actual Points:
Parent ID:   | Points:  0.5
 Reviewer:  isis |Sponsor:
-+-
Changes (by isis):

 * status:  needs_review => merge_ready


Comment:

 Hi Neel! Thanks for the patch! This looks good to me (and [https://travis-
 ci.org/isislovecruft/tor/builds/361912638 Travis passes]). I've applied
 your patch in my `bug25409`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug25409 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  technical-debt, 034-triage-20180328  |  Actual Points:
Parent ID:   | Points:  0.5
 Reviewer:  isis |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => isis


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
+
 Reporter:  arma|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:
+
Changes (by neel):

 * cc: neel@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
+
 Reporter:  arma|  Owner:  (none)
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
+
 Reporter:  arma|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:
+

Comment (by neel):

 I have a patch which removes PortForwarding options under the file
 b25409-001.patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
+
 Reporter:  arma|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:
+
Changes (by neel):

 * Attachment "b25409-001.patch" added.

 [PATCH] Remove PortForwarding options (Revision 1)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
+
 Reporter:  arma|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:
+

Comment (by yawning):

 Replying to [comment:1 nickm]:
 > IIUC, one of yawning's findings was that a depressingly large number of
 consumer routers can't actually be used this way, since they tend to brick
 themselves when upnp'd too hard.

 While I still stand behind the replacement implementation I wrote, and it
 tries to avoid certain behavior that has historically been troublesome, my
 view is that for users that this sort of tool would be useful for (someone
 that can't configure port forwarding on their own), the support burden for
 "your router doesn't implement UPnP-IGD or NAT-PMP/NAT-PCP correctly"
 would be rather large, because of the vast number of broken/buggy
 implementations of said protocols.

 The general consensus around the time the rewrite was completed was "apart
 from flashproxy, there isn't much use for this sort of thing due to
 consumer grade NAT being horrific", so I support the removal.

 It is somewhat of a shame because the utility will work fine for a
 sizeable fraction of router implementations out there, but when things go
 wrong, they go really wrong, which is a poor fit for a non-technical end
 user oriented piece of software.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
+
 Reporter:  arma|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:
+

Comment (by ahf):

 This is related to the PT windows code I'm looking at, but we can still
 rip this out if nobody is using it.

 Also see: https://lists.torproject.org/pipermail/tor-
 relays/2017-April/012198.html - only one response here so I think it's
 safe to remove.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
+
 Reporter:  arma|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:
+
Changes (by teor):

 * keywords:   => technical-debt
 * points:   => 0.5
 * milestone:   => Tor: 0.3.4.x-final


Comment:

 Let's deprecate it in 0.3.4 then?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 IIUC, one of yawning's findings was that a depressingly large number of
 consumer routers can't actually be used this way, since they tend to brick
 themselves when upnp'd too hard.

 I would be okay with removing this option only if we first deprecate it
 for a full release cycle.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

[Tor Bug Tracker & Wiki]

#25409: rip out PortForwarding options
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 A relay operator on tor-relays@ just got snookered into setting
 PortForwarding to 1, probably because he thought it would help him get
 port forwarding working on his relay.

 I think the reality is that almost nobody uses this option, and also we
 don't recommend it.

 Yawning rewrote the crappy dangerous C upnp apps in go:
 https://gitweb.torproject.org/tor.git/tree/src/tools/tor-fw-helper/README
 https://gitweb.torproject.org/tor-fw-helper.git/tree/README.md

 But I don't think we've taken any steps to get that go version into any
 user's hands.

 Also, our past use case, where Vidalia would launch Tor and want to let
 ordinary users turn themselves into relays or bridges, is long deprecated.

 Alternatives to "rip it out" would be "get yawning's go stuff packaged
 properly in Debian", or "add yawning's go stuff to the tor tarball and
 build it and ship it too".

 See also #21765 and its great phrase "I wonder how long this has been
 broken for".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs