Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
-+-
 Reporter:  viktorj  |  Owner:
 |  pospeselr
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #25147   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good now, thanks. Applied to `tor-browser-52.7.3esr-8.0-1` (commit
 12847934f5c7baf4e94945ec433f1b2fdcf33625).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
-+-
 Reporter:  viktorj  |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #25147   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * status:  needs_information => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
-+-
 Reporter:  viktorj  |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #25147   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * Attachment "0001-Bug-25458-UI-customization-half-broken-in-Tor-
 Browse.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
-+-
 Reporter:  viktorj  |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #25147   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * Attachment "0001-Bug-25458-UI-customization-half-broken-in-Tor-
 Browse.patch" removed.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
-+-
 Reporter:  viktorj  |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #25147   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_information


Comment:

 So, that fix in `grid.js` is not directly related to the customization
 basically broken, right? Or, if it *is* related to that how do I trigger
 that breakage, because it seems I am failing to do so.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
-+-
 Reporter:  viktorj  |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #25147   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * keywords:  tbb-regression, TorBrowserTeam201804 => tbb-regression,
 TorBrowserTeam201804R
 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
-+-
 Reporter:  viktorj  |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201804   |
Parent ID:  #25147   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * Attachment "0001-Bug-25458-UI-customization-half-broken-in-Tor-
 Browse.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
-+-
 Reporter:  viktorj  |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201804   |
Parent ID:  #25147   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
-+-
 Reporter:  viktorj  |  Owner:
 |  pospeselr
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201804   |
Parent ID:  #25147   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by pospeselr):

 * status:  new => assigned
 * owner:  tbb-team => pospeselr


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
-+-
 Reporter:  viktorj  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201803   |
Parent ID:  #25147   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Not sure how related but BTW the entire UI becomes sometimes completely
 unresponsive, and one has to wait quiet a bit before it gets back to
 normal.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
-+-
 Reporter:  viktorj  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201803   |
Parent ID:  #25147   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by franklin):

 * cc: franklin (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
-+-
 Reporter:  viktorj  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201803   |
Parent ID:  #25147   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Yeah, I can reproduce it now with a fresh clean install of Tor Browser
 8.0a4

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
-+-
 Reporter:  viktorj  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:
 Keywords:  tbb-regression,  |  Actual Points:
  TorBrowserTeam201803   |
Parent ID:  #25147   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-regression => tbb-regression, TorBrowserTeam201803


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
--+--
 Reporter:  viktorj   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Major | Resolution:
 Keywords:  tbb-regression|  Actual Points:
Parent ID:  #25147| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 Reproducible on Windows:
 {{{
 16:54:02.700 CustomizeMode:Error entering customize mode TypeError:
 messageNode.querySelector(...) is null
 Stack trace:
 
CustomizeMode.prototype.maybeShowTip@resource:///modules/CustomizeMode.jsm:701:7
 CustomizeMode.prototype.enter/<@resource:///modules/CustomizeMode.jsm:358:7
 TaskImpl_run@resource://gre/modules/Task.jsm:319:42
 Handler.prototype.process@resource://gre/modules/Promise.jsm ->
 resource://gre/modules/Promise-backend.js:932:23
 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm ->
 resource://gre/modules/Promise-backend.js:813:7
 this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm
 -> resource://gre/modules/Promise-backend.js:747:11
  1 CustomizeMode.jsm:374
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
--+--
 Reporter:  viktorj   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Major | Resolution:
 Keywords:  tbb-regression|  Actual Points:
Parent ID:  #25147| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 Strange, I can't reproduce the issue myself (linux 64 bit as well)...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
--+--
 Reporter:  viktorj   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Major | Resolution:
 Keywords:  tbb-regression|  Actual Points:
Parent ID:  #25147| Points:
 Reviewer:|Sponsor:
--+--
Changes (by cypherpunks):

 * priority:  Medium => High
 * keywords:   => tbb-regression
 * severity:  Normal => Major
 * parent:   => #25147


Comment:

 You shipped it, ignoring tor-qa, so hrm...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25458 [Applications/Tor Browser]: UI customization half-broken in Tor Browser 8.0a3

[Tor Bug Tracker & Wiki]

#25458: UI customization half-broken in Tor Browser 8.0a3
--+--
 Reporter:  viktorj   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 seen with Tor Browser 8.0a3-build1 on Linux (64 bit)

 Changing the UI via the menu entry "Customize" does not work anymore
 because the customization view closes immediately after opening, so drag-
 and-drop is impossible. Right-clicking on a menu entry and selecting "Move
 to Toolbar" still works, as well as "Move to Menu" for something which was
 moved to the toolbar.

 Maybe #25147 is the reason.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs