Re: [tor-bugs] #25493 [Core Tor/Tor]: Improve patterns for cleaning up static variables on exit/restart

[Tor Bug Tracker & Wiki]

#25493: Improve patterns for cleaning up static variables on exit/restart
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-triage-20180328, 034-roadmap-|  Actual Points:
  subtask, 034-included-20180405, 035-roadmap-   |
  subtask, 035-triaged-in-20180711,  |
  040-deferred-201915|
Parent ID:  #25510   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-

Comment (by nickm):

 I believe that this is in progress, via our "subsystems" design.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25493 [Core Tor/Tor]: Improve patterns for cleaning up static variables on exit/restart

[Tor Bug Tracker & Wiki]

#25493: Improve patterns for cleaning up static variables on exit/restart
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-triage-20180328, 034-roadmap-|  implemented
  subtask, 034-included-20180405, 035-roadmap-   |  Actual Points:
  subtask, 035-triaged-in-20180711,  |
  040-deferred-201915|
Parent ID:  #25510   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => implemented


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25493 [Core Tor/Tor]: Improve patterns for cleaning up static variables on exit/restart

[Tor Bug Tracker & Wiki]

#25493: Improve patterns for cleaning up static variables on exit/restart
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-triage-20180328, 034-roadmap-|  Actual Points:
  subtask, 034-included-20180405, 035-roadmap-   |
  subtask, 035-triaged-in-20180711   |
Parent ID:  #25510   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * sponsor:   => Sponsor31-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25493 [Core Tor/Tor]: Improve patterns for cleaning up static variables on exit/restart

[Tor Bug Tracker & Wiki]

#25493: Improve patterns for cleaning up static variables on exit/restart
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-triage-20180328, 034-roadmap-|  Actual Points:
  subtask, 034-included-20180405, 035-roadmap-   |
  subtask, 035-triaged-in-20180711   |
Parent ID:  #25510   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * sponsor:  Sponsor8 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25493 [Core Tor/Tor]: Improve patterns for cleaning up static variables on exit/restart

[Tor Bug Tracker & Wiki]

#25493: Improve patterns for cleaning up static variables on exit/restart
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.6.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-triage-20180328, 034-roadmap-|  Actual Points:
  subtask, 034-included-20180405, 035-roadmap-   |
  subtask, 035-triaged-in-20180711   |
Parent ID:  #25510   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by dgoulet):

 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.6.x-final


Comment:

 Related to our mobile API work. We are pass the 035 freeze, sending to
 036.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25493 [Core Tor/Tor]: Improve patterns for cleaning up static variables on exit/restart

[Tor Bug Tracker & Wiki]

#25493: Improve patterns for cleaning up static variables on exit/restart
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-triage-20180328, 034-roadmap-|  Actual Points:
  subtask 034-included-20180405 035-roadmap- |
  subtask|
Parent ID:  #25510   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * keywords:  034-triage-20180328, 034-roadmap-subtask 034-included-20180405
 =>
 034-triage-20180328, 034-roadmap-subtask 034-included-20180405 035
 -roadmap-subtask


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25493 [Core Tor/Tor]: Improve patterns for cleaning up static variables on exit/restart

[Tor Bug Tracker & Wiki]

#25493: Improve patterns for cleaning up static variables on exit/restart
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-triage-20180328, 034-roadmap-|  Actual Points:
  subtask 034-included-20180405  |
Parent ID:  #25510   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * keywords:  034-triage-20180328, 034-removed-20180328 =>
 034-triage-20180328, 034-roadmap-subtask 034-included-20180405
 * parent:   => #25510


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25493 [Core Tor/Tor]: Improve patterns for cleaning up static variables on exit/restart

[Tor Bug Tracker & Wiki]

#25493: Improve patterns for cleaning up static variables on exit/restart
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:  Sponsor8  |
--+
 In his review for #23524, asn says:
 >I feel like resetting all the global statics on `tor_free_all()` makes
 sense but it's all a very brittle logic. The moment someone adds a new
 global static in that file and doesn't know about this convention of
 wiping at `tor_free_all()`, it will introduce a bug IIUC. Furthermore, the
 fact that some of those vars get reset to 0 and others to 1 is kinda
 arbitrary (and you need to look at their definitions to see if it's
 correct).
 >
 >I wonder what we could do about `3809036` to make it better. Perhaps we
 should de-global those variables, put them in a struct, and initialize
 them in a function, then call that function from some entry-point and
 `tor_free_all()`? That seems like a better approach but probably not so
 trivial. Maybe subject for a future ticket on this area?

 We should indeed look for better patterns to solve this issue, since the
 current approach is indeed fragile.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs