Re: [tor-bugs] #25619 [Applications/Tor Browser]: The webrtc build downloads and runs a cipd program

[Tor Bug Tracker & Wiki]

#25619: The webrtc build downloads and runs a cipd program
--+--
 Reporter:  dcf   |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  invalid
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by dcf):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Replying to [comment:1 gk]:
 > I don't have this message in my log file dating from last Friday.

 Aha, thanks for checking.

 I think I just realized the cause: I found I needed a more recent
 depot_tools in order to build a more recent webrtc. It must be a new
 behavior with a newer depot_tools. In other words, it's my problem, not
 yours :) I'll see if I can find a way to disable this behavior in my
 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25619 [Applications/Tor Browser]: The webrtc build downloads and runs a cipd program

[Tor Bug Tracker & Wiki]

#25619: The webrtc build downloads and runs a cipd program
--+--
 Reporter:  dcf   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Replying to [ticket:25619 dcf]:
 > I haven't looked very deeply into this. I'm also experimenting with some
 changes to the webrtc build, but none that should affect this. As a first
 check, does anyone else have the `Bootstrapping cipd client` message in
 logs/webrtc-linux-x86_64.log?

 I don't have this message in my log file dating from last Friday.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25619 [Applications/Tor Browser]: The webrtc build downloads and runs a cipd program

[Tor Bug Tracker & Wiki]

#25619: The webrtc build downloads and runs a cipd program
--+--
 Reporter:  dcf   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 While doing a build of Tor Browser, I noticed this in logs/webrtc-linux-
 x86_64.log:
 {{{
 Starting build: Sat Mar 24 00:04:29 2018
 Bootstrapping cipd client for linux-amd64 from https://chrome-infra-
 packages.appspot.com/client?platform=linux-
 amd64=git_revision:ae28364c740acff97ae118adcb2808b6cb5129c5...
 [0:02:35] Still working on:
 [0:02:35]   src/third_party/icu
 }}}

 `Bootstrapping cipd client` comes from
 
[https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/e346e411d56a33575a9818310e73a66f17de3da0/cipd#67
 the cipd program] in depot_tools. I suppose it is being run somehow
 through `gclient sync`. It downloads a program and then runs it with a
 `selfupdate` argument. "cipd" seems to refer to "Chrome infra packages
 (?)".

 I'm not sure what cipd is doing, but if it's downloading software at build
 time, it could potentially break reproducibility. We are already setting
 `DEPOT_TOOLS_UPDATE=0`.

 I saw the message in logs/webrtc-linux-i686.log and logs/webrtc-linux-
 x86_64.log. I did not see it in logs/webrtc-osx-x86_64.log.

 I haven't looked very deeply into this. I'm also experimenting with some
 changes to the webrtc build, but none that should affect this. As a first
 check, does anyone else have the `Bootstrapping cipd client` message in
 logs/webrtc-linux-x86_64.log?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs