Re: [tor-bugs] #25727 [Core Tor/Tor]: Add bool types to Rust coding standards guidelines

[Tor Bug Tracker & Wiki]

#25727: Add bool types to Rust coding standards guidelines
-+-
 Reporter:  isis |  Owner:
 |  catalyst
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  wontfix
 Keywords:  torspec, rust, fast-fix, 035 |  Actual Points:
  -triaged-in-20180711   |
Parent ID:   | Points:  .1
 Reviewer:  catalyst |Sponsor:
 |  SponsorM-can
-+-
Changes (by catalyst):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 Unfortunately, it seems like [https://github.com/rust-
 lang/rfcs/issues/992#issuecomment-427660590 Rust RFC 992 was closed]
 without taking the final step of explicitly documenting the ABI
 equivalence of Rust's `bool` and C's `_Bool`. Further comments from a Rust
 core team member imply that this is unlikely to be resolved any time soon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25727 [Core Tor/Tor]: Add bool types to Rust coding standards guidelines

[Tor Bug Tracker & Wiki]

#25727: Add bool types to Rust coding standards guidelines
-+-
 Reporter:  isis |  Owner:
 |  catalyst
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, rust, fast-fix, 035 |  Actual Points:
  -triaged-in-20180711   |
Parent ID:   | Points:  .1
 Reviewer:  catalyst |Sponsor:
 |  SponsorM-can
-+-
Changes (by catalyst):

 * owner:  isis => catalyst
 * status:  needs_revision => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25727 [Core Tor/Tor]: Add bool types to Rust coding standards guidelines

[Tor Bug Tracker & Wiki]

#25727: Add bool types to Rust coding standards guidelines
-+-
 Reporter:  isis |  Owner:  isis
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, rust, fast-fix, 035 |  Actual Points:
  -triaged-in-20180711   |
Parent ID:   | Points:  .1
 Reviewer:  catalyst |Sponsor:
 |  SponsorM-can
-+-

Comment (by catalyst):

 I left a comment on the RFC [https://github.com/rust-
 lang/rfcs/issues/992#issuecomment-389297983 here] back in May but haven't
 received a reply yet.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25727 [Core Tor/Tor]: Add bool types to Rust coding standards guidelines

[Tor Bug Tracker & Wiki]

#25727: Add bool types to Rust coding standards guidelines
-+
 Reporter:  isis |  Owner:  isis
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, rust, fast-fix  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:  catalyst |Sponsor:  SponsorM-can
-+

Comment (by isis):

 I've left a comment on Rust RFC 992 [https://github.com/rust-
 lang/rfcs/issues/992#issuecomment-383667884 here].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25727 [Core Tor/Tor]: Add bool types to Rust coding standards guidelines

[Tor Bug Tracker & Wiki]

#25727: Add bool types to Rust coding standards guidelines
-+
 Reporter:  isis |  Owner:  isis
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, rust, fast-fix  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:  catalyst |Sponsor:  SponsorM-can
-+
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Summarizing yesterday's IRC discussion:
 * Rust has debated whether Rust's `bool` is identical to C99's `_Bool` for
 a while.
 * Rust now [https://github.com/rust-lang/rust/pull/46156 specifies] that
 its `bool` is one byte.
 * There is a [https://github.com/rust-lang/rfcs/pull/954 postponed RFC] to
 define Rust's `bool` and C99's `_Bool` to be FFI-compatible.
 We should either postpone merging this until Rust decides to accept RFC
 954 or point to that RFC (and maybe the follow up RFC 992) in our doc.
 There seems to be a consensus that it should be accepted but it seems they
 haven't gone through the formalities yet.

 This patch also adds a non-ASCII character in a file that previously had
 none.  I think we lack a style guide that covers the acceptability of non-
 ASCII in various files, but this is a change.  On the other hand
 CodingStandardsRust.md already had some non-ASCII characters in it so
 maybe we don't actually care that much?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25727 [Core Tor/Tor]: Add bool types to Rust coding standards guidelines

[Tor Bug Tracker & Wiki]

#25727: Add bool types to Rust coding standards guidelines
-+
 Reporter:  isis |  Owner:  isis
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, rust, fast-fix  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:  catalyst |Sponsor:  SponsorM-can
-+
Changes (by dgoulet):

 * reviewer:   => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25727 [Core Tor/Tor]: Add bool types to Rust coding standards guidelines

[Tor Bug Tracker & Wiki]

#25727: Add bool types to Rust coding standards guidelines
-+
 Reporter:  isis |  Owner:  isis
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  torspec, rust, fast-fix  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:  SponsorM-can
-+
Changes (by isis):

 * status:  assigned => needs_review


Comment:

 Done in my `bug25727`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug25727 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25727 [Core Tor/Tor]: Add bool types to Rust coding standards guidelines

[Tor Bug Tracker & Wiki]

#25727: Add bool types to Rust coding standards guidelines
--+-
 Reporter:  isis  |  Owner:  isis
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  torspec, rust, fast-fix
Actual Points:|  Parent ID:
   Points:  .1|   Reviewer:
  Sponsor:  SponsorM-can  |
--+-
 Similar to #25368, we can once again expand upon which Rust types are safe
 to send over the FFI boundary without
 conversion/serialisation/translation, because Rust's `bool` type and C99's
 `bool` type are directly compatible. (I think this also makes an even
 larger argument moving forward for using `bool`s in C wherever it makes
 sense, since otherwise we need to convert between the libc `uint8_t` type
 and the native `u8` in Rust.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs