Re: [tor-bugs] #25832 [Applications/Tor Browser]: Enable pthread support for mingw-w64

[Tor Bug Tracker & Wiki]

#25832: Enable pthread support for mingw-w64
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  GeorgKoppen201804, TorBrowserTeam201806R   |
Parent ID:  #24631   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 I pushed this patch to master as commit
 `9af1ea49a225b3a8582be29172cc3f25ef5c215b`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25832 [Applications/Tor Browser]: Enable pthread support for mingw-w64

[Tor Bug Tracker & Wiki]

#25832: Enable pthread support for mingw-w64
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  GeorgKoppen201804, TorBrowserTeam201805R   |
Parent ID:  #24631   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 This patch looks good to me. I rebased it on master in my branch
 `bug_25832_v2`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25832_v2=9af1ea49a225b3a8582be29172cc3f25ef5c215b

 And I am now trying a build of #25894.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25832 [Applications/Tor Browser]: Enable pthread support for mingw-w64

[Tor Bug Tracker & Wiki]

#25832: Enable pthread support for mingw-w64
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  GeorgKoppen201804, TorBrowserTeam201805R   |
Parent ID:  #24631   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:8 boklm]:
 > So it looks like something we want to merge at the same time as
 switching to ESR60.

 Yes, that's what I said in comment:3. It seems I've been a bit too
 optimistic in comment:5, though. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25832 [Applications/Tor Browser]: Enable pthread support for mingw-w64

[Tor Bug Tracker & Wiki]

#25832: Enable pthread support for mingw-w64
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  GeorgKoppen201804, TorBrowserTeam201805R   |
Parent ID:  #24631   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 After building using this patch, and firefox 52.8, I have the following
 error:
 {{{
 /var/tmp/dist/mingw-w64/helpers/i686-w64-mingw32-g++ -std=gnu++11
 -mwindows -o Unified_cpp_media_libstagefright1.o -c -I/var/tmp/build
 /firefox-f8f42fea2af3/obj-mingw/dis
 t/stl_wrappers  -DNDEBUG=1 -DTRIMMED=1 -DANDROID_SMP=0 -DLOG_NDEBUG=1
 -DHAVE_MS_C_RUNTIME -D__PRETTY_FUNCTION__=__FUNCTION__ -DFAKE_LOG_DEVICE
 -DSTATIC_EXPORTABLE_JS_API
  -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/var/tmp/build
 /firefox-f8f42fea2af3/media/libstagefright -I/var/tmp/build/firefox-
 f8f42fea2af3/obj-mingw/media/
 libstagefright -I/var/tmp/build/firefox-
 f8f42fea2af3/media/libstagefright/ports/win32/include -I/var/tmp/build
 /firefox-f8f42fea2af3/media/libstagefright/binding/include
 -I/var/tmp/build/firefox-
 f8f42fea2af3/media/libstagefright/frameworks/av/include -I/var/tmp/build
 /firefox-f8f42fea2af3/media/libstagefright/frameworks/av/include/media/s
 tagefright/foundation -I/var/tmp/build/firefox-
 f8f42fea2af3/media/libstagefright/frameworks/av/media/libstagefright
 -I/var/tmp/build/firefox-f8f42fea2af3/media/libstagef
 right/stubs/empty -I/var/tmp/build/firefox-
 f8f42fea2af3/media/libstagefright/stubs/include -I/var/tmp/build/firefox-
 f8f42fea2af3/media/libstagefright/stubs/include/media
 /stagefright/foundation -I/var/tmp/build/firefox-
 f8f42fea2af3/media/libstagefright/system/core/include -I/var/tmp/build
 /firefox-f8f42fea2af3/obj-mingw/dist/include  -I/v
 ar/tmp/build/firefox-f8f42fea2af3/obj-mingw/dist/include/nspr
 -I/var/tmp/build/firefox-f8f42fea2af3/obj-mingw/dist/include/nss
 -DMOZILLA_CLIENT -include /var/tmp
 /build/firefox-f8f42fea2af3/obj-mingw/mozilla-config.h -MD -MP -MF
 .deps/Unified_cpp_media_libstagefright1.o.pp  -Wall -Wc++11-compat
 -Wempty-body -Wignored-qualifiers -
 Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits
 -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat
 -Wno-error=maybe-uninitialized -
 Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-format
 -fno-lifetime-dse -fno-exceptions -fno-strict-aliasing -mms-bitfields
 -mstackrealign -fno-keep-inli
 ne-dllexport -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g
 -O -fno-omit-frame-pointer  -Wno-format -Wno-format-security -Wno-
 multichar -Wno-sign-compare -
 Wno-unused  /var/tmp/build/firefox-f8f42fea2af3/obj-
 mingw/media/libstagefright/Unified_cpp_media_libstagefright1.cpp
 In file included from
 
/var/tmp/dist/mingw-w64/i686-w64-mingw32/include/c++/6.4.0/i686-w64-mingw32/bits/gthr.h:148:0,
  from
 /var/tmp/dist/mingw-w64/i686-w64-mingw32/include/c++/6.4.0/ext/atomicity.h:35,
  from
 /var/tmp/dist/mingw-w64/i686-w64-mingw32/include/c++/6.4.0/bits/ios_base.h:39,
  from
 /var/tmp/dist/mingw-w64/i686-w64-mingw32/include/c++/6.4.0/ios:42,
  from /var/tmp/build/firefox-f8f42fea2af3/obj-
 mingw/dist/stl_wrappers/ios:44,
  from
 /var/tmp/dist/mingw-w64/i686-w64-mingw32/include/c++/6.4.0/ostream:38,
  from /var/tmp/build/firefox-f8f42fea2af3/obj-
 mingw/dist/stl_wrappers/ostream:44,
  from /var/tmp/build/firefox-f8f42fea2af3/obj-
 mingw/dist/include/mozilla/gfx/BasePoint.h:10,
  from /var/tmp/build/firefox-f8f42fea2af3/obj-
 mingw/dist/include/mozilla/gfx/Point.h:13,
  from /var/tmp/build/firefox-f8f42fea2af3/obj-
 mingw/dist/include/nsSize.h:11,
  from /var/tmp/build/firefox-f8f42fea2af3/obj-
 mingw/dist/include/MediaData.h:11,
  from /var/tmp/build/firefox-
 f8f42fea2af3/media/libstagefright/binding/Adts.cpp:6,
  from /var/tmp/build/firefox-f8f42fea2af3/obj-
 mingw/media/libstagefright/Unified_cpp_media_libstagefright0.cpp:2:
 
/var/tmp/dist/mingw-w64/i686-w64-mingw32/include/c++/6.4.0/i686-w64-mingw32/bits
 /gthr-default.h:47:9: error: 'pthread_t' does not name a type
  typedef pthread_t __gthread_t;
  ^
 

Re: [tor-bugs] #25832 [Applications/Tor Browser]: Enable pthread support for mingw-w64

[Tor Bug Tracker & Wiki]

#25832: Enable pthread support for mingw-w64
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201804R, GeorgKoppen201804   |
Parent ID:  #24631   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by tom):

 Been talking to a cypherpunk a bit lately; they tipped me off to file
 https://bugzilla.mozilla.org/show_bug.cgi?id=1456575

 I don't know if mingw-clang needs either of these things though

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25832 [Applications/Tor Browser]: Enable pthread support for mingw-w64

[Tor Bug Tracker & Wiki]

#25832: Enable pthread support for mingw-w64
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201804R, GeorgKoppen201804   |
Parent ID:  #24631   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:4 boklm]:
 > Replying to [comment:3 gk]:
 > >
 > > This should be reviewed once we switched to an ESR60-based tor-browser
 branch.
 >
 > Is this something we could merge before switching to ESR60, or would
 this cause some issues with the ESR52 build?

 I doubt it would cause issues. I think I just don't want to have this in
 the next alpha (to avoid surprises) assuming this is the last one
 ESR52-based. Once it is out next week. I am fine merging this patch even
 though we might not directly switch to ESR60 then.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25832 [Applications/Tor Browser]: Enable pthread support for mingw-w64

[Tor Bug Tracker & Wiki]

#25832: Enable pthread support for mingw-w64
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201804R, GeorgKoppen201804   |
Parent ID:  #24631   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:3 gk]:
 >
 > This should be reviewed once we switched to an ESR60-based tor-browser
 branch.

 Is this something we could merge before switching to ESR60, or would this
 cause some issues with the ESR52 build?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25832 [Applications/Tor Browser]: Enable pthread support for mingw-w64

[Tor Bug Tracker & Wiki]

#25832: Enable pthread support for mingw-w64
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201804R, GeorgKoppen201804   |
Parent ID:  #24631   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, ff60-esr, TorBrowserTeam201804, GeorgKoppen201804 =>
 tbb-rbm, ff60-esr, TorBrowserTeam201804R, GeorgKoppen201804
 * status:  new => needs_review


Comment:

 Replying to [comment:1 gk]:
 > I believe this bug is behind my build failure on my Linux boxes:
 > {{{
 > 1:34.88 In file included from /home/thomas/win60/tor-
 browser/media/libvpx/libvpx/vp8/decoder/onyxd_int.h:18:0,
 >  1:34.88  from /home/thomas/win60/tor-
 browser/media/libvpx/libvpx/vp8/decoder/decodeframe.c:14:
 >  1:34.90 /home/thomas/win60/tor-
 browser/media/libvpx/libvpx/vp8/common/threading.h:76:23: fatal error:
 semaphore.h: Datei oder Verzeichnis nicht gefunden
 >  1:34.91  #include 
 >  1:34.91
 > }}}
 > I am currently verifying that theory and am testing a potential fix.

 Yes, I was right. `bug_25832` (https://gitweb.torproject.org/user/gk/tor-
 browser-
 build.git/commit/?h=bug_25832=9ed4019319aec225d8b2bd163d0be5adea5d4573)
 has a potential fix that allows me to basically compile everything. (The
 Firefox is still not running for different reasons on Windows 7 and 8,
 which is interesting but different tickets).

 This should be reviewed once we switched to an ESR60-based tor-browser
 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25832 [Applications/Tor Browser]: Enable pthread support for mingw-w64

[Tor Bug Tracker & Wiki]

#25832: Enable pthread support for mingw-w64
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201804, GeorgKoppen201804|
Parent ID:  #24631   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  ff60-esr, TorBrowserTeam201804, GeorgKoppen201804 => tbb-rbm,
 ff60-esr, TorBrowserTeam201804, GeorgKoppen201804


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25832 [Applications/Tor Browser]: Enable pthread support for mingw-w64

[Tor Bug Tracker & Wiki]

#25832: Enable pthread support for mingw-w64
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201804,  |  Actual Points:
  GeorgKoppen201804  |
Parent ID:  #24631   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  ff60-esr => ff60-esr, TorBrowserTeam201804, GeorgKoppen201804


Comment:

 I believe this bug is behind my build failure on my Linux boxes:
 {{{
 1:34.88 In file included from /home/thomas/win60/tor-
 browser/media/libvpx/libvpx/vp8/decoder/onyxd_int.h:18:0,
  1:34.88  from /home/thomas/win60/tor-
 browser/media/libvpx/libvpx/vp8/decoder/decodeframe.c:14:
  1:34.90 /home/thomas/win60/tor-
 browser/media/libvpx/libvpx/vp8/common/threading.h:76:23: fatal error:
 semaphore.h: Datei oder Verzeichnis nicht gefunden
  1:34.91  #include 
  1:34.91
 }}}
 I am currently verifying that theory and am testing a potential fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25832 [Applications/Tor Browser]: Enable pthread support for mingw-w64

[Tor Bug Tracker & Wiki]

#25832: Enable pthread support for mingw-w64
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  ff60-esr
Actual Points:|  Parent ID:  #24631
   Points:|   Reviewer:
  Sponsor:|
--+--
 https://bugzilla.mozilla.org/show_bug.cgi?id=1406542 starts to use pthread
 support for mingw-w64. We need to adapt our mingw-w64 build script for
 that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs