Re: [tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201806R  |
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:9 boklm]:
 > Branch `bug_25837_v3` has the some commit rebased on master:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25837_v3=1689bd25bb1edc62c25cb11846bc0dd5b9a8e30c

 Looks good. I merged sukhe's commit and your fixups to master with commit
 `57693e01837f0fc7c60bb056e5b752f5f67a987b`. We are done here, I think.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201806R  |
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Branch `bug_25837_v3` has the some commit rebased on master:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25837_v3=1689bd25bb1edc62c25cb11846bc0dd5b9a8e30c

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201806R  |
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, ff60-esr, TorBrowserTeam201806 => tbb-rbm, ff60-esr,
 TorBrowserTeam201806R


Comment:

 Replying to [comment:7 boklm]:
 > I am now testing a build with the following changes compared to the
 patch from branch `azadi/bug-26203`:

 The build finished correctly. I have now squashed the changes listed in
 comment 7 in a commit in branch `bug_25837_v2`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25837_v2=fdfd5600c985d1aff96a6e822c8138fb4a5dbe95

 I also checked that the `d3dcompiler_47.dll` included in commit
 `079f5c7b9f6ea0b7e5504bb53abf8709cc92835d` from
 `https://github.com/azadi/fxc2.git` are the same that I get after
 downloading the win32 and win64 versions of firefox 60.0.2esr.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201806   |
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 I am now testing a build with the following changes compared to the patch
 from branch `azadi/bug-26203`:
 * remove the line `pre_pkginst: dpkg --add-architecture i386` as it builds
 fine without it. https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26203=e172a942f2abf3553f14f2de7be20840f5f77334
 * don't use xvfb as it seems it is not really needed.
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26203=ecea9b7944aa0ea22faf72776e0050c6d9ca1bad
 * copy d3dcompiler_47.dll (this change was part of commit `Bug 26206: Ship
 pthread related dll (libwinpthread-1.dll) where needed` before)
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26203=74da109534fe4c5470a7653ddcba83398c1ac7f4
 * Simplify a little the copy of the libwinpthread-1.dll file.
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25837=b0f30a7078c145916e0e89b255dd2262fc757730
 * Remove the `&` after `wine wineboot -i` as I am not sure it is needed.
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25837=9d4ab9c0a171be5c38d9f440bb855d92c9b0faa2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201806   |
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 IIUC, Firefox autogenerates `ps_4_0_level_9_3` which is old
 [https://msdn.microsoft.com/en-us/library/bb509626(v=vs.85).aspx SM2]. So
 what's wrong with https://github.com/wine-
 mirror/wine/tree/master/dlls/d3dcompiler_47?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201805   |
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sukhbir):

 * status:  new => needs_review


Comment:

 #26204 has a branch that integrates `fxc2` and also `d3dcompiler_47.dll`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201805   |
Parent ID:  #26203   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, ff60-esr => tbb-rbm, ff60-esr, TorBrowserTeam201805
 * cc: sukhe (added)
 * parent:  #24631 => #26203
 * priority:  Medium => Very High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, ff60-esr |  Actual Points:
Parent ID:  #24631| Points:
 Reviewer:|Sponsor:
--+--
Changes (by tom):

 * cc: tom (added)


Comment:

 An unfortunate aspect of this is it still uses a closed-source MSFT dll.
 For trustworthiness purposes, you'll probably want to agree upon the hash
 of that dll. You can consider the existing one in the repo my vote for the
 correct version.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
--+---
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-rbm, ff60-esr
Actual Points:|  Parent ID:  #24631
   Points:|   Reviewer:
  Sponsor:|
--+---
 Starting with https://bugzilla.mozilla.org/show_bug.cgi?id=1365859 Mozilla
 is using a closed-source tool, called fxc, during the build to autocreate
 D3D11 shaders during the build.

 We don't want to do that. So, tjr set down and wrote a tool, called fxc2
 (https://github.com/tomrittervg/fxc2), that we can compile and then use
 during the build via wine(!) to do the autogeneration for us. See:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1370007 for details.

 We need to integrate that setup into our Windows build process for Tor
 Browser 8.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs