Re: [tor-bugs] #25927 [Core Tor/Tor]: Remove the need for gettimeofday_cached(); use monotonic time in ewma code

[Tor Bug Tracker & Wiki]

#25927: Remove the need for gettimeofday_cached(); use monotonic time in ewma 
code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  implemented
  034-triage-20180328, 034-included-20180328 |  Actual Points:
Parent ID:  #25375   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25927 [Core Tor/Tor]: Remove the need for gettimeofday_cached(); use monotonic time in ewma code

[Tor Bug Tracker & Wiki]

#25927: Remove the need for gettimeofday_cached(); use monotonic time in ewma 
code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-

Comment (by nickm):

 Commented on the randomness; merging to master. Will keep an eye on CI in
 case it breaks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25927 [Core Tor/Tor]: Remove the need for gettimeofday_cached(); use monotonic time in ewma code

[Tor Bug Tracker & Wiki]

#25927: Remove the need for gettimeofday_cached(); use monotonic time in ewma 
code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 Looks good to me. Only one comment about the added random value of the
 tick number which is the only difference I could see on the EWMA side for
 which I believe it is a good addition!

 However, I can't test the compat functions for the `diff_msec()` so I
 would rely on travis and Jenkins to pick up any issues on other platforms
 if we do test them in the CI.

 Test passes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25927 [Core Tor/Tor]: Remove the need for gettimeofday_cached(); use monotonic time in ewma code

[Tor Bug Tracker & Wiki]

#25927: Remove the need for gettimeofday_cached(); use monotonic time in ewma 
code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-
Changes (by dgoulet):

 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25927 [Core Tor/Tor]: Remove the need for gettimeofday_cached(); use monotonic time in ewma code

[Tor Bug Tracker & Wiki]

#25927: Remove the need for gettimeofday_cached(); use monotonic time in ewma 
code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by nickm):

 https://github.com/torproject/tor/pull/66 is a github PR!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25927 [Core Tor/Tor]: Remove the need for gettimeofday_cached(); use monotonic time in ewma code

[Tor Bug Tracker & Wiki]

#25927: Remove the need for gettimeofday_cached(); use monotonic time in ewma 
code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 See branch `eliminate_gettimeofday_cached` in my public repository and on
 github.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25927 [Core Tor/Tor]: Remove the need for gettimeofday_cached(); use monotonic time in ewma code (was: Refactor approx_time(); remove the need for gettimeofday_cached().)

[Tor Bug Tracker & Wiki]

#25927: Remove the need for gettimeofday_cached(); use monotonic time in ewma 
code
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Description changed by nickm:

Old description:

> approx_time() should be done the way we currently do
> gettimeofday_cached().  gettimeofday_cached() should be removed entirely.
>
> This will improve our performance a little, and improve our code a lot.

New description:

 approx_time() should be done the way we currently do
 gettimeofday_cached().  gettimeofday_cached() should be removed entirely.

 This will improve our performance a little, and improve our code a lot.

 ''edited: this ticket is now only about gettimeofday_cached();
 approx_time() will take a different ticket.''

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs