Re: [tor-bugs] #25937 [Core Tor/Tor]: Move dirvote_act into a periodic callback

[Tor Bug Tracker & Wiki]

#25937: Move dirvote_act into a periodic callback
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  implemented
  034-triage-20180328, 034-included-20180328 |  Actual Points:
Parent ID:  #25375   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Made a new branch "dirvote_act_refactor_v2" based on master, and then
 squashed it as "dirvote_act_refactor_v2_squashed".  Then added an extra
 commit to refactor our timer subtraction logic to use a function we
 already had for the purpose, and merged to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25937 [Core Tor/Tor]: Move dirvote_act into a periodic callback

[Tor Bug Tracker & Wiki]

#25937: Move dirvote_act into a periodic callback
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * status:  needs_revision => merge_ready


Comment:

 I added the issue you mentioned (adding a comment), but I don't plan to
 merge until ''after'' #25610 is in -- I don't want conflicts with that
 one, since conflicts with code-movement commits can be  super annoying.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25937 [Core Tor/Tor]: Move dirvote_act into a periodic callback

[Tor Bug Tracker & Wiki]

#25937: Move dirvote_act into a periodic callback
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 It all looks good but I do have a follow up on one part of it. Feel free
 to merge if addressed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25937 [Core Tor/Tor]: Move dirvote_act into a periodic callback

[Tor Bug Tracker & Wiki]

#25937: Move dirvote_act into a periodic callback
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:  dgoulet  |Sponsor:
 |  Sponsor8
-+-
Changes (by dgoulet):

 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25937 [Core Tor/Tor]: Move dirvote_act into a periodic callback

[Tor Bug Tracker & Wiki]

#25937: Move dirvote_act into a periodic callback
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Okay, I tried to answer your review; please let me know if you believe my
 answers :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25937 [Core Tor/Tor]: Move dirvote_act into a periodic callback

[Tor Bug Tracker & Wiki]

#25937: Move dirvote_act into a periodic callback
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by nickm):

 (In any case, we should not merge this as-is -- it will need to be rebased
 because of the dirvote code movement in #25610)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25937 [Core Tor/Tor]: Move dirvote_act into a periodic callback

[Tor Bug Tracker & Wiki]

#25937: Move dirvote_act into a periodic callback
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Reviewed done.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25937 [Core Tor/Tor]: Move dirvote_act into a periodic callback

[Tor Bug Tracker & Wiki]

#25937: Move dirvote_act into a periodic callback
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 This has been rebased; the name is still `dirvote_act_refactor`.  PR at
 https://github.com/torproject/tor/pull/62

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25937 [Core Tor/Tor]: Move dirvote_act into a periodic callback

[Tor Bug Tracker & Wiki]

#25937: Move dirvote_act into a periodic callback
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  034-triage-20180328, 034-included-20180328 |
Parent ID:  #25375   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by nickm):

 I've started this as `dirvote_act_refactor`, but I'm going to rebase and
 finish it once #25376 is merged, to avoid conflicts.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25937 [Core Tor/Tor]: Move dirvote_act into a periodic callback

[Tor Bug Tracker & Wiki]

#25937: Move dirvote_act into a periodic callback
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  034-roadmap-subtask,
 Severity:  Normal   |  034-triage-20180328, 034-included-20180328
Actual Points:   |  Parent ID:  #25375
   Points:   |   Reviewer:
  Sponsor:   |
  Sponsor8   |
-+-
 Instead of calling dirvote_act once per second, we can just ask it when to
 call it next.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs