Re: [tor-bugs] #25973 [Applications/Tor Browser]: Backport off-by-one fix in 1352073

[Tor Bug Tracker & Wiki]

#25973: Backport off-by-one fix in 1352073
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  GeorgKoppen201804,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:7 gk]:
 > Replying to [comment:6 cypherpunks]:
 > > Don't you feel something is wrong with backporting only now what was
 fixed in Firefox 54?
 >
 > Not necessarily as a backport depends on a number of factors. In this
 particular case, though, yes, we could have tried harder to get the
 necessary info earlier to ship this defense-in-depth earlier to Tor
 Browser users.
 It is a good practice to analyze every release of upstream for possible
 backports as linux distros do. That would be the case for android version
 anyway.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25973 [Applications/Tor Browser]: Backport off-by-one fix in 1352073

[Tor Bug Tracker & Wiki]

#25973: Backport off-by-one fix in 1352073
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  GeorgKoppen201804,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:6 cypherpunks]:
 > Don't you feel something is wrong with backporting only now what was
 fixed in Firefox 54?

 Not necessarily as a backport depends on a number of factors. In this
 particular case, though, yes, we could have tried harder to get the
 necessary info earlier to ship this defense-in-depth earlier to Tor
 Browser users.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25973 [Applications/Tor Browser]: Backport off-by-one fix in 1352073

[Tor Bug Tracker & Wiki]

#25973: Backport off-by-one fix in 1352073
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  GeorgKoppen201804,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Don't you feel something is wrong with backporting only now what was fixed
 in Firefox 54?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25973 [Applications/Tor Browser]: Backport off-by-one fix in 1352073

[Tor Bug Tracker & Wiki]

#25973: Backport off-by-one fix in 1352073
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  GeorgKoppen201804,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  GeorgKoppen201804, TorBrowserTeam201804R, tbb-backported =>
 GeorgKoppen201804, TorBrowserTeam201804R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25973 [Applications/Tor Browser]: Backport off-by-one fix in 1352073

[Tor Bug Tracker & Wiki]

#25973: Backport off-by-one fix in 1352073
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  GeorgKoppen201804,   |  Actual Points:
  TorBrowserTeam201804R, tbb-backported  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  GeorgKoppen201804, TorBrowserTeam201804R => GeorgKoppen201804,
 TorBrowserTeam201804R, tbb-backported


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25973 [Applications/Tor Browser]: Backport off-by-one fix in 1352073

[Tor Bug Tracker & Wiki]

#25973: Backport off-by-one fix in 1352073
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  GeorgKoppen201804,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks. Cherry-picked onto `tor-browser-52.7.3esr-7.5-1`
 (6d4dc3e0fc543ac39393ab474409406ad9552b96) and `tor-
 browser-52.7.3esr-8.0-1` (833b057519dcd6c62ac3f16cff93b17311c6a4c4).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25973 [Applications/Tor Browser]: Backport off-by-one fix in 1352073

[Tor Bug Tracker & Wiki]

#25973: Backport off-by-one fix in 1352073
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  GeorgKoppen201804,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 r=brade, r=mcs

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25973 [Applications/Tor Browser]: Backport off-by-one fix in 1352073

[Tor Bug Tracker & Wiki]

#25973: Backport off-by-one fix in 1352073
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  GeorgKoppen201804,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => needs_review
 * keywords:  GeorgKoppen201804, TorBrowserTeam201804 => GeorgKoppen201804,
 TorBrowserTeam201804R


Comment:

 See `bug_25973` (https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_25973=67a38d1ab3375e9d094160f966559296c6e25f7d)
 in my public repo for the backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25973 [Applications/Tor Browser]: Backport off-by-one fix in 1352073

[Tor Bug Tracker & Wiki]

#25973: Backport off-by-one fix in 1352073
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  GeorgKoppen201804,
 Severity:  Normal   |  TorBrowserTeam201804
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 As a defense in depth we should backport the off-by-one error fix in
 https://bugzilla.mozilla.org/show_bug.cgi?id=1352073.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs