Re: [tor-bugs] #25975 [Applications/Tor Browser]: Get a rust cross-compiler for macOS

[Tor Bug Tracker & Wiki]

#25975: Get a rust cross-compiler for macOS
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201805R, GeorgKoppen201805R, |
  boklm201805|
Parent ID:  #25779   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:6 boklm]:
 > I didn't try to build it, but the patch looks good to me.
 >
 > One minor thing: the line `cat > $distdir/helper/x86_64-apple-darwin-
 clang << 'EOF'` and the comment before can be indented.

 I fixed that and pushed the result to `master` as commit
 e7f9f6f11e45d1ba15fbbb183ef1ae8b0c3b20c5, thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25975 [Applications/Tor Browser]: Get a rust cross-compiler for macOS

[Tor Bug Tracker & Wiki]

#25975: Get a rust cross-compiler for macOS
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201805R, GeorgKoppen201805R, |
  boklm201805|
Parent ID:  #25779   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 I didn't try to build it, but the patch looks good to me.

 One minor thing: the line `cat > $distdir/helper/x86_64-apple-darwin-clang
 << 'EOF'` and the comment before can be indented.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25975 [Applications/Tor Browser]: Get a rust cross-compiler for macOS

[Tor Bug Tracker & Wiki]

#25975: Get a rust cross-compiler for macOS
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201805R, GeorgKoppen201805R, |
  boklm201805|
Parent ID:  #25779   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:
 tbb-rbm, ff60-esr, TorBrowserTeam201805R, GeorgKoppen201805,
 boklm201805
 =>
 tbb-rbm, ff60-esr, TorBrowserTeam201805R, GeorgKoppen201805R,
 boklm201805
 * status:  needs_revision => needs_review
 * cc: boklm (added)


Comment:

 Actually, we are good. The reason for this problem is that we are setting
 MACOSX__DEPLOYMENT_TARGET=10.6 which fits to the current toolchain we use.
 `thread_local` is not supported for 10.6 but it is for 10.7 onward. Thus,
 we are good for now and will be later on when switching to our new
 toolchain. I just tested that and could successfully build esr60.

 I've rebased my patch on `master` and pushed an update to bug_25975_v2
 (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_25975_v2=040cc0560eb21cf09dbdbbd33d501b805a28d6bd).

 boklm could you review that one?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25975 [Applications/Tor Browser]: Get a rust cross-compiler for macOS

[Tor Bug Tracker & Wiki]

#25975: Get a rust cross-compiler for macOS
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201805R, GeorgKoppen201805,  |
  boklm201805|
Parent ID:  #25779   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 `__FastLocalKeyInner` seems to be missing in our `libstd` .rlib, hm, yet I
 can see
 {{{
 thread :: __FastLocalKeyInner < $ t > = $ crate :: thread ::
 __FastLocalKeyInner :: new (  ) ; # [ cfg ( not ( target_thread_local ) )
 ]
 static __KEY : $ crate :: thread :: __OsLocalKeyInner < $ t > = $ crate ::
 thread :: __OsLocalKeyInner :: new (  ) ; __KEY . get (  ) } unsafe {
 }}}
 as in the lib downloaded via `rustup`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25975 [Applications/Tor Browser]: Get a rust cross-compiler for macOS

[Tor Bug Tracker & Wiki]

#25975: Get a rust cross-compiler for macOS
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr,   |  Actual Points:
  TorBrowserTeam201805R, GeorgKoppen201805,  |
  boklm201805|
Parent ID:  #25779   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:
 tbb-rbm, ff60-esr, TorBrowserTeam201805R, GeorgKoppen201804,
 boklm201805
 =>
 tbb-rbm, ff60-esr, TorBrowserTeam201805R, GeorgKoppen201805,
 boklm201805


Comment:

 Okay, this likely needs a revision as using a so-created Rust cross-
 compiler leads to:
 {{{
  8:36.74 error[E0433]: failed to resolve. Could not find
 `__FastLocalKeyInner` in `thread`
  8:36.74   --> third_party/rust/futures/src/task_impl/std/mod.rs:28:1
  8:36.74|
  8:36.74 28 | thread_local!(static CURRENT_TASK: Cell<*mut u8> =
 Cell::new(ptr::null_mut()));
  8:36.74|
 ^^^
 Could not find `__FastLocalKeyInner` in `thread`
  8:36.74|
  8:36.74= note: this error originates in a macro outside of the
 current crate (in Nightly builds, run with -Z external-macro-backtrace for
 more info)
  8:36.74
  8:36.75 error[E0433]: failed to resolve. Could not find
 `__FastLocalKeyInner` in `thread`
  8:36.75--> third_party/rust/futures/src/task_impl/std/mod.rs:494:1
  8:36.75 |
  8:36.75 494 | / thread_local! {
  8:36.75 495 | | static CURRENT_THREAD_NOTIFY: Arc =
 Arc::new(ThreadNotify {
  8:36.75 496 | | state: AtomicUsize::new(IDLE),
  8:36.75 497 | | mutex: Mutex::new(()),
  8:36.75 498 | | condvar: Condvar::new(),
  8:36.75 499 | | });
  8:36.75 500 | | }
  8:36.75 | |_^ Could not find `__FastLocalKeyInner` in `thread`
  8:36.75 |
  8:36.75 = note: this error originates in a macro outside of the
 current crate (in Nightly builds, run with -Z external-macro-backtrace for
 more info)
  8:36.75

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25975 [Applications/Tor Browser]: Get a rust cross-compiler for macOS

[Tor Bug Tracker & Wiki]

#25975: Get a rust cross-compiler for macOS
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr, boklm201804,  |  Actual Points:
  TorBrowserTeam201805R, GeorgKoppen201804   |
Parent ID:  #25779   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * priority:  Medium => High
 * keywords:
 tbb-rbm, ff60-esr, boklm201804, TorBrowserTeam201804,
 GeorgKoppen201804
 =>
 tbb-rbm, ff60-esr, boklm201804, TorBrowserTeam201805R,
 GeorgKoppen201804
 * status:  new => needs_review


Comment:

 `bug_25975` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_25975=56ee89b4b4b9ee8643cdb404018701ad200a9200)
 has a patch up for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25975 [Applications/Tor Browser]: Get a rust cross-compiler for macOS

[Tor Bug Tracker & Wiki]

#25975: Get a rust cross-compiler for macOS
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-rbm, ff60-esr,
 Severity:  Normal   |  boklm201804, TorBrowserTeam201804,
 |  GeorgKoppen201804
Actual Points:   |  Parent ID:  #25779
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We want to build our own rust compiler for building the Firefox and tor
 rust parts.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs