Re: [tor-bugs] #25990 [Core Tor/Tor]: module: Better safeguard authdir_mode_v3() if dirauth module is disabled

[Tor Bug Tracker & Wiki]

#25990: module: Better safeguard authdir_mode_v3() if dirauth module is disabled
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  implemented
  modularization, tor-dirauth, refactor  |  Actual Points:
Parent ID:  #25494   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merging!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25990 [Core Tor/Tor]: module: Better safeguard authdir_mode_v3() if dirauth module is disabled

[Tor Bug Tracker & Wiki]

#25990: module: Better safeguard authdir_mode_v3() if dirauth module is disabled
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  modularization, tor-dirauth, refactor  |
Parent ID:  #25494   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 ahf is having Internet issues but told me "ack" on this one. Going in
 `merge_ready`. He'll double confirm when he is back online but in the
 meantime, we are good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25990 [Core Tor/Tor]: module: Better safeguard authdir_mode_v3() if dirauth module is disabled

[Tor Bug Tracker & Wiki]

#25990: module: Better safeguard authdir_mode_v3() if dirauth module is disabled
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-roadmap-subtask, |  Actual Points:
  modularization, tor-dirauth, refactor  |
Parent ID:  #25494   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  assigned => needs_review
 * reviewer:   => ahf


Comment:

 Even though `mode.h` in the branch is very small, I still think it is a
 good way to separate things. Ultimately, we'll have _no_ code outside the
 dirauth module that will include that mode.h.

 Notice also that it is only for *Directory Authority*, bridge authority
 use the `AuthoritativeDir` option so `authdir_mode()` can't be isolated.

 Branch: `ticket25990_034_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25990 [Core Tor/Tor]: module: Better safeguard authdir_mode_v3() if dirauth module is disabled

[Tor Bug Tracker & Wiki]

#25990: module: Better safeguard authdir_mode_v3() if dirauth module is disabled
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  034-roadmap-subtask,
 Severity:  Normal   |  modularization, tor-dirauth, refactor
Actual Points:   |  Parent ID:  #25494
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We need to safeguard somehow the `authdir_mode_v3()` so it can NEVER
 return true if the dirauth module is disabled.

 One option here is to move this function to the dirauth module and NOP it
 by returning false if the module is not enabled.

 An other option is to #ifdef `HAVE_MODULE_DIRAUTH` in the function
 directly. I'm kind of less enthusiastic about it but maybe it is better,
 dunno yet.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs