Re: [tor-bugs] #25995 [Core Tor/Tor]: Use a deterministic PRNG in test_circuit_timeout() for predictable coverage.

[Tor Bug Tracker & Wiki]

#25995: Use a deterministic PRNG in test_circuit_timeout() for predictable
coverage.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:  mikeperry|Sponsor:
 |  Sponsor3-can
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Ok, merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25995 [Core Tor/Tor]: Use a deterministic PRNG in test_circuit_timeout() for predictable coverage.

[Tor Bug Tracker & Wiki]

#25995: Use a deterministic PRNG in test_circuit_timeout() for predictable
coverage.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:  mikeperry|Sponsor:
 |  Sponsor3-can
-+-
Changes (by mikeperry):

 * status:  needs_review => merge_ready


Comment:

 This looks legit. Thanks for this!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25995 [Core Tor/Tor]: Use a deterministic PRNG in test_circuit_timeout() for predictable coverage.

[Tor Bug Tracker & Wiki]

#25995: Use a deterministic PRNG in test_circuit_timeout() for predictable
coverage.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:  mikeperry|Sponsor:
 |  Sponsor3-can
-+-
Changes (by nickm):

 * sponsor:   => Sponsor3-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25995 [Core Tor/Tor]: Use a deterministic PRNG in test_circuit_timeout() for predictable coverage.

[Tor Bug Tracker & Wiki]

#25995: Use a deterministic PRNG in test_circuit_timeout() for predictable
coverage.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:  mikeperry|Sponsor:
-+-
Changes (by mikeperry):

 * reviewer:   => mikeperry


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25995 [Core Tor/Tor]: Use a deterministic PRNG in test_circuit_timeout() for predictable coverage.

[Tor Bug Tracker & Wiki]

#25995: Use a deterministic PRNG in test_circuit_timeout() for predictable
coverage.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * cc: mikeperry (added)
 * status:  assigned => needs_review


Comment:

 branch is `ticket25955`; PR is https://github.com/torproject/tor/pull/74

 Adding mikeperry to cc as the test's author, who may hate what I am
 proposing to do with this. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25995 [Core Tor/Tor]: Use a deterministic PRNG in test_circuit_timeout() for predictable coverage.

[Tor Bug Tracker & Wiki]

#25995: Use a deterministic PRNG in test_circuit_timeout() for predictable
coverage.
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  tor-ci, tor-tests-coverage, tor-
 Severity:  Normal   |  tests-unit
Actual Points:   |  Parent ID:  #25908
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 The test coverage from test_circuit_timeout() is nondeterministic, because
 the function deliberately creates random samples and passes them to the
 circuitstats module.

 I propose that for this function, we replace the RNG with a mocked
 replacement.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs