Re: [tor-bugs] #25997 [Core Tor/Tor]: Solve nondeterminism in testing of hs_get_responsible_hsdirs

[Tor Bug Tracker & Wiki]

#25997: Solve nondeterminism in testing of hs_get_responsible_hsdirs
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor3-can
-+-
Changes (by nickm):

 * sponsor:   => Sponsor3-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25997 [Core Tor/Tor]: Solve nondeterminism in testing of hs_get_responsible_hsdirs

[Tor Bug Tracker & Wiki]

#25997: Solve nondeterminism in testing of hs_get_responsible_hsdirs
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 thanks for the fast review -- merged to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25997 [Core Tor/Tor]: Solve nondeterminism in testing of hs_get_responsible_hsdirs

[Tor Bug Tracker & Wiki]

#25997: Solve nondeterminism in testing of hs_get_responsible_hsdirs
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25997 [Core Tor/Tor]: Solve nondeterminism in testing of hs_get_responsible_hsdirs

[Tor Bug Tracker & Wiki]

#25997: Solve nondeterminism in testing of hs_get_responsible_hsdirs
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25997 [Core Tor/Tor]: Solve nondeterminism in testing of hs_get_responsible_hsdirs

[Tor Bug Tracker & Wiki]

#25997: Solve nondeterminism in testing of hs_get_responsible_hsdirs
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 That was easy; see branch `ticket25997`. PR at
 https://github.com/torproject/tor/pull/79

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25997 [Core Tor/Tor]: Solve nondeterminism in testing of hs_get_responsible_hsdirs

[Tor Bug Tracker & Wiki]

#25997: Solve nondeterminism in testing of hs_get_responsible_hsdirs
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  tor-ci, tor-tests-coverage, tor-
 Severity:  Normal   |  tests-unit
Actual Points:   |  Parent ID:  #25908
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Only sometimes do our tests call the case of hs_get_responsible_hsdirs
 where it "wraps around":
 {{{
 /* Getting the length of the list if no member is greater than the key
 we
  * are looking for so start at the first element. */
 if (idx == smartlist_len(sorted_nodes)) {
   start = idx = 0;
 }
 }}}

 We should make this consistent.

 I plan to do this, but dgoulet or asn should steal it if they'd rather. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs