Re: [tor-bugs] #26162 [Metrics/CollecTor]: Replace Gson with Jackson in CollecTor

[Tor Bug Tracker & Wiki]

#26162: Replace Gson with Jackson in CollecTor
---+-
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  closed
 Priority:  High   |  Milestone:  CollecTor 1.6.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * milestone:   => CollecTor 1.6.0


Comment:

 This is released as part of CollecTor 1.6.0. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26162 [Metrics/CollecTor]: Replace Gson with Jackson in CollecTor

[Tor Bug Tracker & Wiki]

#26162: Replace Gson with Jackson in CollecTor
---+-
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  merge_ready
 Priority:  High   |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 Cool! All fine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26162 [Metrics/CollecTor]: Replace Gson with Jackson in CollecTor

[Tor Bug Tracker & Wiki]

#26162: Replace Gson with Jackson in CollecTor
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by karsten):

 Yep. I pushed [https://gitweb.torproject.org/karsten/metrics-
 db.git/commit/?h=task-26162=7e2f7c3c17575a20ecd12e144083620a755d3ec2
 squash commit 7e2f7c3 to my task-21612 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26162 [Metrics/CollecTor]: Replace Gson with Jackson in CollecTor

[Tor Bug Tracker & Wiki]

#26162: Replace Gson with Jackson in CollecTor
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by iwakeh):

 The fix looks fine.
 To prevent future changes that might undo this unusual (in metrics
 products at least) behavior could you add a tiny test to
 [https://gitweb.torproject.org/karsten/metrics-
 
db.git/tree/src/test/java/org/torproject/collector/relaydescs/ReferenceCheckerTest.java?h=task-26162
 ReferenceCheckerTest]?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26162 [Metrics/CollecTor]: Replace Gson with Jackson in CollecTor

[Tor Bug Tracker & Wiki]

#26162: Replace Gson with Jackson in CollecTor
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by karsten):

 * status:  merge_ready => needs_review


Comment:

 I just pushed [https://gitweb.torproject.org/karsten/metrics-
 db.git/commit/?h=task-26162=01f63293314a9f0aca9aa4698bd8e7fe65519b43
 fixup commit 01f6329 to my task-21612 branch] that fixes an issue in the
 reference checker: while it's usually a good idea to skip fields with null
 or empty values, say, in Onionoo, the reference checker cannot handle that
 and needs to serialize and de-serialize empty strings. Before this fixup
 commit it would have de-serialized empty strings as `null` values, and
 that would have broken comparisons. Please review!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26162 [Metrics/CollecTor]: Replace Gson with Jackson in CollecTor

[Tor Bug Tracker & Wiki]

#26162: Replace Gson with Jackson in CollecTor
---+-
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  merge_ready
 Priority:  High   |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by karsten):

 * status:  needs_review => merge_ready


Comment:

 Heh, alright, those changes are indeed really small. Merged to my branch.
 If you don't mind, I'll squash that commit into mine for the release, for
 a clearer Git history. Setting to merge_ready and preparing a pre-release
 tarball later today. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26162 [Metrics/CollecTor]: Replace Gson with Jackson in CollecTor

[Tor Bug Tracker & Wiki]

#26162: Replace Gson with Jackson in CollecTor
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by iwakeh):

 * status:  needs_revision => needs_review


Comment:

 Please see
 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-26162
 this commit] removing jackson dependencies from index-module.

 Reference checker is ok.  All checks pass.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26162 [Metrics/CollecTor]: Replace Gson with Jackson in CollecTor

[Tor Bug Tracker & Wiki]

#26162: Replace Gson with Jackson in CollecTor
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  needs_revision
 Priority:  High   |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by karsten):

 Let's only do this if the changes are really small. It would be really bad
 to spend too much time on CollecTor so that we won't have enough time left
 for the other releases.

 Do you want to write a patch that does what you suggest, and I continue
 preparing and testing the other patches? And if it turns out to be harder
 than expected, we save this additional step for later?

 (By the way, CollecTor also uses a JSON formatter/parser for the reference
 checker in its relay descriptors module. That means, even if we use
 metrics-lib classes for `index.json` formatting ''and'' parsing, we'll
 still have unrelated JSON code in CollecTor.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26162 [Metrics/CollecTor]: Replace Gson with Jackson in CollecTor

[Tor Bug Tracker & Wiki]

#26162: Replace Gson with Jackson in CollecTor
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  needs_revision
 Priority:  High   |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by iwakeh):

 * status:  needs_review => needs_revision


Comment:

 CollecTor already uses all o.tp.descriptor.index classes.  Why duplicate
 the writing functionality?  Maybe, this should be implemented by using
 only o.tp.descriptor.index classes in CollecTor?  Future json processing
 lib changes would not affect CollecTor anymore (except for simply
 including the dependency).

 Setting to needs_revision for discussion.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26162 [Metrics/CollecTor]: Replace Gson with Jackson in CollecTor

[Tor Bug Tracker & Wiki]

#26162: Replace Gson with Jackson in CollecTor
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by karsten):

 * status:  assigned => needs_review


Comment:

 Please review [https://gitweb.torproject.org/karsten/metrics-
 db.git/commit/?h=task-26162=0b1ebc8dde839f8bf2f3ba59cd6b68b4e25dc463
 ​commit 0b1ebc8 in my task-26162 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26162 [Metrics/CollecTor]: Replace Gson with Jackson in CollecTor

[Tor Bug Tracker & Wiki]

#26162: Replace Gson with Jackson in CollecTor
---+--
 Reporter:  karsten|  Owner:  karsten
 Type:  enhancement| Status:  assigned
 Priority:  High   |  Milestone:
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+--
 Related to Onionoo ticket #25848 and metrics-lib ticket #26159, we should
 replace Gson with Jackson in CollecTor. For reasons, see those tickets.
 I'll work on this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs