Re: [tor-bugs] #26455 [Core Tor/Tor]: use correct CARGO_HOME in test_rust.sh

[Tor Bug Tracker & Wiki]

#26455: use correct CARGO_HOME in test_rust.sh
--+
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  rust, tor-ci, tor-test, fast-fix  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:  isis  |Sponsor:  SponsorM-
  |  can
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to 0.3.3 and forward. Resolved a simple conflict in
 75d9db9e5b6d70002.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26455 [Core Tor/Tor]: use correct CARGO_HOME in test_rust.sh

[Tor Bug Tracker & Wiki]

#26455: use correct CARGO_HOME in test_rust.sh
--+
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  rust, tor-ci, tor-test, fast-fix  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:  isis  |Sponsor:  SponsorM-
  |  can
--+
Changes (by cypherpunks):

 * status:  merge_ready => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26455 [Core Tor/Tor]: use correct CARGO_HOME in test_rust.sh

[Tor Bug Tracker & Wiki]

#26455: use correct CARGO_HOME in test_rust.sh
--+
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:
  |  merge_ready
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-ci, tor-test, fast-fix  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:  isis  |Sponsor:  SponsorM-
  |  can
--+
Changes (by isis):

 * status:  needs_review => merge_ready
 * points:   => 1
 * sponsor:   => SponsorM-can


Comment:

 LGTM! I've always wondered why we were setting it to /src/rust and how
 that was even working, but I guess it wasn't!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26455 [Core Tor/Tor]: use correct CARGO_HOME in test_rust.sh

[Tor Bug Tracker & Wiki]

#26455: use correct CARGO_HOME in test_rust.sh
--+
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:
  |  needs_review
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-ci, tor-test, fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  isis  |Sponsor:
--+

Comment (by catalyst):

 Replying to [comment:5 chelseakomlo]:
 > It is good to keep like commits together, so if the complexity of
 backporting is too much to do in this patch, please make sure this is
 fixed in a future ticket and the ticket number noted here so we can track
 it.
 This is a good idea.  New ticket for the broader issue is #26497.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26455 [Core Tor/Tor]: use correct CARGO_HOME in test_rust.sh

[Tor Bug Tracker & Wiki]

#26455: use correct CARGO_HOME in test_rust.sh
--+
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:
  |  needs_review
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-ci, tor-test, fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  isis  |Sponsor:
--+

Comment (by chelseakomlo):

 Replying to [comment:3 catalyst]:
 > Replying to [comment:2 chelseakomlo]:
 > > Good catch. We also set CARGO_HOME in `Makefile.in` so this should
 likely be updated as well?
 > Maybe not in a backported patch? I think the `cargo build` invocations
 happen to work by accident right now because they `cd` into the directory
 that contains the (autoconf-generated) `.cargo` directory in the build
 tree.
 >
 > I think it's probably better to clean up the other build instances of
 this problem on a separate ticket, because it's fortuitously working right
 now.

 It is good to keep like commits together, so if the complexity of
 backporting is too much to do in this patch, please make sure this is
 fixed in a future ticket and the ticket number noted here so we can track
 it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26455 [Core Tor/Tor]: use correct CARGO_HOME in test_rust.sh

[Tor Bug Tracker & Wiki]

#26455: use correct CARGO_HOME in test_rust.sh
--+
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:
  |  needs_review
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-ci, tor-test, fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  isis  |Sponsor:
--+
Changes (by asn):

 * reviewer:   => isis


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26455 [Core Tor/Tor]: use correct CARGO_HOME in test_rust.sh

[Tor Bug Tracker & Wiki]

#26455: use correct CARGO_HOME in test_rust.sh
--+
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:
  |  needs_review
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-ci, tor-test, fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by catalyst):

 Replying to [comment:2 chelseakomlo]:
 > Good catch. We also set CARGO_HOME in `Makefile.in` so this should
 likely be updated as well?
 Maybe not in a backported patch? I think the `cargo build` invocations
 happen to work by accident right now because they `cd` into the directory
 that contains the (autoconf-generated) `.cargo` directory in the build
 tree.

 I think it's probably better to clean up the other build instances of this
 problem on a separate ticket, because it's fortuitously working right now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26455 [Core Tor/Tor]: use correct CARGO_HOME in test_rust.sh

[Tor Bug Tracker & Wiki]

#26455: use correct CARGO_HOME in test_rust.sh
--+
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:
  |  needs_review
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-ci, tor-test, fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by chelseakomlo):

 Good catch. We also set CARGO_HOME in `Makefile.in` so this should likely
 be updated as well?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26455 [Core Tor/Tor]: use correct CARGO_HOME in test_rust.sh

[Tor Bug Tracker & Wiki]

#26455: use correct CARGO_HOME in test_rust.sh
--+
 Reporter:  catalyst  |  Owner:  catalyst
 Type:  defect| Status:
  |  needs_review
 Priority:  Medium|  Milestone:  Tor:
  |  0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, tor-ci, tor-test, fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by catalyst):

 * status:  assigned => needs_review


Comment:

 Patch in https://github.com/torproject/tor/pull/170

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26455 [Core Tor/Tor]: use correct CARGO_HOME in test_rust.sh

[Tor Bug Tracker & Wiki]

#26455: use correct CARGO_HOME in test_rust.sh
+--
 Reporter:  catalyst|  Owner:  catalyst
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core|Version:
  Tor/Tor   |
 Severity:  Normal  |   Keywords:  rust, tor-ci, tor-test, fast-fix
Actual Points:  |  Parent ID:
   Points:  |   Reviewer:
  Sponsor:  |
+--
 `make check` currently doesn't seem to work with `--enable-rust` without
 `--enable-cargo-online-mode`.

 It looks like cargo expects `CARGO_HOME` to point to the `.cargo`
 directory itself, not the directory containing it.  Builds seem to work
 anyway because we `cd` to a directory where cargo can find a `.cargo`
 directory, even though we set `CARGO_HOME` incorrectly.

 This might be making Jenkins builds fail too:

 https://jenkins.torproject.org/job/tor-ci-linux-master-
 rust/ARCHITECTURE=i386,SUITE=sid/lastBuild/console

 {{{
 20:04:05 FAIL: src/test/test_rust.sh
 20:04:05 ===
 20:04:05
 20:04:05 error: attempting to make an HTTP request, but --frozen was
 specified
 20:04:05 error: attempting to make an HTTP request, but --frozen was
 specified
 }}}

 This incarnation of this bug seems to be in the fix for #26258, but
 similar problems seem to exist in releases as far back as 0.3.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs