Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, fast-fix, 035-triaged-  |  implemented
  in-20180711 029-backport 032-backport  |  Actual Points:
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 squashed and merged to 0.2.9 and forward!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, fast-fix, 035-triaged-  |  Actual Points:
  in-20180711 029-backport 032-backport  |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:24 nickm]:
 > Okay, revised, and added tests.  Better now?
 Looks good; thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, fast-fix, 035-triaged-  |  Actual Points:
  in-20180711 029-backport 032-backport  |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Okay, revised, and added tests.  Better now?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, fast-fix, 035-triaged-  |  Actual Points:
  in-20180711 029-backport 032-backport  |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 You're correct on both counts -- I'll revise.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, fast-fix, 035-triaged-  |  Actual Points:
  in-20180711 029-backport 032-backport  |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by catalyst):

 Thanks! I've left an inline comment on github about a minor comment
 accuracy thing, and asked about tests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, fast-fix, 035-triaged-  |  Actual Points:
  in-20180711 029-backport 032-backport  |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:   => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-dirauth, fast-fix, 035-triaged-  |  Actual Points:
  in-20180711 029-backport 032-backport  |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-dirauth, fast-fix, 035-triaged-in-20180711 =>
 tor-dirauth, fast-fix, 035-triaged-in-20180711 029-backport
 032-backport 033-backport 034-backport
 * status:  accepted => needs_review


Comment:

 I've done a minimal version of this in `bug26485_029`, PR at
 https://github.com/torproject/tor/pull/228

 All this does is:
   * warn the voters if any authority has voted for a version with a space
 in it
   * warn the authority operator if they configure an invalid-looking
 version list
   * when generating a vote, to split any versions that seem to have spaces
 in them

 I considered other changes as well, but I want to avoid changes that would
 affect the output of the consensus algorithm -- especially in a branch
 we're thinking of backporting to 0.2.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
--+
 Reporter:  arma  |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-dirauth fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:  tor-dirauth => tor-dirauth fast-fix


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
--+
 Reporter:  arma  |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-dirauth   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:  (none) => nickm
 * reviewer:  nickm =>
 * status:  needs_review => accepted


Comment:

 This actually didn't belong in needs_review -- the branch I made above is
 diagnostic, but not actually a fix.  I'll take on the fix, though, unless
 somebody else would like to do it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-dirauth   |  Actual Points:
Parent ID:| Points:
 Reviewer:  nickm |Sponsor:
--+
Changes (by dgoulet):

 * milestone:   => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
--+--
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-dirauth   |  Actual Points:
Parent ID:| Points:
 Reviewer:  nickm |Sponsor:
--+--
Changes (by dgoulet):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26485 [Core Tor/Tor]: June mystery: the microdesc consensus is getting 9 sigs, but the ns consensus is getting only 5

[Tor Bug Tracker & Wiki]

#26485: June mystery: the microdesc consensus is getting 9 sigs, but the ns
consensus is getting only 5
--+--
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-dirauth   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by dgoulet):

 * keywords:   => tor-dirauth
 * status:  new => needs_review
 * component:  Core Tor/DirAuth => Core Tor/Tor


Comment:

 This seems to affect "tor" and has a branch from nickm so going in Core
 Tor/Tor component.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs