Re: [tor-bugs] #26510 [Core Tor/Tor]: Make "bloomfilter set" code first-class

2018-09-14 Thread Tor Bug Tracker & Wiki
#26510: Make "bloomfilter set" code first-class
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:  refactoring   |  Actual Points:
Parent ID:  #21814| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * parent:   => #21814


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26510 [Core Tor/Tor]: Make "bloomfilter set" code first-class

2018-06-26 Thread Tor Bug Tracker & Wiki
#26510: Make "bloomfilter set" code first-class
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:  refactoring   |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26510 [Core Tor/Tor]: Make "bloomfilter set" code first-class

2018-06-26 Thread Tor Bug Tracker & Wiki
#26510: Make "bloomfilter set" code first-class
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  refactoring   |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * keywords:   => refactoring
 * reviewer:   => dgoulet
 * status:  assigned => merge_ready


Comment:

 ACK. If Travis is happy, I am.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26510 [Core Tor/Tor]: Make "bloomfilter set" code first-class

2018-06-26 Thread Tor Bug Tracker & Wiki
#26510: Make "bloomfilter set" code first-class
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 I've done this in `ticket26510`, with a PR at
 https://github.com/torproject/tor/pull/183 .  This ticket can become
 needs_review once the CI passes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26510 [Core Tor/Tor]: Make "bloomfilter set" code first-class

2018-06-26 Thread Tor Bug Tracker & Wiki
#26510: Make "bloomfilter set" code first-class
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Our bloom filter duplicated between address_set.c and digestset.c, and
 it's slightly different in both cases.  We should extract a common
 implementation type, use siphash, and name it bloomfilt_set or approx_set
 or somethign.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs