Re: [tor-bugs] #26892 [Core Tor/Tor]: log_addr_has_changed() does not heed SafeLogging

[Tor Bug Tracker & Wiki]

#26892: log_addr_has_changed() does not heed SafeLogging
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:  tor-log   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 LGTM too; merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26892 [Core Tor/Tor]: log_addr_has_changed() does not heed SafeLogging

[Tor Bug Tracker & Wiki]

#26892: log_addr_has_changed() does not heed SafeLogging
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-log   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Looks fine to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26892 [Core Tor/Tor]: log_addr_has_changed() does not heed SafeLogging

[Tor Bug Tracker & Wiki]

#26892: log_addr_has_changed() does not heed SafeLogging
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-log   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by rl1987):

 * status:  needs_revision => needs_review


Comment:

 https://github.com/torproject/tor/pull/249

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26892 [Core Tor/Tor]: log_addr_has_changed() does not heed SafeLogging

[Tor Bug Tracker & Wiki]

#26892: log_addr_has_changed() does not heed SafeLogging
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-log   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 log_addr_has_changed() is only called in server_mode():
 * router_new_address_suggestion() returns early if !server_mode()
 * router_new_address_suggestion() returns early if
 !router_get_my_routerinfo()

 Relay addresses are public, so there isn't any point scrubbing them from
 logs.

 Bridge addresses are not public, but the diagnostic value of the logs
 probably outweighs the occasional risk that operators copy unscrubbed
 addresses into tickets.

 I would take a patch to log_addr_has_changed() that exits early on clients
 as a precaution:
 {{{
   if (!server_mode(options)) {
 return;
   }
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26892 [Core Tor/Tor]: log_addr_has_changed() does not heed SafeLogging

[Tor Bug Tracker & Wiki]

#26892: log_addr_has_changed() does not heed SafeLogging
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-log   |  Actual Points:
Parent ID:| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by asn):

 * reviewer:  mikeperry => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26892 [Core Tor/Tor]: log_addr_has_changed() does not heed SafeLogging

[Tor Bug Tracker & Wiki]

#26892: log_addr_has_changed() does not heed SafeLogging
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-log   |  Actual Points:
Parent ID:| Points:
 Reviewer:  mikeperry |Sponsor:
--+
Changes (by asn):

 * reviewer:   => mikeperry


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26892 [Core Tor/Tor]: log_addr_has_changed() does not heed SafeLogging

[Tor Bug Tracker & Wiki]

#26892: log_addr_has_changed() does not heed SafeLogging
--+
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-log   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * milestone:  Tor: unspecified => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26892 [Core Tor/Tor]: log_addr_has_changed() does not heed SafeLogging

[Tor Bug Tracker & Wiki]

#26892: log_addr_has_changed() does not heed SafeLogging
--+--
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-log   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by dmr):

 * cc: dmr (added)
 * keywords:   => tor-log


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26892 [Core Tor/Tor]: log_addr_has_changed() does not heed SafeLogging

[Tor Bug Tracker & Wiki]

#26892: log_addr_has_changed() does not heed SafeLogging
--+--
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by rl1987):

 * status:  new => needs_review


Comment:

 https://github.com/torproject/tor/pull/247

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26892 [Core Tor/Tor]: log_addr_has_changed() does not heed SafeLogging

[Tor Bug Tracker & Wiki]

#26892: log_addr_has_changed() does not heed SafeLogging
--+--
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by nickm):

 I'd be glad to take a patch for this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26892 [Core Tor/Tor]: log_addr_has_changed() does not heed SafeLogging

[Tor Bug Tracker & Wiki]

#26892: log_addr_has_changed() does not heed SafeLogging
--+--
 Reporter:  rl1987|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 No IP address scrubbing is performed at any loglevel:

 {{{
 2694   if (!tor_addr_is_null(prev))
 2695 log_fn(severity, LD_GENERAL,
 2696"Our IP Address has changed from %s to %s; "
 2697"rebuilding descriptor (source: %s).",
 2698addrbuf_prev, addrbuf_cur, source);
 2699   else
 2700 log_notice(LD_GENERAL,
 2701  "Guessed our IP address as %s (source: %s).",
 2702  addrbuf_cur, source);
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs