Re: [tor-bugs] #26925 [Core Tor/Tor]: Make link specifier handling in rend-spec-v3 more precise

2018-07-30 Thread Tor Bug Tracker & Wiki 
#26925: Make link specifier handling in rend-spec-v3 more precise
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-spec, doc, tor-relay, certs, |  Actual Points:
  handshake, ed25519, 035-roadmap-proposed,  |
  035-must, fast-fix, 035-triaged-in-20180711|
Parent ID:  #26627   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26925 [Core Tor/Tor]: Make link specifier handling in rend-spec-v3 more precise

2018-07-29 Thread Tor Bug Tracker & Wiki 
#26925: Make link specifier handling in rend-spec-v3 more precise
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec, doc, tor-relay, certs, |  Actual Points:
  handshake, ed25519, 035-roadmap-proposed,  |
  035-must, fast-fix, 035-triaged-in-20180711|
Parent ID:  #26627   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by teor):

 Yes, we need to add IPv6 and unrecognized link specifiers to services in
 #24181, and unrecognised link specifiers to clients in #26971.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26925 [Core Tor/Tor]: Make link specifier handling in rend-spec-v3 more precise

2018-07-28 Thread Tor Bug Tracker & Wiki 
#26925: Make link specifier handling in rend-spec-v3 more precise
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec, doc, tor-relay, certs, |  Actual Points:
  handshake, ed25519, 035-roadmap-proposed,  |
  035-must, fast-fix, 035-triaged-in-20180711|
Parent ID:  #26627   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Spec changes LGTM. Are there any code changes that need to be done (i
 think not)?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26925 [Core Tor/Tor]: Make link specifier handling in rend-spec-v3 more precise

2018-07-25 Thread Tor Bug Tracker & Wiki 
#26925: Make link specifier handling in rend-spec-v3 more precise
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec, doc, tor-relay, certs, |  Actual Points:
  handshake, ed25519, 035-roadmap-proposed,  |
  035-must, fast-fix, 035-triaged-in-20180711|
Parent ID:  #26627   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26925 [Core Tor/Tor]: Make link specifier handling in rend-spec-v3 more precise

2018-07-24 Thread Tor Bug Tracker & Wiki 
#26925: Make link specifier handling in rend-spec-v3 more precise
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec, doc, tor-relay, certs, |  Actual Points:
  handshake, ed25519, 035-roadmap-proposed,  |
  035-must, fast-fix, 035-triaged-in-20180711|
Parent ID:  #26627   | Points:
 Reviewer:   |Sponsor:
-+-

Old description:

> Split off #26627.
>
> We should specify that clients and services must not check untrusted link
> specifiers against the consensus:
> https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
> https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
>
> Services should also copy unrecognized rend point link specifiers from
> the introduce cell to the rendezvous join cell.
> We can copy the text from the client intro spec:
> https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
> To the service rend spec:
> https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
>
> Thanks to catalyst for picking up on these missing parts of the spec.
>
> Edit: fix line numbers

New description:

 Split off #26627.

 We should specify that clients and services must not check untrusted link
 specifiers against the consensus:
 https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1338
 https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705

 Services should also copy unrecognized rend point link specifiers from the
 introduce cell to the rendezvous join cell.
 We can copy the text from the service intro->rend spec:
 https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
 To the the client desc->intro spec:
 https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1338

 Thanks to catalyst for picking up on these missing parts of the spec.

 Edit: fix line numbers

--

Comment (by teor):

 Now I have the right line numbers in the description.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26925 [Core Tor/Tor]: Make link specifier handling in rend-spec-v3 more precise

2018-07-24 Thread Tor Bug Tracker & Wiki 
#26925: Make link specifier handling in rend-spec-v3 more precise
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-spec, doc, tor-relay, certs, |  Actual Points:
  handshake, ed25519, 035-roadmap-proposed,  |
  035-must, fast-fix, 035-triaged-in-20180711|
Parent ID:  #26627   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review


Old description:

> Split off #26627.
>
> We should specify that clients and services must not check untrusted link
> specifiers against the consensus:
> https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
> https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
>
> Services should also copy unrecognized rend point link specifiers from
> the introduce cell to the rendezvous join cell.
> We can copy the text from the client intro spec:
> https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
> To the service rend spec:
> https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
>
> Thanks to catalyst for picking up on these missing parts of the spec.

New description:

 Split off #26627.

 We should specify that clients and services must not check untrusted link
 specifiers against the consensus:
 https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
 https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705

 Services should also copy unrecognized rend point link specifiers from the
 introduce cell to the rendezvous join cell.
 We can copy the text from the client intro spec:
 https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
 To the service rend spec:
 https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705

 Thanks to catalyst for picking up on these missing parts of the spec.

 Edit: fix line numbers

--

Comment:

 See my branch bug26925 on https://github.com/teor2345/torspec.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26925 [Core Tor/Tor]: Make link specifier handling in rend-spec-v3 more precise

2018-07-24 Thread Tor Bug Tracker & Wiki 
#26925: Make link specifier handling in rend-spec-v3 more precise
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  tor-spec, doc, tor-relay, certs,
 Severity:  Normal   |  handshake, ed25519, 035-roadmap-proposed,
 |  035-must, fast-fix, 035-triaged-in-20180711
Actual Points:   |  Parent ID:  #26627
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Split off #26627.

 We should specify that clients and services must not check untrusted link
 specifiers against the consensus:
 https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
 https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705

 Services should also copy unrecognized rend point link specifiers from the
 introduce cell to the rendezvous join cell.
 We can copy the text from the client intro spec:
 https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
 To the service rend spec:
 https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705

 Thanks to catalyst for picking up on these missing parts of the spec.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs