Re: [tor-bugs] #26939 [Core Tor/Tor]: Privcount blinding and encryption: type fixes

[Tor Bug Tracker & Wiki]

#26939: Privcount blinding and encryption: type fixes
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:  .2
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  teor |Sponsor:
 |  SponsorV
-+-
Changes (by nickm):

 * actualpoints:   => .2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26939 [Core Tor/Tor]: Privcount blinding and encryption: type fixes

[Tor Bug Tracker & Wiki]

#26939: Privcount blinding and encryption: type fixes
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.6.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  teor |Sponsor:
 |  SponsorV
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 (And merged the first two commits of that branch to kick it off.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26939 [Core Tor/Tor]: Privcount blinding and encryption: type fixes

[Tor Bug Tracker & Wiki]

#26939: Privcount blinding and encryption: type fixes
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.6.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  teor |Sponsor:
 |  SponsorV
-+-

Comment (by nickm):

 Tried to do !

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26939 [Core Tor/Tor]: Privcount blinding and encryption: type fixes

[Tor Bug Tracker & Wiki]

#26939: Privcount blinding and encryption: type fixes
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.6.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  teor |Sponsor:
 |  SponsorV
-+-
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 The first two commits in this branch look fine.

 I opened a pull request to get CI:
 https://github.com/teor2345/privcount_shamir/pull/5

 Can you configure Travis CI on your privcount_shamir?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26939 [Core Tor/Tor]: Privcount blinding and encryption: type fixes

[Tor Bug Tracker & Wiki]

#26939: Privcount blinding and encryption: type fixes
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26939 [Core Tor/Tor]: Privcount blinding and encryption: type fixes

[Tor Bug Tracker & Wiki]

#26939: Privcount blinding and encryption: type fixes
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 I've done this as the first commit of my branch ticket26939_26943_26940;
 PR at https://github.com/nmathewson/privcount_shamir/pull/3 .

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26939 [Core Tor/Tor]: Privcount blinding and encryption: type fixes

[Tor Bug Tracker & Wiki]

#26939: Privcount blinding and encryption: type fixes
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * owner:  teor => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26939 [Core Tor/Tor]: Privcount blinding and encryption: type fixes

[Tor Bug Tracker & Wiki]

#26939: Privcount blinding and encryption: type fixes
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by chelseakomlo):

 Just to further clarify from the comment on #25669- `usize` is Rust's
 equivalent of a `size_t` and therefore iiuc is used to pass around lengths
 or offsets of arrays or other collections. I wasn't sure about all of the
 uses of `usize` here, so taking another look might be useful. For example,
 
https://github.com/nmathewson/privcount_shamir/blob/26812d1ab9912a8f36c0e1472b778d61e696c6e9/rust/tests/basic_integration.rs#L27
 wasn't clear to me if this represents a length or offset, or the
 coordinates for `Params`
 
https://github.com/nmathewson/privcount_shamir/blob/f679aa90ef3ce0d264c50f7e010b2b8022b96c7c/rust/src/shamir.rs#L15

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26939 [Core Tor/Tor]: Privcount blinding and encryption: type fixes

[Tor Bug Tracker & Wiki]

#26939: Privcount blinding and encryption: type fixes
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  privcount, 035-roadmap-master, 035
 Severity:  Normal   |  -triaged-in-20180711, rust
Actual Points:   |  Parent ID:  #25669
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Type fixes from
 https://trac.torproject.org/projects/tor/ticket/25669#comment:15

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs