Re: [tor-bugs] #27044 [Core Tor/Tor]: be more strict in parsing HiddenServicePort

2018-09-06 Thread Tor Bug Tracker & Wiki 
#27044: be more strict in parsing HiddenServicePort
+
 Reporter:  toralf  |  Owner:  (none)
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tor-hs, tor-config  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  dgoulet |Sponsor:
+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 lgtm too. merging.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27044 [Core Tor/Tor]: be more strict in parsing HiddenServicePort

2018-09-05 Thread Tor Bug Tracker & Wiki 
#27044: be more strict in parsing HiddenServicePort
+
 Reporter:  toralf  |  Owner:  (none)
 Type:  defect  | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tor-config  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  dgoulet |Sponsor:
+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 lgtm;

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27044 [Core Tor/Tor]: be more strict in parsing HiddenServicePort

2018-08-28 Thread Tor Bug Tracker & Wiki 
#27044: be more strict in parsing HiddenServicePort
+
 Reporter:  toralf  |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tor-config  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  dgoulet |Sponsor:
+
Changes (by rl1987):

 * cc: rl1987 (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27044 [Core Tor/Tor]: be more strict in parsing HiddenServicePort

2018-08-28 Thread Tor Bug Tracker & Wiki 
#27044: be more strict in parsing HiddenServicePort
+
 Reporter:  toralf  |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tor-config  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  dgoulet |Sponsor:
+
Changes (by rl1987):

 * status:  needs_revision => needs_review


Comment:

 https://github.com/torproject/tor/pull/294

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27044 [Core Tor/Tor]: be more strict in parsing HiddenServicePort

2018-08-20 Thread Tor Bug Tracker & Wiki 
#27044: be more strict in parsing HiddenServicePort
+
 Reporter:  toralf  |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, tor-config  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  dgoulet |Sponsor:
+
Changes (by dgoulet):

 * keywords:   => tor-hs, tor-config
 * reviewer:   => dgoulet
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:2 rl1987]:
 > https://github.com/torproject/tor/pull/274

 The right place to check for this is in
 `rend_service_parse_port_config()`. See `config_generic_service()` which
 error if we can't parse the port line.

 (That function name is confusing, it should really be renamed to something
 generic since v2 and v3 uses it so ignore that part :).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27044 [Core Tor/Tor]: be more strict in parsing HiddenServicePort

2018-08-14 Thread Tor Bug Tracker & Wiki 
#27044: be more strict in parsing HiddenServicePort
--+
 Reporter:  toralf|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * milestone:  Tor: unspecified => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27044 [Core Tor/Tor]: be more strict in parsing HiddenServicePort

2018-08-14 Thread Tor Bug Tracker & Wiki 
#27044: be more strict in parsing HiddenServicePort
--+--
 Reporter:  toralf|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by rl1987):

 * status:  new => needs_review


Comment:

 https://github.com/torproject/tor/pull/274

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27044 [Core Tor/Tor]: be more strict in parsing HiddenServicePort

2018-08-05 Thread Tor Bug Tracker & Wiki 
#27044: be more strict in parsing HiddenServicePort
--+--
 Reporter:  toralf|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by nickm):

 * milestone:   => Tor: unspecified


Comment:

 Seems worth fixing to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27044 [Core Tor/Tor]: be more strict in parsing HiddenServicePort

2018-08-05 Thread Tor Bug Tracker & Wiki 
#27044: be more strict in parsing HiddenServicePort
--+
 Reporter:  toralf|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 A possible typo like
 {{{
 HiddenServicePort 80 127.0.0.1 1234
 }}}
 is accepted.
 IMO Tor should at least warn about a possible missing colon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs