Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  rust, security-low, 034-backport,|  Actual Points:
  033-backport-unreached |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 We may end up merging this fix to 0.3.4, if #27194 is revised and merges
 before 0.3.4 is end of life.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  rust, security-low, 034-backport,|  Actual Points:
  033-backport-unreached |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 We won't be backporting this change to 0.3.4, because we only support Rust
 on the latest stable version:
 {{{
   We have designated 0.3.5 as a "long-term support" (LTS) series: we
   will continue to patch major bugs in typical configurations of 0.3.5
   until at least 1 Feb 2022. (We do not plan to provide long-term
   support for embedding, Rust support, NSS support, running a directory
   authority, or unsupported platforms. For these, you will need to stick
   with the latest stable release.)
 }}}
 https://lists.torproject.org/pipermail/tor-
 announce/2019-January/000170.html

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by cypherpunks3):

 Replying to [comment:13 nickm]:
 > people who want to try Rust builds should IMO stick with recent
 versions.

 The parent ticket #27194 fixes the same bug in C code, as well as adding
 unit tests, and those new tests will fail CI if the rust code isn't also
 fixed.

 In order to merge the C fix to 0.3.3 you either need the Rust fix in 0.3.3
 too or to give up on unit testing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by nickm):

 I'm still going to suggest "no backport" here -- people who want to try
 Rust builds should IMO stick with recent versions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 GitHub had major downtime on some systems, including CI jobs. When they
 started processing jobs again, they dropped some of them:

 > As we re-enabled processing of this data, we processed ~200,000 webhook
 payloads that had outlived an internal TTL and were dropped.

 https://blog.github.com/2018-10-30-oct21-post-incident-analysis/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by cyberpunks):

 Replying to [comment:10 teor]:
 > The 0.3.3 pull request for this branch is:
 > https://github.com/torproject/tor/pull/428

 Was github having an issue with CI? CI ran on
 [https://github.com/torproject/tor/pull/431 PR 431] but not on PRs 427 to
 430.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 The 0.3.3 pull request for this branch is:
 https://github.com/torproject/tor/pull/428

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  reopened => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  closed => reopened
 * resolution:  fixed =>
 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.4.x-final


Comment:

 Okay, we can consider a backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by cyberpunks):

 Replying to [comment:6 nickm]:
 > merged to 0.3.5 and forward.

 But this bug exists in maint-0.3.3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged to 0.3.5 and forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 LGTM.

 Whoever merges this: Rust is not not my biggest strength. Please have a
 look as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 CI is here:
 https://travis-ci.org/teor2345/tor/builds/431333010

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.3-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, security-low, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:  #27194   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cyberpunks):

 See the rust-protocommas1 branch at https://gitgud.io/onionk/tor.git based
 on maint-0.3.3.

 This was introduced in
 
[https://gitweb.torproject.org/tor.git/commit/?id=5af03c1ef3c4718b79abb1638f5a8c275129530a
 "rust protover: match the C implementation on empty-str cases"].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27197 [Core Tor/Tor]: rust protover accepts excess commas in version strings

[Tor Bug Tracker & Wiki]

#27197: rust protover accepts excess commas in version strings
-+-
 Reporter:   |  Owner:  (none)
  cyberpunks |
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:  Tor: 0.3.3.3-alpha
  Tor/Tor|   Keywords:  rust, security-low, 033-backport,
 Severity:  Normal   |  034-backport
Actual Points:   |  Parent ID:  #27194
   Points:   |   Reviewer:
  Sponsor:   |
-+-


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs