Re: [tor-bugs] #27316 [Core Tor/Tor]: protover.c accepts arbitrary bytes in protocol names

[Tor Bug Tracker & Wiki]

#27316: protover.c accepts arbitrary bytes in protocol names
-+-
 Reporter:  cyberpunks   |  Owner:
 |  cyberpunks
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  protover, 029-backport,  |  Actual Points:
  032-backport, 033-backport, 034-backport   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 merged to 0.2.9 and forward!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27316 [Core Tor/Tor]: protover.c accepts arbitrary bytes in protocol names

[Tor Bug Tracker & Wiki]

#27316: protover.c accepts arbitrary bytes in protocol names
-+-
 Reporter:  cyberpunks   |  Owner:
 |  cyberpunks
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  protover, 029-backport,  |  Actual Points:
  032-backport, 033-backport, 034-backport   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 This looks fine to me, and the CI passed at:
 https://github.com/torproject/tor/pull/332

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27316 [Core Tor/Tor]: protover.c accepts arbitrary bytes in protocol names

[Tor Bug Tracker & Wiki]

#27316: protover.c accepts arbitrary bytes in protocol names
-+-
 Reporter:  cyberpunks   |  Owner:
 |  cyberpunks
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  protover, 029-backport,  |  Actual Points:
  032-backport, 033-backport, 034-backport   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27316 [Core Tor/Tor]: protover.c accepts arbitrary bytes in protocol names

[Tor Bug Tracker & Wiki]

#27316: protover.c accepts arbitrary bytes in protocol names
-+-
 Reporter:  cyberpunks   |  Owner:
 |  cyberpunks
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  protover, 029-backport,  |  Actual Points:
  032-backport, 033-backport, 034-backport   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by cyberpunks):

 Oops. Rebased, was only supposed to have one commit there.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27316 [Core Tor/Tor]: protover.c accepts arbitrary bytes in protocol names

[Tor Bug Tracker & Wiki]

#27316: protover.c accepts arbitrary bytes in protocol names
-+-
 Reporter:  cyberpunks   |  Owner:
 |  cyberpunks
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  protover, 029-backport,  |  Actual Points:
  032-backport, 033-backport, 034-backport   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * keywords:
 protover, 029-backport, 032-backport, 033-backport, 034-backport,
 unicode
 => protover, 029-backport, 032-backport, 033-backport, 034-backport
 * status:  needs_review => needs_revision
 * milestone:  Tor: unspecified => Tor: 0.3.5.x-final


Comment:

 > Can this make it to 0.3.5?

 The 0.3.5 feature freeze is today (Friday 14 September).

 But bug fixes are not features, so we review them and backport them to
 previous releases as needed.

 I tried reviewing this branch, but it seems to contain a whole bunch of
 fixes. Most of the fixes have other tickets. Can you provide one branch
 per fix, with no other fixes?

 If there are dependencies, can you say which branches depend on other
 branches, so that I know which branches to review first?

 Also, we try not to use `tor_assert()` for non-fatal bugs, because it
 terminates the process. Instead, we use `tor_assert_nonfatal()`, or
 `if(BUG()) { /* action on failure */ }`.

 This branch doesn't merge cleanly into master, I think because some of the
 fixes have already been merged to master. Can you rebase this branch on
 the latest maint-0.2.9?

 I opened a pull request for this branch on 0.2.9 here:
 https://github.com/torproject/tor/pull/332

 Once the merge conflicts are fixed, we can merge to 0.3.4 to get Appveyor
 CI as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27316 [Core Tor/Tor]: protover.c accepts arbitrary bytes in protocol names

[Tor Bug Tracker & Wiki]

#27316: protover.c accepts arbitrary bytes in protocol names
-+-
 Reporter:  cyberpunks   |  Owner:
 |  cyberpunks
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  protover, 029-backport,  |  Actual Points:
  032-backport, 033-backport, 034-backport,  |
  unicode|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by cyberpunks):

 Can this make it to 0.3.5?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27316 [Core Tor/Tor]: protover.c accepts arbitrary bytes in protocol names

[Tor Bug Tracker & Wiki]

#27316: protover.c accepts arbitrary bytes in protocol names
-+-
 Reporter:  cyberpunks   |  Owner:
 |  cyberpunks
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  protover, 029-backport,  |  Actual Points:
  032-backport, 033-backport, 034-backport,  |
  unicode|
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:   => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27316 [Core Tor/Tor]: protover.c accepts arbitrary bytes in protocol names

[Tor Bug Tracker & Wiki]

#27316: protover.c accepts arbitrary bytes in protocol names
-+-
 Reporter:  cyberpunks   |  Owner:
 |  cyberpunks
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  protover, 029-backport,  |  Actual Points:
  032-backport, 033-backport, 034-backport,  |
  unicode|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27316 [Core Tor/Tor]: protover.c accepts arbitrary bytes in protocol names

[Tor Bug Tracker & Wiki]

#27316: protover.c accepts arbitrary bytes in protocol names
-+-
 Reporter:  cyberpunks   |  Owner:
 |  cyberpunks
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  protover, 029-backport,  |  Actual Points:
  032-backport, 033-backport, 034-backport,  |
  unicode|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by rl1987):

 * owner:  rl1987 => cyberpunks
 * status:  accepted => assigned


Comment:

 Nice progress! I'll set you as an owner of this ticket then.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27316 [Core Tor/Tor]: protover.c accepts arbitrary bytes in protocol names

[Tor Bug Tracker & Wiki]

#27316: protover.c accepts arbitrary bytes in protocol names
-+-
 Reporter:  cyberpunks   |  Owner:  rl1987
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  protover, 029-backport,  |  Actual Points:
  032-backport, 033-backport, 034-backport,  |
  unicode|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cyberpunks):

 See the protokeyword1 branch at https://gitgud.io/onionk/tor.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27316 [Core Tor/Tor]: protover.c accepts arbitrary bytes in protocol names

[Tor Bug Tracker & Wiki]

#27316: protover.c accepts arbitrary bytes in protocol names
-+-
 Reporter:  cyberpunks   |  Owner:  rl1987
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  protover, 029-backport,  |  Actual Points:
  032-backport, 033-backport, 034-backport,  |
  unicode|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by rl1987):

 * status:  new => accepted
 * owner:  (none) => rl1987


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27316 [Core Tor/Tor]: protover.c accepts arbitrary bytes in protocol names

[Tor Bug Tracker & Wiki]

#27316: protover.c accepts arbitrary bytes in protocol names
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  protover, 029-backport,  |  Actual Points:
  032-backport, 033-backport, 034-backport,  |
  unicode|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * milestone:   => Tor: unspecified


Comment:

 Thanks for finding this bug.

 Replying to [ticket:27316 cyberpunks]:
 > [https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt dir-
 spec.txt] defines a protocol name as a Keyword, and strictly limits what
 character set is allowed in a Keyword:
 > {{{
 > Keyword = KeywordChar+
 > KeywordChar ::= 'A' ... 'Z' | 'a' ... 'z' | '0' ... '9' | '-'
 > }}}
 >
 > But `"Foo_Bar=1"`, `",,,=1"`, and arbitrary Unicode strings like
 `"Risqu\u00e9=1"` are accepted.

 We can safely reject descriptors, votes, and consensuses containing non-
 keyword characters.

 > Bytes that aren't even valid Unicode like `"\xc1=1"` are also fine, as
 long as no bytes are the null byte, `=`, or the space character.

 Tor doesn't do any Unicode checks on directory documents yet.
 (More precisely, when built without Rust, tor doesn't do any Unicode
 checks. When built with Rust, protover does Unicode checks.)
 Here's a proposal for consistently checking Unicode in directory
 documents:
 https://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27316 [Core Tor/Tor]: protover.c accepts arbitrary bytes in protocol names

[Tor Bug Tracker & Wiki]

#27316: protover.c accepts arbitrary bytes in protocol names
-+-
 Reporter:   |  Owner:  (none)
  cyberpunks |
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core |Version:  Tor: 0.2.9.4-alpha
  Tor/Tor|   Keywords:  protover, 029-backport,
 Severity:  Normal   |  032-backport, 033-backport, 034-backport,
 |  unicode
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 [https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt dir-spec.txt]
 defines a protocol name as a Keyword, and strictly limits what character
 set is allowed in a Keyword:
 {{{
 Keyword = KeywordChar+
 KeywordChar ::= 'A' ... 'Z' | 'a' ... 'z' | '0' ... '9' | '-'
 }}}

 But `"Foo_Bar=1"`, `",,,=1"`, and arbitrary Unicode strings like
 `"Risqu\u00e9=1"` are accepted. Bytes that aren't even valid Unicode like
 `"\xc1=1"` are also fine, as long as no bytes are the null byte, `=`, or
 the space character.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs