Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:  0.1
  -must-alpha|
Parent ID:  #30320   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * actualpoints:   => 0.1


Comment:

 Replying to [comment:17 sysrqb]:
 > Replying to [comment:11 gk]:
 > > Replying to [comment:7 gk]:
 > > > `bug_27493` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_27493=e361790e2540af786386b6a13ac9477d82267db7)
 has the changes. I still need to test them.
 > >
 > > This works for me.
 >
 > This looks good to me. The change is deleting non-existant options,
 deleting deprecated syntax, deleting comments, or adding `ac_add_options
 --enable-proxy-bypass-protection`.

 Thanks! Merged to `master` (commit
 ec79824470dcd6815ffd903c8c9974808859f9e5).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha|
Parent ID:  #30320   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:11 gk]:
 > Replying to [comment:7 gk]:
 > > `bug_27493` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_27493=e361790e2540af786386b6a13ac9477d82267db7)
 has the changes. I still need to test them.
 >
 > This works for me.

 This looks good to me. The change is deleting non-existant options,
 deleting deprecated syntax, deleting comments, or adding `ac_add_options
 --enable-proxy-bypass-protection`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha|
Parent ID:  #30320   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: sysrqb (added)


Comment:

 #31813 is duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha|
Parent ID:  #30320   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Yes, Mozilla sets it and LTO in ESR 68.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha|
Parent ID:  #30320   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 #31308 is duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha|
Parent ID:  #30320   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 They forgot. Only that:
 
https://hg.mozilla.org/mozreview/gecko/rev/de0f0fa6f19d116db5e6d05ade564b3e990814da#l1.12

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha|
Parent ID:  #30320   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:10 cypherpunks]:
 > `+ac_add_options --enable-rust-simd`?

 That could be done in a different bug if Mozilla set it in ESR 68.
 However, I don't see that to be the case.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha|
Parent ID:  #30320   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201909, tbb-9.0-must-alpha =>
 TorBrowserTeam201909R, tbb-9.0-must-alpha
 * status:  new => needs_review


Comment:

 Replying to [comment:7 gk]:
 > `bug_27493` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_27493=e361790e2540af786386b6a13ac9477d82267db7)
 has the changes. I still need to test them.

 This works for me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha  |
Parent ID:  #30320   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 `+ac_add_options --enable-rust-simd`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha  |
Parent ID:  #30320   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 > Hrm, also look at ​https://dxr.mozilla.org/mozilla-
 esr60/source/browser/config/mozconfigs/whitelist
 That's about https://dxr.mozilla.org/mozilla-
 release/search?q=BUILDING_RELEASE

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha  |
Parent ID:  #30320   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * parent:  #30429 => #30320


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha  |
Parent ID:  #30429   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201902, tbb-9.0-must-alpha =>
 TorBrowserTeam201909, tbb-9.0-must-alpha


Comment:

 `bug_27493` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_27493=e361790e2540af786386b6a13ac9477d82267db7)
 has the changes. I still need to test them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201902, tbb-9.0-must-  |  Actual Points:
  alpha  |
Parent ID:  #30429   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 `TorBrowserTeam201902` 0_o

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201902, tbb-9.0-must-  |  Actual Points:
  alpha  |
Parent ID:  #30429   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * points:  0.25 => 0.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201902, tbb-9.0-must-  |  Actual Points:
  alpha  |
Parent ID:  #30429   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:   => TorBrowserTeam201902, tbb-9.0-must-alpha
 * points:   => 0.25


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #30429| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * parent:   => #30429


Comment:

 That'll be done in #30429.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by reportUrl):

 Hrm, also look at https://dxr.mozilla.org/mozilla-
 esr60/source/browser/config/mozconfigs/whitelist

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by reportUrl):

 Replying to [ticket:27493 sysrqb]:
 > In #27472, we added `export MOZILLA_OFFICIAL=1` in `.mozconfig-android`
 because we found the compiled APK wasn't releasable (it was still
 debuggable). This was due to MOZILLA_OFFICIAL not being set correctly at
 build-time. After exporting MOZILLA_OFFICIAL, the resulting APK is for
 release. Do we need both `mk_add_options` and `export` or do we only need
 `export`?
 Where did you get that `mk_add_options` trash? From pre-esr era? Mozilla
 removed almost all occurences of it, read https://dxr.mozilla.org/mozilla-
 esr60/source/build/docs/mozconfigs.rst#31
 > Should we use `export` on the desktop builds, too?
 Not you, but tbb-team, and long ago. That's #27623 now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

[Tor Bug Tracker & Wiki]

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 In #27472, we added `export MOZILLA_OFFICIAL=1` in `.mozconfig-android`
 because we found the compiled APK wasn't releasable (it was still
 debuggable). This was due to MOZILLA_OFFICIAL not being set correctly at
 build-time. After exporting MOZILLA_OFFICIAL, the resulting APK is for
 release. Do we need both `mk_add_options` and `export` or do we only need
 `export`? Should we use `export` on the desktop builds, too?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs