Re: [tor-bugs] #27625 [Core Tor/Tor]: add unit tests for tokenize_string() and get_next_token()

[Tor Bug Tracker & Wiki]

#27625: add unit tests for tokenize_string() and get_next_token()
---+---
 Reporter:  cyberpunks |  Owner:  rl1987
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.6.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  implemented
 Keywords:  tor-unittests, tor-tests-unit  |  Actual Points:
Parent ID: | Points:
 Reviewer:  dgoulet|Sponsor:
---+---
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Nice, merged!  Added #28177 for re-sorting the array (there were other
 test groups out of order too).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27625 [Core Tor/Tor]: add unit tests for tokenize_string() and get_next_token()

[Tor Bug Tracker & Wiki]

#27625: add unit tests for tokenize_string() and get_next_token()
---+---
 Reporter:  cyberpunks |  Owner:  rl1987
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.6.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-unittests, tor-tests-unit  |  Actual Points:
Parent ID: | Points:
 Reviewer:  dgoulet|Sponsor:
---+---
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 This is kind of awesome!!

 ACK on this.

 (Note: the current `dns` and now adding `parsecommon` tests are not in
 alphabetical order in the test array so once merged, lets fix that quickly
 else when one run `make test`, it is not easy to spot them if they aren't
 ordered!)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27625 [Core Tor/Tor]: add unit tests for tokenize_string() and get_next_token()

[Tor Bug Tracker & Wiki]

#27625: add unit tests for tokenize_string() and get_next_token()
---+---
 Reporter:  cyberpunks |  Owner:  rl1987
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.6.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-unittests, tor-tests-unit  |  Actual Points:
Parent ID: | Points:
 Reviewer:  dgoulet|Sponsor:
---+---
Changes (by dgoulet):

 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27625 [Core Tor/Tor]: add unit tests for tokenize_string() and get_next_token()

[Tor Bug Tracker & Wiki]

#27625: add unit tests for tokenize_string() and get_next_token()
---+---
 Reporter:  cyberpunks |  Owner:  rl1987
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.6.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-unittests, tor-tests-unit  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by nickm):

 * milestone:  Tor: unspecified => Tor: 0.3.6.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27625 [Core Tor/Tor]: add unit tests for tokenize_string() and get_next_token()

[Tor Bug Tracker & Wiki]

#27625: add unit tests for tokenize_string() and get_next_token()
---+---
 Reporter:  cyberpunks |  Owner:  rl1987
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-unittests, tor-tests-unit  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by rl1987):

 * status:  accepted => needs_review


Comment:

 https://github.com/torproject/tor/pull/409

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27625 [Core Tor/Tor]: add unit tests for tokenize_string() and get_next_token()

[Tor Bug Tracker & Wiki]

#27625: add unit tests for tokenize_string() and get_next_token()
---+---
 Reporter:  cyberpunks |  Owner:  rl1987
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-unittests, tor-tests-unit  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by rl1987):

 * owner:  (none) => rl1987
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27625 [Core Tor/Tor]: add unit tests for tokenize_string() and get_next_token()

[Tor Bug Tracker & Wiki]

#27625: add unit tests for tokenize_string() and get_next_token()
---+---
 Reporter:  cyberpunks |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-unittests, tor-tests-unit  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by nickm):

 * milestone:   => Tor: unspecified


Comment:

 +1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27625 [Core Tor/Tor]: add unit tests for tokenize_string() and get_next_token()

[Tor Bug Tracker & Wiki]

#27625: add unit tests for tokenize_string() and get_next_token()
--+---
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-unittests, tor-tests-unit
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+---
 It looks like there aren't any.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs