Re: [tor-bugs] #27739 [Core Tor/Tor]: rust protover_all_supported() accepts too-long protocol names

[Tor Bug Tracker & Wiki]

#27739: rust protover_all_supported() accepts too-long protocol names
+
 Reporter:  cyberpunks  |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.6.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.3.6
 Severity:  Normal  | Resolution:
 Keywords:  rust, protover  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by teor):

 * keywords:  035-must, protover, memory-safety, 033-backport, 034-backport
 => rust, protover
 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.6.x-final


Comment:

 Replying to [comment:4 cyberpunks]:
 > This isn't a memory-safety issue is it? And this is missing the rust
 tag.

 You're right, the memory safety issue is fixed by #27741.
 But it would still be good to remove all the redundant Unvalidated rust
 code due to the #27741 fix.
 We probably don't need to backport a refactor like this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27739 [Core Tor/Tor]: rust protover_all_supported() accepts too-long protocol names

[Tor Bug Tracker & Wiki]

#27739: rust protover_all_supported() accepts too-long protocol names
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.6
 Severity:  Normal   | Resolution:
 Keywords:  035-must, protover, memory-safety,   |  Actual Points:
  033-backport, 034-backport |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cyberpunks):

 This isn't a memory-safety issue is it? And this is missing the rust tag.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27739 [Core Tor/Tor]: rust protover_all_supported() accepts too-long protocol names

[Tor Bug Tracker & Wiki]

#27739: rust protover_all_supported() accepts too-long protocol names
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.6
 Severity:  Normal   | Resolution:
 Keywords:  035-must, protover, memory-safety,   |  Actual Points:
  033-backport, 034-backport |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 We should also re-enable the test that was disabled in
 
https://gitweb.torproject.org/tor.git/commit/?id=a5d4ce2b393955f60962d3db8744a846506c3e7b

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27739 [Core Tor/Tor]: rust protover_all_supported() accepts too-long protocol names

[Tor Bug Tracker & Wiki]

#27739: rust protover_all_supported() accepts too-long protocol names
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.6
 Severity:  Normal   | Resolution:
 Keywords:  035-must, protover, memory-safety,   |  Actual Points:
  033-backport, 034-backport |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * parent:  #27206 =>


Comment:

 Actually, let's do this as a separate change.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27739 [Core Tor/Tor]: rust protover_all_supported() accepts too-long protocol names

[Tor Bug Tracker & Wiki]

#27739: rust protover_all_supported() accepts too-long protocol names
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.6
 Severity:  Normal   | Resolution:
 Keywords:  035-must, protover, memory-safety,   |  Actual Points:
  033-backport, 034-backport |
Parent ID:  #27206   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:   => 035-must, protover, memory-safety, 033-backport,
 034-backport
 * parent:   => #27206
 * milestone:   => Tor: 0.3.5.x-final


Comment:

 See my explanation in:
 https://trac.torproject.org/projects/tor/ticket/27741#comment:1

 There's no reason for rust protover_all_supported() to accept too-long
 protocol names. We should remove the validated/unvalidated distinction,
 and backport the change to 0.3.3.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27739 [Core Tor/Tor]: rust protover_all_supported() accepts too-long protocol names

[Tor Bug Tracker & Wiki]

#27739: rust protover_all_supported() accepts too-long protocol names
--+--
 Reporter:  cyberpunks|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.6
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 
[https://gitweb.torproject.org/tor.git/commit/?id=569b4e57e23d728969a12751afc6b45f32d0f093
 569b4e57e23d728969a12751afc6b45f32d0f093] was fixing #25517 but kept the
 old behavior of allowing protocol names of any length for
 `protover_all_supported()`. That's the reason
 
[https://gitweb.torproject.org/tor.git/commit/?id=a5d4ce2b393955f60962d3db8744a846506c3e7b
 this unit test was failing, and ended up being disabled on rust builds]
 with a ??? comment of confusion.

 The reason given in the commit for this behavior was `in order to maintain
 compatibility with consensus methods older than 29.` but the corresponding
 
[https://gitweb.torproject.org/tor.git/commit/?id=eb966928428a80c105d33bd60bcae5503a1adeb7
 C code change] never made any exception like this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs