Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-11-19 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-hs, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by asn):

 Yes, please reopen this bug report if you can repro this with a tor newer
 than tor-0.3.5.4-alpha or tor-0.3.4.9. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-10-30 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-hs, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by tor_assertion_failed_):

 Ha, TBB 8.0.3 has just crashed in a minute after the startup:
 {{{
 Tor ERR: tor_assertion_failed_(): Bug: hs_cell.c:257:
 introduce1_set_encrypted_onion_key: Assertion onion_pk failed; aborting.
 (on Tor 0.3.4.8 da95b91355248ad8)
 Tor ERR: Bug: Assertion onion_pk failed in
 introduce1_set_encrypted_onion_key at hs_cell.c:257. (Stack trace not
 available) (on Tor 0.3.4.8 da95b91355248ad8)
 }}}
 Let's see how it goes with 0.3.4.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-10-24 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-hs, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by asn):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 We should backport #27797 since that's the root issue, whereas this is
 just a failsafe on top of it. Closing this and backporting #27797 instead.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-10-24 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 If we want to backport this, we'll need a branch soon before code rot sets
 in.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-10-23 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-10-23 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  tor-hs, 034-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * status:  closed => reopened
 * keywords:  tor-hs => tor-hs, 034-backport
 * resolution:  fixed =>


Comment:

 Someone on IRC (`lattera`) showed up and got it on 0.3.4.6. Here is the
 stacktrace:

 http://ix.io/1pRy

 We might want to consider a backport here imo? Flagging so we notice it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-09-21 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:  fixed
 Keywords:  tor-hs|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 okay, merged to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-09-21 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by dgoulet):

 *No* backport after consensus from me and asn. #27797 should be enough to
 avoid this. RARE edge case might trigger this on other tor in theory.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-09-21 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 backport / no backport?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-09-21 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-09-21 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by dgoulet):

 Hopefully final branch: ticket27774_035_03

 (Had to make _03 to reword the commit message. The diff with _02 should be
 empty.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-09-20 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by dgoulet):

 Branch: `ticket27774_035_02`
 PR: https://github.com/torproject/tor/pull/362

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-09-19 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * status:  new => needs_review


Comment:

 Branch `ticket27774_035_01`
 PR: https://github.com/torproject/tor/pull/358

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27774 [Core Tor/Tor]: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key

2018-09-18 Thread Tor Bug Tracker & Wiki 
#27774: hs-v3: Assertion onion_pk failed in introduce1_set_encrypted_onion_key
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.3.9
 Severity:  Normal| Resolution:
 Keywords:  tor-hs|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * component:  - Select a component => Core Tor/Tor


Comment:

 This actually sounds like a missing descriptor for the IP:

 `node_get_curve25519_onion_key()` can return NULL if no ri/md. Look in
 `setup_introduce1_data()` ... I think we might want to make that setup
 function be able to fail in such a case so the client can switch to a new
 IP.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs