Re: [tor-bugs] #27799 [Core Tor/Tor]: Split routerlist.c and dirserv.c into smaller modules

[Tor Bug Tracker & Wiki]

#27799: Split routerlist.c and dirserv.c into smaller modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:|  Actual Points:  .5
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * actualpoints:   => .5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27799 [Core Tor/Tor]: Split routerlist.c and dirserv.c into smaller modules

[Tor Bug Tracker & Wiki]

#27799: Split routerlist.c and dirserv.c into smaller modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => implemented


Comment:

 Made requested changes and merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27799 [Core Tor/Tor]: Split routerlist.c and dirserv.c into smaller modules

[Tor Bug Tracker & Wiki]

#27799: Split routerlist.c and dirserv.c into smaller modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 I think this is great. Some questions:

 I would be consistent on a file name that have `_fmt` for which it should
 be either at the start or end, doesn't matter, just that we have the same
 standard for all files.

 {{{
 fmt_serverstatus.c
 routerstatus_fmt.c
 }}}

 The other thing that confuses me is:

 {{{
   * recv_descs.c handles fingerprint files and processing incoming
 routerinfos that relays upload to us
 }}}

 The `recv_descs.c` file name seems to suggest to me that it is about
 receiving descriptors, not "handling" them per se. I would suggest using
 something around the lines of `handle_desc.c` or using the term "decision"
 somehow to show that the code in that file is about decision making of
 descriptors, not parsing, not I/O, not storing or "receiving".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27799 [Core Tor/Tor]: Split routerlist.c and dirserv.c into smaller modules

[Tor Bug Tracker & Wiki]

#27799: Split routerlist.c and dirserv.c into smaller modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:  dgoulet
  Sponsor:|
--+
 These are a couple of the biggest modules in Tor, and they have a bunch of
 responsibilities each.

 Per discussion, we're going to try to put more code movement into 0.3.5,
 to reduce the number of code-movement releases we need to merge across.

 See branch `split_routerlist_dirserv` with PR at
 https://github.com/torproject/tor/pull/363 .

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27799 [Core Tor/Tor]: Split routerlist.c and dirserv.c into smaller modules

[Tor Bug Tracker & Wiki]

#27799: Split routerlist.c and dirserv.c into smaller modules
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs