Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, protover,  |  Actual Points:
  035-deferred-20190115, 041-proposed, 033   |
  -unreached-backport|
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, protover,  |  Actual Points:
  035-deferred-20190115, 041-proposed, 033   |
  -unreached-backport|
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:16 teor]:
 > Ideally, the votes should be rejected when they are uploaded, so that
 the remote authority also gets a log.

 That rejection is added as part of #27194.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, protover,  |  Actual Points:
  035-deferred-20190115, 041-proposed, 033   |
  -unreached-backport|
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:15 ahf]:
 > Is skipping "bad" entries in the Smartlist, silently, really a good
 option here?

 It's definitely a much better option than the current behavior of silently
 discarding all entries, isn't it?

 This was just supposed to be a simple bugfix, without going into the weeds
 of more extensive improvements and refactoring this area of the code.
 (Adding logging really requires refactoring.)

 If you prefer to do them all at once instead, added logging and other
 improvements here:

 https://gitgud.io/onionk/tor/compare/master...rust-protover-unicode3

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, protover,  |  Actual Points:
  035-deferred-20190115, 041-proposed, 033   |
  -unreached-backport|
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-

Comment (by teor):

 Tor should log when it rejects votes, like it does with all other votes.

 Ideally, the votes should be rejected when they are uploaded, so that the
 remote authority also gets a log. But if that's not possible, that's ok.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, protover,  |  Actual Points:
  035-deferred-20190115, 041-proposed, 033   |
  -unreached-backport|
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Is skipping "bad" entries in the Smartlist, silently, really a good option
 here?

 Also, please submit this as a Github PR such that we can make sure our CI
 is run.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, protover,  |  Actual Points:
  035-deferred-20190115, 041-proposed, 033   |
  -unreached-backport|
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, protover,  |  Actual Points:
  035-deferred-20190115, 041-proposed, 033   |
  -unreached-backport|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  new => needs_review
 * milestone:  Tor: unspecified => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, protover,  |  Actual Points:
  035-deferred-20190115, 041-proposed, 033   |
  -unreached-backport|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:5 teor]:
 > #27741 has been merged.
 > Which branch do you want us to review?

 Branch here:

 https://gitgud.io/onionk/tor/compare/master...rust-protover-unicode

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, protover,  |  Actual Points:
  035-deferred-20190115, 041-proposed, 033   |
  -backport-unreached|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => new


Comment:

 We don't know which branch to review or revise for this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, protover, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  new => needs_revision


Comment:

 #27741 has been merged.
 Which branch do you want us to review?
 Does it need to be rebased?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, protover, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Do you want to wait until #27741 is merged?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
-+-
 Reporter:  cyberpunks   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, protover, 033-backport,|  Actual Points:
  034-backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  rust, protover => rust, protover, 033-backport, 034-backport


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
+
 Reporter:  cyberpunks  |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.3.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  rust, protover  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * milestone:   => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
+
 Reporter:  cyberpunks  |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Core Tor/Tor|Version:  Tor: 0.3.3.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  rust, protover  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by cyberpunks):

 Got a fix for this but it conflicts with #27741.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28081 [Core Tor/Tor]: rust protover discards all votes if one is not UTF-8

[Tor Bug Tracker & Wiki]

#28081: rust protover discards all votes if one is not UTF-8
+--
 Reporter:  cyberpunks  |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Component:  Core Tor/Tor
  Version:  Tor: 0.3.3.1-alpha  |   Severity:  Normal
 Keywords:  rust, protover  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs