Re: [tor-bugs] #28738 [Core Tor/sbws]: Stop merging multiple torrc options with the same name

[Tor Bug Tracker & Wiki]

#28738: Stop merging multiple torrc options with the same name
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by juga):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Thanks, squashed and merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28738 [Core Tor/sbws]: Stop merging multiple torrc options with the same name

[Tor Bug Tracker & Wiki]

#28738: Stop merging multiple torrc options with the same name
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  nickm  |Sponsor:
---+---

Comment (by juga):

 Replying to [comment:7 nickm]:
 > I think this is okay now, but in the long term we will want to fix the
 problem with option order not being preserved.  We could have a new ticket
 for that, but it shouldn't block this patch IMO.

 I created https://trac.torproject.org/projects/tor/ticket/29033

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28738 [Core Tor/sbws]: Stop merging multiple torrc options with the same name

[Tor Bug Tracker & Wiki]

#28738: Stop merging multiple torrc options with the same name
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by nickm):

 * status:  needs_information => merge_ready


Comment:

 Oops, I meant to put this in merge_ready

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28738 [Core Tor/sbws]: Stop merging multiple torrc options with the same name

[Tor Bug Tracker & Wiki]

#28738: Stop merging multiple torrc options with the same name
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by nickm):

 * status:  needs_review => needs_information


Comment:

 I think this is okay now, but in the long term we will want to fix the
 problem with option order not being preserved.  We could have a new ticket
 for that, but it shouldn't block this patch IMO.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28738 [Core Tor/sbws]: Stop merging multiple torrc options with the same name

[Tor Bug Tracker & Wiki]

#28738: Stop merging multiple torrc options with the same name
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 I made the modifications that teor suggested.
 I should change the commits' messages when i squash, since they are not
 true with the fixups.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28738 [Core Tor/sbws]: Stop merging multiple torrc options with the same name

[Tor Bug Tracker & Wiki]

#28738: Stop merging multiple torrc options with the same name
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  needs_revision
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  nickm  |Sponsor:
---+---

Comment (by teor):

 I left a comment on the PR:
 https://github.com/torproject/sbws/pull/308#discussion_r243477846

 I don't think sbws should duplicate Tor's option checks. Let's just put
 the options into the format that stem requires, and let Tor tell us if
 they worked.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28738 [Core Tor/sbws]: Stop merging multiple torrc options with the same name

[Tor Bug Tracker & Wiki]

#28738: Stop merging multiple torrc options with the same name
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  needs_revision
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 I left a comment on the PR. There are some options that _are_ allowed to
 appear more than once.  For example, this is legal:
 {{{
   Log debug file /foo/debug.log
   Log notice file /foo/notice.log

   SocksPort 
   SocksPort 9998
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28738 [Core Tor/sbws]: Stop merging multiple torrc options with the same name

[Tor Bug Tracker & Wiki]

#28738: Stop merging multiple torrc options with the same name
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by juga):

 * status:  new => needs_review


Comment:

 https://github.com/torproject/sbws/pull/308

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28738 [Core Tor/sbws]: Stop merging multiple torrc options with the same name

[Tor Bug Tracker & Wiki]

#28738: Stop merging multiple torrc options with the same name
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by juga):

 Replying to [comment:8 teor]:

 [..]
 > > Even if only stem.py uses these options, i think they should be in
 globals.py, since we might need to change them and globals.py should be
 the place where to change sbws defaults.
 >
 > Let's leave any refactoring until #28737.

 This would not change any functionality, but ok.

 [...]
 > Why write a parser, when tor will parse lines for us?

 There's not any way to pass torrc options to stem using torrc syntax, only
 dictionaries.

 > Option 4 is #28737, and it should work reasonably well. But it's a new
 feature, so it belongs in sbws 1.1.

 If i understand correctly this ticket, all the options would be in the
 form of dictionaries?

 > Here's another option:
 >
 > 5. Fix sbws' current tor option parsing code:
 >   * allow options with no argument (#28715)
 >   * stop trying to merge sbws options with the same name (#28738), until
 we refactor in sbws 1.1 (#28737)

 And not support "extra_lines" until 1.1?.
 I only need them for the test network. Do we have reasons why operators
 might need them?.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28738 [Core Tor/sbws]: Stop merging multiple torrc options with the same name

[Tor Bug Tracker & Wiki]

#28738: Stop merging multiple torrc options with the same name
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+---
 If sbws is configured with a default torrc option and an extra torrc
 option with the same name, then it merges the arguments in both options:
 https://gitweb.torproject.org/sbws.git/tree/sbws/util/stem.py#n175

 This is wrong in different ways, depending on the option
 1. "SocksPort auto 9050" is not a valid torrc option, the correct syntax
 is "SocksPort auto\nSocksPort 9050"
 2. "ExitPolicy accept *:80 accept *:443" is not a valid torrc option, the
 correct syntax is "ExitPolicy accept *:80,accept *:443" or "ExitPolicy
 accept *:80\nExitPolicy accept *:443"

 Instead of trying to understand torrc options, sbws should just set them
 all at once, and let Tor sort out the details.
 The stem.control.set_options() function takes a list of options, and
 applies them all at the same time.

 There are a few issues with this approach:
 1. Operators can't override some of sbws' default torrc options (we can
 fix this in #28737)
 2. Some torrc options need to be set after tor has bootstrapped:
   * DisablePredictedCircuits, but we might remove it in #28701
   * LeaveStreamsUnattached, but I think it can be set on the command-line
 3. Some torrc options aren't supported by all tor versions (#28646,
 #28692), so they need to be set at runtime, and allowed to fail

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs