Re: [tor-bugs] #28747 [Applications/Tor Browser]: Remove old NoScript related code (needed for dealing with the XPCOM version)

2018-12-05 Thread Tor Bug Tracker & Wiki
#28747: Remove old NoScript related code (needed for dealing with the XPCOM
version)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-torbutton, GeorgKoppen201812,|  Actual Points:
  TorBrowserTeam201812R  |
Parent ID:  #28745   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks! Merged to `master` (commit
 e0b17e85b5c8924e23653d863b043509a0083bf0).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28747 [Applications/Tor Browser]: Remove old NoScript related code (needed for dealing with the XPCOM version)

2018-12-05 Thread Tor Bug Tracker & Wiki
#28747: Remove old NoScript related code (needed for dealing with the XPCOM
version)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, GeorgKoppen201812,|  Actual Points:
  TorBrowserTeam201812R  |
Parent ID:  #28745   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by igt0):

 The patch looks good. I tested on Desktop and Mobile and didn't see any
 regression.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28747 [Applications/Tor Browser]: Remove old NoScript related code (needed for dealing with the XPCOM version)

2018-12-05 Thread Tor Bug Tracker & Wiki
#28747: Remove old NoScript related code (needed for dealing with the XPCOM
version)
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, GeorgKoppen201812,|  Actual Points:
  TorBrowserTeam201812R  |
Parent ID:  #28745   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-torbutton => tbb-torbutton, GeorgKoppen201812,
 TorBrowserTeam201812R
 * status:  new => needs_review


Comment:

 `bug_28747`
 
(https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_28747=e0b17e85b5c8924e23653d863b043509a0083bf0)
 has a patch for this bug up for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28747 [Applications/Tor Browser]: Remove old NoScript related code (needed for dealing with the XPCOM version)

2018-12-05 Thread Tor Bug Tracker & Wiki
#28747: Remove old NoScript related code (needed for dealing with the XPCOM
version)
--+---
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-torbutton
Actual Points:|  Parent ID:  #28745
   Points:|   Reviewer:
  Sponsor:|
--+---
 After switching to the new, WebExtensions-based NoScript there is unused
 code left in Torbutton dealing with the old XPCOM version. We should
 remove that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs