Re: [tor-bugs] #29015 [Core Tor/Tor]: Document tor_ersatz_socketpair() and the functions it calls

[Tor Bug Tracker & Wiki]

#29015: Document tor_ersatz_socketpair() and the functions it calls
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.5.1-alpha
 Severity:  Normal | Resolution:  implemented
 Keywords:  ipv6, easy, doc, fast-fix  |  Actual Points:  0.1
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+---
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 lgtm; merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29015 [Core Tor/Tor]: Document tor_ersatz_socketpair() and the functions it calls

[Tor Bug Tracker & Wiki]

#29015: Document tor_ersatz_socketpair() and the functions it calls
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.5.1-alpha
 Severity:  Normal | Resolution:
 Keywords:  ipv6, easy, doc, fast-fix  |  Actual Points:  0.1
Parent ID: | Points:  0.1
 Reviewer: |Sponsor:
---+---
Changes (by nickm):

 * parent:  #28995 =>


Comment:

 Removing parent relationship.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29015 [Core Tor/Tor]: Document tor_ersatz_socketpair() and the functions it calls

[Tor Bug Tracker & Wiki]

#29015: Document tor_ersatz_socketpair() and the functions it calls
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.5.1-alpha
 Severity:  Normal | Resolution:
 Keywords:  ipv6, easy, doc, fast-fix  |  Actual Points:  0.1
Parent ID:  #28995 | Points:  0.1
 Reviewer: |Sponsor:
---+---
Changes (by teor):

 * status:  needs_review => assigned
 * owner:  (none) => teor
 * points:   => 0.1
 * actualpoints:   => 0.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29015 [Core Tor/Tor]: Document tor_ersatz_socketpair() and the functions it calls

[Tor Bug Tracker & Wiki]

#29015: Document tor_ersatz_socketpair() and the functions it calls
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.5.1-alpha
 Severity:  Normal | Resolution:
 Keywords:  ipv6, easy, doc, fast-fix  |  Actual Points:  0.1
Parent ID:  #28995 | Points:  0.1
 Reviewer: |Sponsor:
---+---
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29015 [Core Tor/Tor]: Document tor_ersatz_socketpair() and the functions it calls

[Tor Bug Tracker & Wiki]

#29015: Document tor_ersatz_socketpair() and the functions it calls
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.5.1-alpha
 Severity:  Normal | Resolution:
 Keywords:  ipv6, easy, doc, fast-fix  |  Actual Points:
Parent ID:  #28995 | Points:
 Reviewer: |Sponsor:
---+---
Changes (by teor):

 * reviewer:  teor =>


Comment:

 Hey dgoulet, I can't review my own stuff.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29015 [Core Tor/Tor]: Document tor_ersatz_socketpair() and the functions it calls

[Tor Bug Tracker & Wiki]

#29015: Document tor_ersatz_socketpair() and the functions it calls
---+---
 Reporter:  teor   |  Owner:  (none)
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.0.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.3.5.1-alpha
 Severity:  Normal | Resolution:
 Keywords:  ipv6, easy, doc, fast-fix  |  Actual Points:
Parent ID:  #28995 | Points:
 Reviewer: |Sponsor:
---+---
Changes (by teor):

 * keywords:  035-backport, ipv6, easy, doc, fast-fix => ipv6, easy, doc,
 fast-fix
 * status:  new => needs_review


Comment:

 See my pull request:
 https://github.com/torproject/tor/pull/637

 We don't need to backport doc changes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29015 [Core Tor/Tor]: Document tor_ersatz_socketpair() and the functions it calls

[Tor Bug Tracker & Wiki]

#29015: Document tor_ersatz_socketpair() and the functions it calls
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.0.x-final
Component:  Core |Version:  Tor: 0.3.5.1-alpha
  Tor/Tor|   Keywords:  035-backport, ipv6, easy, doc,
 Severity:  Normal   |  fast-fix
Actual Points:   |  Parent ID:  #28995
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 The function comments in socketpair.c are missing or incomplete.

 Maybe we should add function comments, using the tor_socketpair() comment
 as a starting point?
 
​https://github.com/torproject/tor/blob/701eaef980de4f7dbb5c31c4fee9b7e1e266d7a1/src/lib/net/socket.c#L450

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs