Re: [tor-bugs] #29178 [Applications/Tor Browser]: Don't build master of goxcrypto, goxnet, uniuri and go-webrtc

[Tor Bug Tracker & Wiki]

#29178: Don't build master of goxcrypto, goxnet, uniuri and go-webrtc
+--
 Reporter:  boklm   |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  TorBrowserTeam201901R, tbb-rbm  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good. Merged to `master` (commit
 5bad67e4f31d984702c530cbd423d83d009e699a).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29178 [Applications/Tor Browser]: Don't build master of goxcrypto, goxnet, uniuri and go-webrtc

[Tor Bug Tracker & Wiki]

#29178: Don't build master of goxcrypto, goxnet, uniuri and go-webrtc
+--
 Reporter:  boklm   |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201901R, tbb-rbm  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * keywords:  TorBrowserTeam201901, tbb-rbm => TorBrowserTeam201901R, tbb-
   rbm
 * status:  new => needs_review


Comment:

 There is a patch for review in branch `bug_29178`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_29178=5bad67e4f31d984702c530cbd423d83d009e699a

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29178 [Applications/Tor Browser]: Don't build master of goxcrypto, goxnet, uniuri and go-webrtc

[Tor Bug Tracker & Wiki]

#29178: Don't build master of goxcrypto, goxnet, uniuri and go-webrtc
-+-
 Reporter:  boklm|  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  TorBrowserTeam201901,
 Severity:  Normal   |  tbb-rbm
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 During the review of #29143 we discussed in which cases a component in
 nightly builds should use the master commit. The conclusion was that we
 usually want to use master for the things we develop, but not for external
 components.

 goxcrypto, goxnet, uniuri are external components that are currently built
 using master. go-webrtc is not but has a `master` target that looks like
 if it was named master instead of nightly as an error.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs