Re: [tor-bugs] #29179 [Applications/Tor Browser]: Tor Browser nightly fails to build on macOS

[Tor Bug Tracker & Wiki]

#29179: Tor Browser nightly fails to build on macOS
+--
 Reporter:  boklm   |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Immediate   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201901R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks, closing. pospeselr: let me know if you are not happy with the
 fixups.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29179 [Applications/Tor Browser]: Tor Browser nightly fails to build on macOS

[Tor Bug Tracker & Wiki]

#29179: Tor Browser nightly fails to build on macOS
+--
 Reporter:  boklm   |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Immediate   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by mcs):

 r=mcs
 Both of the fixup commits look good to me. I did not try to build with
 them, but I know that is happening as part of the 8.5a7 release process.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29179 [Applications/Tor Browser]: Tor Browser nightly fails to build on macOS

[Tor Bug Tracker & Wiki]

#29179: Tor Browser nightly fails to build on macOS
+--
 Reporter:  boklm   |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Immediate   |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * cc: mcs, brade, pospeselr (added)
 * keywords:  tbb-rbm, TorBrowserTeam201901 => tbb-rbm,
   TorBrowserTeam201901R
 * status:  new => needs_review


Comment:

 Okay, this took longer than anticipated. There was more to actually fix.
 :( I pushed two fixup commits to `tor-browser-60.5.0esr-8.5-1`
 (https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-60.5.0esr-8.5-1=b6487d517d9982332f3bfad1f14b6e5ed9f77c53 and
 https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-
 browser-60.5.0esr-8.5-1=6dde994c6580634bd3cb9809c2eb0e02499e65b7). Let
 me know whether they look good to you.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29179 [Applications/Tor Browser]: Tor Browser nightly fails to build on macOS

[Tor Bug Tracker & Wiki]

#29179: Tor Browser nightly fails to build on macOS
---+--
 Reporter:  boklm  |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Immediate  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by gk):

 I.e.
 {{{
 -
 currentTransferable->SetRequestingPrincipal(mSourceNode->NodePrincipal());
 +  nsCOMPtr node = do_QueryInterface(mSourceNode);
 +  currentTransferable->SetRequestingPrincipal(node->NodePrincipal());
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29179 [Applications/Tor Browser]: Tor Browser nightly fails to build on macOS

[Tor Bug Tracker & Wiki]

#29179: Tor Browser nightly fails to build on macOS
---+--
 Reporter:  boklm  |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Immediate  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by gk):

 QIing to `nsINode` should fix that. I am currently testing a proposed fix

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29179 [Applications/Tor Browser]: Tor Browser nightly fails to build on macOS

[Tor Bug Tracker & Wiki]

#29179: Tor Browser nightly fails to build on macOS
---+--
 Reporter:  boklm  |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Immediate  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by watt):

 und test?
 https://hg.mozilla.org/mozilla-central/rev/0f709682e4a0

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29179 [Applications/Tor Browser]: Tor Browser nightly fails to build on macOS

[Tor Bug Tracker & Wiki]

#29179: Tor Browser nightly fails to build on macOS
---+--
 Reporter:  boklm  |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Immediate  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by gk):

 * priority:  Medium => Immediate


Comment:

 That's fallout from #29082, so we should fix that somehow before starting
 the alpha build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29179 [Applications/Tor Browser]: Tor Browser nightly fails to build on macOS

[Tor Bug Tracker & Wiki]

#29179: Tor Browser nightly fails to build on macOS
-+-
 Reporter:  boklm|  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-rbm,
 Severity:  Normal   |  TorBrowserTeam201901
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 The latest Tor Browser nightly failed to build on macOS in the firefox
 part:
 {{{
 17:55.18 /var/tmp/dist/macosx-toolchain/clang/bin/clang++ -target x86_64
 -apple-darwin11 -B /var/tmp/dist/macosx-toolchain/cctools/bin -isysroot
 /var/tmp/dist/macosx-toolchain/SDK -Werror=format -Werror=format-security
 -fstack-protector-strong -D_FORTIFY_SOURCE=2 -std=gnu++14 -o
 nsDragService.o -c -fvisibility=hidden -fvisibility-inlines-hidden
 -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_MACOSX=1
 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API
 -DIMPL_LIBXUL -I/var/tmp/build/firefox-394ffba812d6/widget/cocoa
 -I/var/tmp/build/firefox-394ffba812d6/obj-macos/widget/cocoa
 -I/var/tmp/build/firefox-394ffba812d6/obj-macos/ipc/ipdl/_ipdlheaders
 -I/var/tmp/build/firefox-394ffba812d6/ipc/chromium/src -I/var/tmp/build
 /firefox-394ffba812d6/ipc/glue -I/var/tmp/build/firefox-
 394ffba812d6/layout/forms -I/var/tmp/build/firefox-
 394ffba812d6/layout/generic -I/var/tmp/build/firefox-
 394ffba812d6/layout/style -I/var/tmp/build/firefox-394ffba812d6/layout/xul
 -I/var/tmp/build/firefox-394ffba812d6/widget -I/var/tmp/build/firefox-
 394ffba812d6/widget/headless -I/var/tmp/build/firefox-394ffba812d6/obj-
 macos/dist/include -I/var/tmp/build/firefox-394ffba812d6/obj-
 macos/dist/include/nspr -I/var/tmp/build/firefox-394ffba812d6/obj-
 macos/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /var/tmp/build
 /firefox-394ffba812d6/obj-macos/mozilla-config.h -Qunused-arguments
 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-
 body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-
 compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return
 -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc
 ++1z-compat -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-
 inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-
 bounds -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments
 -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-
 deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-
 strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-
 sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O3 -fomit-
 frame-pointer  -MD -MP -MF .deps/nsDragService.o.pp  -x objective-c++
 -fobjc-exceptions   /var/tmp/build/firefox-
 394ffba812d6/widget/cocoa/nsDragService.mm
 17:58.32 make[4]: Entering directory '/var/tmp/build/firefox-394ffba812d6
 /obj-macos/widget/headless'
 17:58.32 mkdir -p '.deps/'
 17:58.33 /var/tmp/dist/macosx-toolchain/clang/bin/clang++ -target x86_64
 -apple-darwin11 -B /var/tmp/dist/macosx-toolchain/cctools/bin -isysroot
 /var/tmp/dist/macosx-toolchain/SDK -Werror=format -Werror=format-security
 -fstack-protector-strong -D_FORTIFY_SOURCE=2 -std=gnu++14 -o
 Unified_cpp_widget_headless0.o -c -fvisibility=hidden -fvisibility-
 inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_MACOSX=1
 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API
 -DIMPL_LIBXUL -I/var/tmp/build/firefox-394ffba812d6/widget/headless
 -I/var/tmp/build/firefox-394ffba812d6/obj-macos/widget/headless
 -I/var/tmp/build/firefox-394ffba812d6/widget -I/var/tmp/build/firefox-
 394ffba812d6/widget/headless -I/var/tmp/build/firefox-
 394ffba812d6/widget/cocoa -I/var/tmp/build/firefox-394ffba812d6/obj-
 macos/ipc/ipdl/_ipdlheaders -I/var/tmp/build/firefox-
 394ffba812d6/ipc/chromium/src -I/var/tmp/build/firefox-
 394ffba812d6/ipc/glue -I/var/tmp/build/firefox-394ffba812d6/obj-
 macos/dist/include -I/var/tmp/build/firefox-394ffba812d6/obj-
 macos/dist/include/nspr -I/var/tmp/build/firefox-394ffba812d6/obj-
 macos/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /var/tmp/build
 /firefox-394ffba812d6/obj-macos/mozilla-config.h -Qunused-arguments
 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wempty-
 body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-
 compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return
 -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc
 ++1z-compat -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-
 inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-
 bounds -Wformat -Wformat-security